Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=465710

Terje Røsten terjeros@phys.ntnu.no changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |441378

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=465710

manuel wolfshant wolfy@nobugconsulting.ro changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |wolfy@nobugconsulting.ro Flag| |fedora-review+

--- Comment #2 from manuel wolfshant wolfy@nobugconsulting.ro 2008-10-06 06:34:15 EDT --- Package Review ==============

Key: - = N/A x = Check ! = Problem ? = Not evaluated

=== REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the Perl specific items [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: devel/x86_64 [x] Rpmlint output: source RPM: perl-qooxdoo-compat.src: E: unknown-key GPG#7666df64 -> ignorable 1 packages and 0 specfiles checked; 1 errors, 0 warnings. binary RPM:empty [x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Pac kaging Guidelines. [x] License field in the package spec file matches the actual license. License type: LGPLv2 or EPL [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [!] Sources used to build the package matches the upstream source, as provided in the spec URL. 2ab0cc8b437e09fbba1b9ccef064c826eaf06b8d qooxdoo-0.7.3-backend.zip [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines . [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [!] Package must own all directories that it creates. See issue 1 [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot}. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: devel/x86_64 [?] Package should compile and build into binary rpms on all supported architectures. Not tested on anything but devel.x86_64, but it is a standard noarch perl module, should build everywhere [?] Package functions as described. Not yet tested, I have to rebuild smokeping. but since it's basically the same module as before, there should be no surprises [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane.

ISSUES 1. The module is stored as /usr/lib/perl5/vendor_perl/5.10.0/Qooxdoo/JSONRPC.pm but the folder itself is not owned. Thanks Ralf for the second set of eyes.

Please fix the above before commiting to CVS. Package is APPROVED.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=465710

Kevin Fenzi kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

--- Comment #4 from Kevin Fenzi kevin@tummy.com 2008-10-07 13:46:43 EDT --- cvs done.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=465710

Terje Røsten terjeros@phys.ntnu.no changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE

--- Comment #6 from Terje Røsten terjeros@phys.ntnu.no 2008-10-18 07:03:48 EDT --- Things is in shape again, imported and built.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=465710

Mick Weiss fedora@mickweiss.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@mickweiss.com

--- Comment #8 from Mick Weiss fedora@mickweiss.com 2011-12-01 16:54:36 EST --- *** Bug 758451 has been marked as a duplicate of this bug. ***