Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879397
Bug ID: 879397 Summary: Review Request: php-Slim - PHP micro framework Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: johan@x-tnd.be
Spec URL: http://odysseus.x-tnd.be/fedora/php-Slim/php-Slim.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-Slim/php-Slim-2.1.0-2.fc17.src.rpm Description: PHP micro framework
Fedora Account System Username: trasher
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879397
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #651409| |review? Flags| | Assignee|nobody@fedoraproject.org |fedora@famillecollet.com
--- Comment #1 from Remi Collet fedora@famillecollet.com --- Created attachment 651409 --> https://bugzilla.redhat.com/attachment.cgi?id=651409&action=edit php-Slim-review.txt
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-17-x86_64 Command line :/usr/bin/fedora-review -b 879397
Please fixed the listed issues.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879397
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879397
--- Comment #2 from Johan Cwiklinski johan@x-tnd.be --- Thank you for taking this one :)
I'll fix the issues very soon. You're right about the paths, I'll change them, no need for an additional sub directory :)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879397
--- Comment #3 from Johan Cwiklinski johan@x-tnd.be --- Here the new version: Spec URL: http://odysseus.x-tnd.be/fedora/php-Slim/php-Slim.spec RPSM URL: http://odysseus.x-tnd.be/fedora/php-Slim/php-Slim-2.1.0-3.fc17.src.rpm
And the specfile's diff: http://odysseus.x-tnd.be/fedora/php-Slim/2.1.0-2_2.1.0-3.diff
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879397
--- Comment #4 from Johan Cwiklinski johan@x-tnd.be --- Hum... I forget to remove phpunit.xml.dist from %doc... The new version: Spec URL: http://odysseus.x-tnd.be/fedora/php-Slim/php-Slim.spec RPMS URL: http://odysseus.x-tnd.be/fedora/php-Slim/php-Slim-2.1.0-4.fc17.src.rpm
And the specfile's diff: http://odysseus.x-tnd.be/fedora/php-Slim/2.1.0-3_2.1.0-4.diff
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879397
--- Comment #5 from Johan Cwiklinski johan@x-tnd.be --- I did not pay attention to a rpmlint issue on phpunit.xml.dist permissions. I've also removed the %if in %check that is not needeed.
Here the new version: Spec URL: http://odysseus.x-tnd.be/fedora/php-Slim/php-Slim.spec SRPM URL: http://odysseus.x-tnd.be/fedora/php-Slim/php-Slim-2.1.0-5.fc17.src.rpm
And the specfile's diff: http://odysseus.x-tnd.be/fedora/php-Slim/2.1.0-4_2.1.0-5.diff
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879397
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #6 from Remi Collet fedora@famillecollet.com --- All blockers taken off, looks good.
==== APPROVED ====
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879397
Johan Cwiklinski johan@x-tnd.be changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #7 from Johan Cwiklinski johan@x-tnd.be --- New Package SCM Request ======================= Package Name: php-Slim Short Description: PHP micro framework Owners: trasher Branches: f17 f18 el6 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879397
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879397
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879397
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- php-Slim-2.1.0-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-Slim-2.1.0-5.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879397
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- php-Slim-2.1.0-5.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-Slim-2.1.0-5.el6
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879397
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- php-Slim-2.1.0-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-Slim-2.1.0-5.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879397
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879397
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-Slim-2.1.0-5.fc17 has been pushed to the Fedora 17 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879397
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2012-12-05 01:54:07
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879397
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- php-Slim-2.1.0-5.fc17 has been pushed to the Fedora 17 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879397
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-Slim-2.1.0-5.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879397
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- php-Slim-2.1.0-5.el6 has been pushed to the Fedora EPEL 6 stable repository.
package-review@lists.fedoraproject.org