https://bugzilla.redhat.com/show_bug.cgi?id=1773718

Brandon Perkins bperkins@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1773717

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1773717 [Bug 1773717] Review Request: golang-github-haproxytech-models - HAProxy Go structs for API

https://bugzilla.redhat.com/show_bug.cgi?id=1773718

Brandon Perkins bperkins@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor

https://bugzilla.redhat.com/show_bug.cgi?id=1773718

--- Comment #1 from Ryan O'Hara rohara@redhat.com --- Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/rohara/copr- build-1093546/review-golang-github-haproxytech-config- parser/licensecheck.txt [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: golang-github-haproxytech-config-parser-devel-1.1.10-1.fc32.noarch.rpm golang-github-haproxytech-config-parser-1.1.10-1.fc32.src.rpm golang-github-haproxytech-config-parser-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/haproxytech/config-parser/.goipath golang-github-haproxytech-config-parser.src: W: no-%build-section 2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). golang-github-haproxytech-config-parser-devel.noarch: W: invalid-url URL: https://github.com/haproxytech/config-parser <urlopen error [Errno -2] Name or service not known> golang-github-haproxytech-config-parser-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/haproxytech/config-parser/.goipath 1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Source checksums ---------------- https://github.com/haproxytech/config-parser/archive/v1.1.10/config-parser-1... : CHECKSUM(SHA256) this package : 7b4ad065209f52cb2beddd29b91416e0aff2f7eae163e7fd40eeaaaef2ab88ec CHECKSUM(SHA256) upstream package : 7b4ad065209f52cb2beddd29b91416e0aff2f7eae163e7fd40eeaaaef2ab88ec

Requires -------- golang-github-haproxytech-config-parser-devel (rpmlib, GLIBC filtered): go-filesystem

Provides -------- golang-github-haproxytech-config-parser-devel: golang(github.com/haproxytech/config-parser) golang(github.com/haproxytech/config-parser/common) golang(github.com/haproxytech/config-parser/errors) golang(github.com/haproxytech/config-parser/params) golang(github.com/haproxytech/config-parser/parsers) golang(github.com/haproxytech/config-parser/parsers/extra) golang(github.com/haproxytech/config-parser/parsers/filters) golang(github.com/haproxytech/config-parser/parsers/http) golang(github.com/haproxytech/config-parser/parsers/http/actions) golang(github.com/haproxytech/config-parser/parsers/simple) golang(github.com/haproxytech/config-parser/parsers/tcp) golang(github.com/haproxytech/config-parser/parsers/tcp/actions) golang(github.com/haproxytech/config-parser/tests) golang(github.com/haproxytech/config-parser/types) golang-github-haproxytech-config-parser-devel golang-ipath(github.com/haproxytech/config-parser)

Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18 Command line :/usr/bin/fedora-review --copr-build 1093546 Buildroot used: fedora-rawhide-{{ target_arch }} Active plugins: Generic, Shell-api Disabled plugins: Java, SugarActivity, Ocaml, PHP, C/C++, Haskell, fonts, Python, R, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

https://bugzilla.redhat.com/show_bug.cgi?id=1773718

--- Comment #3 from Brandon Perkins bperkins@redhat.com --- Turns out that a %build section breaks the go macros, as a result, I've reverted the change that made rpmlint happy: https://github.com/bdperkin/haproxytech/commit/6361a781c2f51ae9c11c317fd9cf4...

https://bugzilla.redhat.com/show_bug.cgi?id=1773718

--- Comment #5 from Brandon Perkins bperkins@redhat.com --- Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-g... SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedo... Successful copr build: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedo...

Changelog: * Mon Mar 02 2020 Brandon Perkins bperkins@redhat.com - 1.2.0-1 - Upgrade to version 1.2.0 - Clean changelog

* Wed Nov 13 2019 Brandon Perkins bperkins@redhat.com - 1.1.10-1 - Initial package

RPM Lint: golang-github-haproxytech-config-parser.src: W: no-%build-section golang-github-haproxytech-config-parser-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/haproxytech/config-parser/.goipath 2 packages and 0 specfiles checked; 0 errors, 2 warnings.

https://bugzilla.redhat.com/show_bug.cgi?id=1773718

--- Comment #7 from Ryan O'Hara rohara@redhat.com --- Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.

- ASL 2.0

[ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/rohara/1773718-golang-github-haproxytech-config- parser/licensecheck.txt

- The source contains LICENSE file containig Apache License 2.0.

[ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by:

- This seems like an issue with all Go modules, as mentioned above.

[ ]: %build honors applicable compiler flags or justifies otherwise.

- No %build here.

[ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format.

- All good.

[ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines

- All good.

[x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files.

- No issues above. Latest version is packaged, should be -devel package only (no binaries), and there is no upstream gpg key to use for verify.

[x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: golang-github-haproxytech-config-parser-devel-1.2.0-1.fc33.noarch.rpm golang-github-haproxytech-config-parser-1.2.0-1.fc33.src.rpm golang-github-haproxytech-config-parser-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/haproxytech/config-parser/.goipath golang-github-haproxytech-config-parser.src: W: no-%build-section 2 packages and 0 specfiles checked; 0 errors, 2 warnings.

- The .goipath hidden files seems to be unavoidable for Go packages.

Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). golang-github-haproxytech-config-parser-devel.noarch: W: invalid-url URL: https://github.com/haproxytech/config-parser <urlopen error [Errno -2] Name or service not known> golang-github-haproxytech-config-parser-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/haproxytech/config-parser/.goipath 1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Source checksums ---------------- https://github.com/haproxytech/config-parser/archive/v1.2.0/config-parser-1.... : CHECKSUM(SHA256) this package : 85dfc91e8a5666a7ebe124ff63a524c03030f42e14fae1edd4bde59b4fa06f21 CHECKSUM(SHA256) upstream package : 85dfc91e8a5666a7ebe124ff63a524c03030f42e14fae1edd4bde59b4fa06f21

Requires -------- golang-github-haproxytech-config-parser-devel (rpmlib, GLIBC filtered): go-filesystem

Provides -------- golang-github-haproxytech-config-parser-devel: golang(github.com/haproxytech/config-parser) golang(github.com/haproxytech/config-parser/common) golang(github.com/haproxytech/config-parser/errors) golang(github.com/haproxytech/config-parser/params) golang(github.com/haproxytech/config-parser/parsers) golang(github.com/haproxytech/config-parser/parsers/extra) golang(github.com/haproxytech/config-parser/parsers/filters) golang(github.com/haproxytech/config-parser/parsers/http) golang(github.com/haproxytech/config-parser/parsers/http/actions) golang(github.com/haproxytech/config-parser/parsers/simple) golang(github.com/haproxytech/config-parser/parsers/tcp) golang(github.com/haproxytech/config-parser/parsers/tcp/actions) golang(github.com/haproxytech/config-parser/tests) golang(github.com/haproxytech/config-parser/types) golang-github-haproxytech-config-parser-devel golang-ipath(github.com/haproxytech/config-parser)

Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1773718 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: C/C++, Ocaml, Python, Haskell, Java, PHP, R, SugarActivity, Perl, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

https://bugzilla.redhat.com/show_bug.cgi?id=1773718

--- Comment #8 from Brandon Perkins bperkins@redhat.com --- Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-g... SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedo... Successful copr build: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedo...

Changelog: * Mon Apr 27 2020 Brandon Perkins bperkins@redhat.com - 2.0.1-1 - Upgrade to version 2.0.1

* Mon Mar 02 2020 Brandon Perkins bperkins@redhat.com - 1.2.0-1 - Upgrade to version 1.2.0 - Clean changelog

* Wed Nov 13 2019 Brandon Perkins bperkins@redhat.com - 1.1.10-1 - Initial package

https://bugzilla.redhat.com/show_bug.cgi?id=1773718

Brandon Perkins bperkins@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1773720

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1773720 [Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API

https://bugzilla.redhat.com/show_bug.cgi?id=1773718

--- Comment #9 from Brandon Perkins bperkins@redhat.com --- Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-g... SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedo...

https://bugzilla.redhat.com/show_bug.cgi?id=1773718

--- Comment #11 from Mohan Boddu mboddu@bhujji.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-haproxytech-config-parser