Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=472066
Ian Weller <ianweller(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #2 from Ian Weller <ianweller(a)gmail.com> 2009-01-22 21:43:20 EDT ---
== FULL REVIEW of python-distutils-extra ==
[ OK ] specfiles match:
44a5da41e9a439cc18e94cf932eadbab python-distutils-extra.spec
44a5da41e9a439cc18e94cf932eadbab
python-distutils-extra-1.91.2-1.fc9.src/python-distutils-extra.spec
[ OK ] source files match upstream:
413ebd3e52c45437eaa36d1d9e6912fd python-distutils-extra_1.91.2.tar.gz
413ebd3e52c45437eaa36d1d9e6912fd
python-distutils-extra-1.91.2-1.fc9.src/python-distutils-extra_1.91.2.tar.gz
[ OK ] package meets naming and versioning guidelines.
[ OK ] spec is properly named, cleanly written, and uses macros consistently.
[ OK ] dist tag is present.
[ OK ] build root is correct.
[FAILED] license field matches the actual license.
Actual license is GPLv2+ according to debian/copyright
[ OK ] license is open source-compatible.
[ OK ] license text included in package.
[ OK ] latest version is being packaged.
[ OK ] BuildRequires are proper.
[ n/a ] compiler flags are appropriate.
[ OK ] %clean is present.
[ OK ] package builds in mock.
Scratch builds on Koji:
dist-f11 task # 1075451 passed
dist-f10 task # 1075453 passed
dist-f9 task # 1075470 passed
[ OK ] package installs properly.
[ n/a ] debuginfo package looks complete.
[ OK ] rpmlint is silent.
[ OK ] final provides and requires are sane
[ n/a ] %check is present and all tests pass:
[ OK ] no shared libraries are added to the regular linker search paths.
[ OK ] owns the directories it creates.
[ OK ] doesn't own any directories it shouldn't.
[ OK ] no duplicates in %files.
[ OK ] file permissions are appropriate.
[ n/a ] scriptlets match those on ScriptletSnippets page.
[ OK ] code, not content.
[ OK ] documentation is small, so no -docs subpackage is necessary.
[ OK ] %docs are not necessary for the proper functioning of the package.
[ OK ] no headers.
[ OK ] no pkgconfig files.
[ OK ] no libtool .la droppings.
[ n/a ] desktop files valid and installed properly.
-------------------------------------------------
I approve this package (python-distutils-extra)
-------------------------------------------------
Please make sure you fix the license tag before you import this into CVS.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.