https://bugzilla.redhat.com/show_bug.cgi?id=1299139 Mattia Verga <mattia.verga(a)tiscali.it&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1159999 (Astronomy-SIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1159999 [Bug 1159999] Astronomy SIG - review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1299139 Christian Dersch <lupinix(a)mailbox.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lupinix(a)mailbox.org --- Comment #2 from Christian Dersch <lupinix(a)mailbox.org&gt; --- Doesn't build @rawhide :( http://koji.fedoraproject.org/koji/taskinfo?taskID=12574742 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1299139 --- Comment #4 from Upstream Release Monitoring <upstream-release-monitoring(a)fedoraproject.org&gt; --- mattia's scratch build of astrometry-0.65-1.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12574968 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1299139 --- Comment #6 from Mattia Verga <mattia.verga(a)tiscali.it&gt; --- ...forgot what I said, I messed up with licenses. It's BSD NO advertising, you're right. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1299139 --- Comment #9 from Upstream Release Monitoring <upstream-release-monitoring(a)fedoraproject.org&gt; --- mattia's scratch build of astrometry-0.66-1.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12578072 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1299139 --- Comment #10 from Mattia Verga <mattia.verga(a)tiscali.it&gt; --- Spec URL: http://www.coolbits.it/fedora/astrometry.spec SRPM URL: http://www.coolbits.it/fedora/astrometry-0.66-2.fc23.src.rpm * Sun Jan 17 2016 Mattia Verga <mattia.verga(a)tiscali.it&gt; - 0.66-2 - -devel and -static are not noarch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1299139 --- Comment #12 from Mattia Verga <mattia.verga(a)tiscali.it&gt; --- Spec URL: http://www.coolbits.it/fedora/astrometry.spec SRPM URL: http://www.coolbits.it/fedora/astrometry-0.66-3.fc23.src.rpm %changelog * Sun Jan 17 2016 Mattia Verga <mattia.verga(a)tiscali.it&gt; - 0.66-3 - Add some index files for basic functionality - Config file should not be overwritten - Remove static libraries from package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1299139 --- Comment #14 from Mattia Verga <mattia.verga(a)tiscali.it&gt; --- Spec URL: http://www.coolbits.it/fedora/astrometry.spec SRPM URL: http://www.coolbits.it/fedora/astrometry-0.67-1.fc23.src.rpm %changelog * Sun Mar 03 2016 Mattia Verga <mattia.verga(a)tiscali.it&gt; - 0.67-1 - Update to 0.67 - Use pkgconfig for BR -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1299139 Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek(a)in.waw.pl --- Comment #16 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; --- The Summary doesn't match the description. Just say what the tools do in the Summary. In the comment about sources, provide explicit instructions how to download the sources, e.g. the arguments to the script if any any. Would it work with python3? Python3 is preferred. If the python bits are a module to be used externally, you should provide both python2 and python3 versions if both are supported. Also, you should use the %{python_provide} macro [https://fedoraproject.org/wiki/Packaging:Python#The_.25python_provide_macro]. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1299139 --- Comment #18 from Mattia Verga <mattia.verga(a)tiscali.it&gt; --- Thanks for the tips. I've asked upstream and found that python code is usable externally. I thought it wasn't and that's why I didn't packaged a separate python package. However, astronomy isn't compatible with python3. I need some more help about that (python guidelines are not clear to me): I think I should create a subpackage named "astronomy-python2" with a "Provides: python2-astronomy" line, right? The %python_provide macro usage explanation is not clear to me... Björn, about the %__global_ldflags: aren't they supposed to be applied with the ARCH_FLAGS="%{optflags}" passed to make? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1299139 --- Comment #20 from Mattia Verga <mattia.verga(a)tiscali.it&gt; --- Spec URL: http://www.coolbits.it/fedora/astrometry.spec SRPM URL: http://www.coolbits.it/fedora/astrometry-0.67-3.fc23.src.rpm %changelog * Thu Mar 17 2016 Mattia Verga <mattia.verga(a)tiscali.it&gt; - 0.67-3 - Apply mandatory ld flags * Wed Mar 16 2016 Mattia Verga <mattia.verga(a)tiscali.it&gt; - 0.67-2 - Add python2 subpackage -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1299139 --- Comment #21 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; --- Build fails in mock for me. Log: https://in.waw.pl/~zbyszek/fedora/astrometry-build-log -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1299139 --- Comment #23 from Mattia Verga <mattia.verga(a)tiscali.it&gt; --- ...sorry, I saw later that your mock was i686. So the only change is 'make -j2' vs 'make -j12' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1299139 --- Comment #25 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; --- -Werror strikes again: Testing swap qsort_r... ((gcc -Werror -o os-features-test-swap-qsort \ -g -Wall -ffinite-math-only -fno-signaling-nans -pthread -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -O3 -fomit-frame-pointer -DNDEBUG -fpic -Winline -I../include -I../include/astrometry -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -DAN_GIT_REVISION='"0.67"' -DAN_GIT_DATE='"Mon_Jan_25_11:20:00_2016_-0500"' -DAN_GIT_URL='"https://github.com/dstndstn/astrometry.net"' -I../util -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/libpng16 -I/usr/include/libpng16 -DWCSLIB_EXISTS -I../include -I../include/astrometry -I/usr/include/wcslib -I../include -I../include/astrometry -I/usr/include/wcslib -I. -DTEST_SWAP_QSORT_R os-features-test.c -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -g -Wall -ffinite-math-only -fno-signaling-nans -pthread -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -O3 -fomit-frame-pointer -DNDEBUG -fpic -Winline >> os-features.log && \ ./os-features-test-swap-qsort >> os-features.log && \ echo "#define NEED_SWAP_QSORT_R 0") \ || echo "#define NEED_SWAP_QSORT_R 1") >> ../include/astrometry/os-features-config.h.tmp os-features-test.c: In function 'main': os-features-test.c:68:36: error: passing argument 4 of 'qsort_r' from incompatible pointer type [-Werror=incompatible-pointer-types] qsort_r(array, N, sizeof(int), &mythunk, sortfunc); ^ In file included from os-features-test.c:5:0: /usr/include/stdlib.h:767:13: note: expected '__compar_d_fn_t {aka int (*)(const void *, const void *, void *)}' but argument is of type 'int *' extern void qsort_r (void *__base, size_t __nmemb, size_t __size, ^~~~~~~ cc1: all warnings being treated as errors There's also a bunch of interesting warnings: kdtree_internal.c: In function 'kdtree_build_2_fff': kdtree_internal.c:2247:2: warning: statement is indented as if it were guarded by... [-Wmisleading-indentation] kd->lr[0] = N - 1; ^~ kdtree_internal.c:2243:5: note: ...this 'if' clause, but it is not if (options & KD_BUILD_LINEAR_LR) ^~ Might be worth looking into. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1299139 --- Comment #27 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; --- Yes, you can. There's probably a bug in the build system, but not every bug has to be fixed (especially when it's in the build system, so it doesn't affect users). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1299139 --- Comment #29 from Mattia Verga <mattia.verga(a)tiscali.it&gt; --- Spec URL: http://www.coolbits.it/fedora/astrometry.spec SRPM URL: http://www.coolbits.it/fedora/astrometry-0.67-4.fc23.src.rpm %changelog * Sat Mar 19 2016 Mattia Verga <mattia.verga(a)tiscali.it&gt; - 0.67-4 - Limit parallel make at 4 processes to fix build on F25 - Remove odd symlink in sources - Fix wrong FSF address I removed an odd link in sources main directory because it breaks the license check part of fedora-review. About licenses (and the wrong FSF address fix) I've asked upstream to fix source headers, because the project was relicensed under BSD, but licenses in source headers are a mess: https://groups.google.com/forum/#!topic/astrometry/mCuyze3TOeM -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1299139 --- Comment #31 from Mattia Verga <mattia.verga(a)tiscali.it&gt; --- Spec URL: http://www.coolbits.it/fedora/astrometry.spec SRPM URL: http://www.coolbits.it/fedora/astrometry-0.67-5.fc24.src.rpm Sorry, bad link. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1299139 --- Comment #33 from Christian Dersch <lupinix(a)mailbox.org&gt; --- Is this one still alive? Links for SRPM and spec are no longer working. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1299139 Christian Dersch <lupinix(a)mailbox.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugzilla.redhat.com | |/show_bug.cgi?id=1470436 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component