https://bugzilla.redhat.com/show_bug.cgi?id=855780
Bug ID: 855780 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: apacheds-daemon - Reusable Daemon Framework Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: puntogil@libero.it Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://gil.fedorapeople.org/apacheds-daemon.spec SRPM URL: http://gil.fedorapeople.org/apacheds-daemon-1.1.8-1.fc16.src.rpm Description: Reusable framework for daemon applications based on Commons Daemon Jsvc and Procrun. A small installation layout pattern combined with some utility classes allows applications to be come UNIX daemons or Windows NT services. Reusable bootstrappers along with an installer plugin allow for the rapid creation of standalone daemon applications. Fedora Account System Username: gil ApacheDS/Studio build/requires
https://bugzilla.redhat.com/show_bug.cgi?id=855780
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |652183 (FE-JAVASIG)
https://bugzilla.redhat.com/show_bug.cgi?id=855780
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mizdebsk@redhat.com Assignee|nobody@fedoraproject.org |mizdebsk@redhat.com
--- Comment #1 from Mikolaj Izdebski mizdebsk@redhat.com --- I am taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=855780
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |823967
https://bugzilla.redhat.com/show_bug.cgi?id=855780
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(puntogil@libero.i | |t)
--- Comment #2 from Mikolaj Izdebski mizdebsk@redhat.com --- Fails to build in rawhide mock: http://koji.fedoraproject.org/koji/taskinfo?taskID=4574340
https://bugzilla.redhat.com/show_bug.cgi?id=855780
--- Comment #3 from Mikolaj Izdebski mizdebsk@redhat.com --- This package depends on tanukisoft:wrapper, but currently nothing in fedora provides this artifact.
https://bugzilla.redhat.com/show_bug.cgi?id=855780
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(puntogil@libero.i | |t) |
--- Comment #4 from gil cattaneo puntogil@libero.it --- build fine also with java-service-wrapper but i dont know how fix the problem if use x86_64 arch in koji
https://bugzilla.redhat.com/show_bug.cgi?id=855780
--- Comment #5 from Mikolaj Izdebski mizdebsk@redhat.com --- (In reply to comment #4)
build fine also with java-service-wrapper but i dont know how fix the problem if use x86_64 arch in koji
This will definitely have to be resolved.
https://bugzilla.redhat.com/show_bug.cgi?id=855780
--- Comment #6 from gil cattaneo puntogil@libero.it --- Spec URL: http://gil.fedorapeople.org/apacheds-daemon/1/apacheds-daemon.spec SRPM URL: http://gil.fedorapeople.org/apacheds-daemon/1/apacheds-daemon-1.1.8-2.fc16.s...
- fix build problems x86_64 arch
tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=4577842
https://bugzilla.redhat.com/show_bug.cgi?id=855780
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=855780
--- Comment #7 from Mikolaj Izdebski mizdebsk@redhat.com --- As it's now the package won't work peoperly, the problem is libdir usage in noarch package.
If package is built on 64-bit system then <systemPath> in pom.xml file will contain reference to /usr/lib64 and this package will work only on 64-bit systems (and vice versa, if the package is compiled on 32-bit system it will only work on 32-bit systems).
https://bugzilla.redhat.com/show_bug.cgi?id=855780
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|medium |high
--- Comment #8 from Mikolaj Izdebski mizdebsk@redhat.com --- Somehow I missed this bug, sorry for the delay. I'll try to review this package ASAP.
https://bugzilla.redhat.com/show_bug.cgi?id=855780
--- Comment #9 from gil cattaneo puntogil@libero.it --- Spec URL: http://gil.fedorapeople.org/apacheds-daemon.spec SRPM URL: http://gil.fedorapeople.org/apacheds-daemon-1.1.8-2.fc18.src.rpm
- minor changes for the new guideline
https://bugzilla.redhat.com/show_bug.cgi?id=855780
--- Comment #10 from Mikolaj Izdebski mizdebsk@redhat.com --- There are several problems with this package.
First of all, the package is noarch, but depends on arch-specific packages and hardcodes paths to libraries. This means that if this package is built on 32-bit system then it won't work properly on 64-bit ones and vice-versa.
You are using Maven scope "system". What's the reason behind that? Maven should be able to locate artifact in /usr/lib too. If not then either there is a bug in the package providing the artifact or in XMvn resolver. In either case this should be reported and fixed. Workaround is acceptable only if the real issue was reported.
You are injecting "<version>any</version>" to some POMs. What's the reason? Maven should be able to work without this. If it does not, please report a bug.
You are using old packaging guidelines. Please use the new guidelines for Fedora 19+. Fedora 19 is soon to be released. After Fedora 19 GA no new packages should be added to Fedora 18, so there is no reason to retain backwards-compatibility.
%global bits %(rpm --eval %{__isa_bits} | sed 's/32//') #%%global libdir %%{_prefix}/lib%%{bits}
That's not needed (see above).
# svn export http://svn.apache.org/repos/asf/directory/deceased/daemon/tags/daemon-parent... apacheds-daemon-1.1.8 # rm -rf apacheds-daemon-1.1.8/plugin/src/main/resources/org/apache/directory/daemon/installers/* # find apacheds-daemon-1.1.8 -name '*.bat' -delete # find apacheds-daemon-1.1.8 -name '*.class' -delete # find apacheds-daemon-1.1.8 -name '*.dll' -delete # find apacheds-daemon-1.1.8 -name '*.exe' -delete # find apacheds-daemon-1.1.8 -name '*.jar' -type f -delete # find apacheds-daemon-1.1.8 -name '*.jnilib' -delete # find apacheds-daemon-1.1.8 -name 'jsvc_*' -delete # find apacheds-daemon-1.1.8 -name '*.so' -delete # find apacheds-daemon-1.1.8 -name 'wrapper-*' -type f -delete # tar czf apacheds-daemon-1.1.8-clean-src-svn.tar.gz apacheds-daemon-1.1.8 Source0: %{name}-%{version}-clean-src-svn.tar.gz
To keep spec file simpler it would be better to create a separate shell script (cleanup-tarball.sh) to do the cleaning.
Patch0: %{name}-%{version}-disable-izpack.patch
I don't know what is the purpose of this patch. Every patch should have link to upstream bug or a comment explaining its purpose.
BuildRequires: java-devel
Not needed.
sed -i 's|${version}|${project.version}|' pom.xml
Is this necessary? Either explain why or provide link to upstream bug tracker.
%pom_xpath_inject "pom:project/pom:reporting/pom:plugins/pom:plugin[pom:artifactId='maven-surefire-report-plugin']" " <version>any</version>"
I don't see why would you inject version "any" to the POM. Again, you need to explain why you are doing this.
%pom_remove_dep tanukisoft:wrapper %pom_xpath_inject "pom:project/pom:dependencyManagement/pom:dependencies" ' <dependency> <groupId>tanukisoft</groupId> <artifactId>wrapper</artifactId> <version>any</version> <scope>system</scope> <systemPath>%{_prefix}/lib%{bits}/java-service-wrapper/wrapper.jar</systemPath> </dependency>' %pom_xpath_inject "pom:project/pom:dependencies" ' <dependency> <groupId>tanukisoft</groupId> <artifactId>wrapper</artifactId> <version>any</version> <scope>system</scope> <systemPath>%{_prefix}/lib%{bits}/java-service-wrapper/wrapper.jar</systemPath> </dependency>'
There is no need to use scope system with systemPath. Maven should be able to locate all artifacts, also under /usr/lib.
%pom_remove_dep org.apache.maven:maven-project plugin %pom_add_dep org.apache.maven:maven-core plugin
I understand why this was done (Maven 2 -> Maven 3 migration), but that doesn't have to be obvious for everyone. Please add a comment.
%pom_remove_dep plexus:plexus-utils plugin %pom_add_dep org.codehaus.plexus:plexus-utils plugin
plexus:plexus-utils is available in Fedora. There is no need to replace it with org.codehaus.plexus:plexus-utils.
https://bugzilla.redhat.com/show_bug.cgi?id=855780
--- Comment #11 from gil cattaneo puntogil@libero.it --- (In reply to Mikolaj Izdebski from comment #10)
%global bits %(rpm --eval %{__isa_bits} | sed 's/32//') #%%global libdir %%{_prefix}/lib%%{bits}
That's not needed (see above).
# svn export http://svn.apache.org/repos/asf/directory/deceased/daemon/tags/daemon-parent... apacheds-daemon-1.1.8 # rm -rf apacheds-daemon-1.1.8/plugin/src/main/resources/org/apache/directory/daemon/installers/* # find apacheds-daemon-1.1.8 -name '*.bat' -delete # find apacheds-daemon-1.1.8 -name '*.class' -delete # find apacheds-daemon-1.1.8 -name '*.dll' -delete # find apacheds-daemon-1.1.8 -name '*.exe' -delete # find apacheds-daemon-1.1.8 -name '*.jar' -type f -delete # find apacheds-daemon-1.1.8 -name '*.jnilib' -delete # find apacheds-daemon-1.1.8 -name 'jsvc_*' -delete # find apacheds-daemon-1.1.8 -name '*.so' -delete # find apacheds-daemon-1.1.8 -name 'wrapper-*' -type f -delete # tar czf apacheds-daemon-1.1.8-clean-src-svn.tar.gz apacheds-daemon-1.1.8 Source0: %{name}-%{version}-clean-src-svn.tar.gz
To keep spec file simpler it would be better to create a separate shell script (cleanup-tarball.sh) to do the cleaning.
Patch0: %{name}-%{version}-disable-izpack.patch
I don't know what is the purpose of this patch. Every patch should have link to upstream bug or a comment explaining its purpose.
BuildRequires: java-devel
Not needed.
ok removed
sed -i 's|${version}|${project.version}|' pom.xml
Is this necessary? Either explain why or provide link to upstream bug tracker.
%pom_xpath_inject "pom:project/pom:reporting/pom:plugins/pom:plugin[pom:artifactId='maven-surefire-report-plugin']" " <version>any</version>"
the intent is to remove all warnings
I don't see why would you inject version "any" to the POM. Again, you need to explain why you are doing this.
%pom_remove_dep tanukisoft:wrapper %pom_xpath_inject "pom:project/pom:dependencyManagement/pom:dependencies" ' <dependency> <groupId>tanukisoft</groupId> <artifactId>wrapper</artifactId> <version>any</version> <scope>system</scope> <systemPath>%{_prefix}/lib%{bits}/java-service-wrapper/wrapper.jar</systemPath> </dependency>' %pom_xpath_inject "pom:project/pom:dependencies" ' <dependency> <groupId>tanukisoft</groupId> <artifactId>wrapper</artifactId> <version>any</version> <scope>system</scope> <systemPath>%{_prefix}/lib%{bits}/java-service-wrapper/wrapper.jar</systemPath> </dependency>'
There is no need to use scope system with systemPath. Maven should be able to locate all artifacts, also under /usr/lib.
java-service-wrapper don provides maven depmap or pom ... maven or xmvn work also without these file?
%pom_remove_dep org.apache.maven:maven-project plugin %pom_add_dep org.apache.maven:maven-core plugin
I understand why this was done (), but that doesn't have to be obvious for everyone. Please add a comment.
ok done
%pom_remove_dep plexus:plexus-utils plugin %pom_add_dep org.codehaus.plexus:plexus-utils plugin
plexus:plexus-utils is available in Fedora. There is no need to replace it with org.codehaus.plexus:plexus-utils.
ok removed
Spec URL: http://gil.fedorapeople.org/apacheds-daemon.spec SRPM URL: http://gil.fedorapeople.org/apacheds-daemon-1.1.8-2.fc18.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=855780
--- Comment #12 from Mikolaj Izdebski mizdebsk@redhat.com --- (In reply to gil cattaneo from comment #11)
%pom_xpath_inject "pom:project/pom:reporting/pom:plugins/pom:plugin[pom:artifactId='maven-surefire-report-plugin']" " <version>any</version>"
the intent is to remove all warnings
There should be no warnings in Fedora 19+. If there are please file a bug report against xmvn package.
There is no need to use scope system with systemPath. Maven should be able to locate all artifacts, also under /usr/lib.
java-service-wrapper don provides maven depmap or pom ... maven or xmvn work also without these file?
Then these files should be added to java-service-wrapper package.
Spec URL: http://gil.fedorapeople.org/apacheds-daemon.spec SRPM URL: http://gil.fedorapeople.org/apacheds-daemon-1.1.8-2.fc18.src.rpm
The most important issues are still open.
https://bugzilla.redhat.com/show_bug.cgi?id=855780
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |977901
https://bugzilla.redhat.com/show_bug.cgi?id=855780
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |977904
https://bugzilla.redhat.com/show_bug.cgi?id=855780
--- Comment #13 from Mikolaj Izdebski mizdebsk@redhat.com --- I have filled 2 bugs for java-service-wrapper package. That's what should be done instead of adding ugly hacks like scope "system" and systemPath...
https://bugzilla.redhat.com/show_bug.cgi?id=855780
--- Comment #14 from Mikolaj Izdebski mizdebsk@redhat.com --- java-service-wrapper is fixed in rawhide now, you should remove your workarounds.
https://bugzilla.redhat.com/show_bug.cgi?id=855780
--- Comment #15 from gil cattaneo puntogil@libero.it --- Great! thanks
Spec URL: http://gil.fedorapeople.org/apacheds-daemon.spec SRPM URL: http://gil.fedorapeople.org/apacheds-daemon-1.1.8-2.fc18.src.rpm
- removed java-service-wrapper workarounds
https://bugzilla.redhat.com/show_bug.cgi?id=855780
--- Comment #16 from gil cattaneo puntogil@libero.it --- Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=5539859
https://bugzilla.redhat.com/show_bug.cgi?id=855780
--- Comment #17 from Mikolaj Izdebski mizdebsk@redhat.com --- Please convert the package to current packaging guidelines. This means using %mvn_build instead of mvn-rpmbuild. mvn-rpmbuild is a legacy feature and it shouldn't be used for new packages.
https://bugzilla.redhat.com/show_bug.cgi?id=855780
Bug 855780 depends on bug 977901, which changed state.
Bug 977901 Summary: java-service-wrapper: Wrong installation directory https://bugzilla.redhat.com/show_bug.cgi?id=977901
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=855780
Bug 855780 depends on bug 977904, which changed state.
Bug 977904 Summary: java-service-wrapper: Please install Maven POM file https://bugzilla.redhat.com/show_bug.cgi?id=977904
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=855780
--- Comment #18 from gil cattaneo puntogil@libero.it --- Spec URL: http://gil.fedorapeople.org/apacheds-daemon.spec SRPM URL: http://gil.fedorapeople.org/apacheds-daemon-1.1.8-2.fc18.src.rpm
- replace mvn-rpmbuild with mvn_build
https://bugzilla.redhat.com/show_bug.cgi?id=855780
--- Comment #19 from gil cattaneo puntogil@libero.it --- Spec URL: http://gil.fedorapeople.org/apacheds-daemon.spec SRPM URL: http://gil.fedorapeople.org/apacheds-daemon-1.1.8-2.fc19.src.rpm
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=5553676
- Full XMvn support
https://bugzilla.redhat.com/show_bug.cgi?id=855780
--- Comment #20 from Mikolaj Izdebski mizdebsk@redhat.com --- POM modifications just to remove warnings are missing the point. If there is a warning in the first place then the real reson should be fixed, not symptom. You can keep these modifications if you provide a reference to a bug report (either upsteam of Fedora).
https://bugzilla.redhat.com/show_bug.cgi?id=855780
--- Comment #21 from gil cattaneo puntogil@libero.it --- Spec URL: http://gil.fedorapeople.org/apacheds-daemon.spec SRPM URL: http://gil.fedorapeople.org/apacheds-daemon-1.1.8-2.fc19.src.rpm
- removed POM modifications
https://bugzilla.redhat.com/show_bug.cgi?id=855780
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@gmail.com Flags| |needinfo?(mizdebsk@redhat.c | |om)
--- Comment #22 from Christopher Meng cickumqt@gmail.com --- Ping?
https://bugzilla.redhat.com/show_bug.cgi?id=855780
--- Comment #23 from gil cattaneo puntogil@libero.it --- pong?
https://bugzilla.redhat.com/show_bug.cgi?id=855780
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mizdebsk@redhat.c | |om) |
--- Comment #24 from Mikolaj Izdebski mizdebsk@redhat.com --- (In reply to Christopher Meng from comment #22)
Ping?
What do you need to know? If you want to take the review, feel free to do so.
https://bugzilla.redhat.com/show_bug.cgi?id=855780
Bill Nottingham notting@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org | CC|notting@redhat.com |
https://bugzilla.redhat.com/show_bug.cgi?id=855780
Christopher Meng i@cicku.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(mizdebsk@redhat.c | |om)
https://bugzilla.redhat.com/show_bug.cgi?id=855780
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|mizdebsk@redhat.com |nobody@fedoraproject.org Flags|fedora-review? | |needinfo?(mizdebsk@redhat.c | |om) |
https://bugzilla.redhat.com/show_bug.cgi?id=855780
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|high |unspecified
https://bugzilla.redhat.com/show_bug.cgi?id=855780
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Blocks|652183 (FE-JAVASIG) | Resolution|--- |NOTABUG Last Closed| |2015-03-31 12:23:23
--- Comment #25 from gil cattaneo puntogil@libero.it --- No more interested
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla