Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465740 --- Comment #1 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; 2008-10-06 04:02:13 EDT --- SRPM URL is: http://mtasaka.fedorapeople.org/Review_request/rubygem-gettext/rubygem-ge... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465740 --- Comment #3 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; 2008-10-07 00:34:24 EDT --- Hello, thank you for your comments. (In reply to comment #2) - For this package "BR: gettext" is not needed because gettext .mo files are already shipped in gem. Also %find_lang is actually used (for symlinked mo files under %_datadir/locale) as: --------------------------------------------------------------------------- %find_lang rails %find_lang rgettext %{__cat} *.lang >> %{name}.lang %files -n ruby-gettext-package -f %{name}.lang --------------------------------------------------------------------------- The problem is that %find_lang cannot handle files under %gemdir - Will fix them - ruby(rubygems) pulls rubygems. And using virtual Provides for (Build)Requires is preferred (as well as perl) if possible. - This package already has "(Build)Requires: ruby(abi) = %rubyabi". - Because * non-gem version is actually called as ruby-gettext-package (on the upstream URL) * Also there is already a rpm named "ruby-gettext-package" in Fedora (which I currently maintain). This new rpm is to supersede current ruby-gettext-package after switching source from native tarball to gem. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465740 --- Comment #5 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; 2008-10-07 03:27:04 EDT --- Hello. (In reply to comment #4) Okay. This time I recreated gettext .mo files. Note that this package still does not have "BuildRequires: gettext". As the name of this package shows this package should provide the ruby inplementation of gettext and if msgfmt or so is needed this package should do it by itself. Actually this package uses calls ruby "iconv" method, which calls C gettext related functions. http://mtasaka.fedorapeople.org/Review_request/rubygem-gettext/rubygem-ge... http://mtasaka.fedorapeople.org/Review_request/rubygem-gettext/rubygem-ge... * Tue Oct 7 2008 Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; - 1.93.0-4 - Recreate gettext .mo files (by using this itself) Koji build: F-10: http://koji.fedoraproject.org/koji/taskinfo?taskID=865979 F-9: http://koji.fedoraproject.org/koji/taskinfo?taskID=865981 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465740 Orcan Ogetbil <orcanbahri(a)yahoo.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody(a)fedoraproject.org |orcanbahri(a)yahoo.com Alias| |rubygem-gettext Flag| |fedora-review+ --- Comment #7 from Orcan Ogetbil <orcanbahri(a)yahoo.com&gt; 2008-10-07 16:28:41 EDT --- Thanks for the update! * I have one suggestion. The two rpmlint errors: rubygem-gettext-doc.noarch: E: zero-length /usr/share/doc/rubygem-gettext-doc-1.93.0/test/rails/public/favicon.ico rubygem-gettext-doc.noarch: E: zero-length /usr/share/doc/rubygem-gettext-doc-1.93.0/samples/rails/public/favicon.ico These are favicons (the icon (image) that shows in your browser to the left of the addressbar when you go to a webpage). These are probably for the .html doc files. Having them at zero-length is most likely a mistake of upstream. I would let them know. You can also create a favicon from their logo yourself (with gimp or imagemagick or so) and replace with the in the package. I leave this up to you. -------------------------------------------------------------------------- * One last thing I noticed. If I go to /usr/share/doc/rubygem-gettext-doc-1.93.0/samples/rails/public/ or /usr/share/doc/rubygem-gettext-doc-1.93.0/test/rails/public/ the index.html there has a broken link: "About your applications environment" points to some non-existing file:///usr/share/doc/rubygem-gettext-doc-1.93.0/{samples,test}/rails/public/rails/info/properties Did you forget to package something, or is this an upstream mistake again? -------------------------------------------------------------------------- But otherwise the package seems good. Check these issues and see if there's anything we can do. I'm now approving it. -------------------------------------------------- This package (rubygem-gettext) is APPROVED by oget -------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465740 Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? --- Comment #9 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; 2008-10-07 23:06:20 EDT --- Thanks! - For zero length ico, for now I just keep these as they are. - About info/properties: This is related to "ruby on rails", however I am not familiar with it.. New Package CVS Request ======================= Package Name: rubygem-gettext Short Description: RubyGem of Localization Library and Tools for Ruby Owners: mtasaka Branches: F-9 F-8 InitialCC: sseago -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465740 --- Comment #11 from Huzaifa S. Sidhpurwala <huzaifas(a)redhat.com&gt; 2008-10-08 05:23:37 EDT --- cvs done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465740 Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE --- Comment #12 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; 2008-10-08 07:26:50 EDT --- Rebuilt on all branches, submitted push requests on bodhi, closing. Thank you for the review and CVS procedure. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465740 --- Comment #14 from Michael Stahnke <mastahnke(a)gmail.com&gt; 2010-12-27 11:11:41 EST --- Package Change Request ====================== Package Name: rubygem-gettext New Branches: el5 el6 Owners: stahnma InitialCC: Mamoru has stated I may maintain any of his ruby packages in EPEL -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.