[Bug 544964] New: Review Request: rubygem-mime-types - Return the MIME Content-Type for a given filename
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rubygem-mime-types - Return the MIME Content-Type for a given filename
https://bugzilla.redhat.com/show_bug.cgi?id=544964
Summary: Review Request: rubygem-mime-types - Return the MIME Content-Type for a given filename Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mkent@magoazul.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://magoazul.com/wip/SPECS/rubygem-mime-types.spec SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-mime-types-1.16-1.fc13.src.rpm Description: MIME::Types for Ruby manages a MIME Content-Type database that will return the Content-Type for a given filename.
MIME::Types was originally based on and synchronized with MIME::Types for Perl by Mark Overmeer, copyright 2001 - 2009. As of version 1.15, the data format for the MIME::Type list has changed and the synchronization will no longer happen.
mkent@fedora-devel-chef:~/rpmbuild/SPECS$ rpmlint rubygem-mime-types.spec /var/tmp/results/rubygem-mime-types-* rubygem-mime-types-doc.noarch: W: no-documentation rubygem-mime-types-doc.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/mime-types-1.16/ri/MIME/Type/like%3f-i.yaml %3f rubygem-mime-types-doc.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/mime-types-1.16/ri/MIME/Type/ascii%3f-i.yaml %3f rubygem-mime-types-doc.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/mime-types-1.16/ri/MIME/Types/%5b%5d-i.yaml %5b rubygem-mime-types-doc.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/mime-types-1.16/ri/MIME/Type/binary%3f-i.yaml %3f rubygem-mime-types-doc.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/mime-types-1.16/ri/MIME/Type/eql%3f-i.yaml %3f rubygem-mime-types-doc.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/mime-types-1.16/ri/MIME/Type/signature%3f-i.yaml %3f rubygem-mime-types-doc.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/mime-types-1.16/ri/MIME/Type/registered%3f-i.yaml %3f rubygem-mime-types-doc.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/mime-types-1.16/ri/MIME/Type/obsolete%3f-i.yaml %3f rubygem-mime-types-doc.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/mime-types-1.16/ri/MIME/Type/system%3f-i.yaml %3f rubygem-mime-types-doc.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/mime-types-1.16/ri/MIME/Type/%3c%3d%3e-i.yaml %3c rubygem-mime-types-doc.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/mime-types-1.16/ri/MIME/Type/docs%3d-i.yaml %3d rubygem-mime-types-doc.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/mime-types-1.16/ri/MIME/Type/platform%3f-i.yaml %3f rubygem-mime-types-doc.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/mime-types-1.16/ri/MIME/Type/complete%3f-i.yaml %3f rubygem-mime-types-doc.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/mime-types-1.16/ri/MIME/Types/%5b%5d-c.yaml %5b 3 packages and 1 specfiles checked; 0 errors, 15 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
Matthew Kent mkent@magoazul.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |549286
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Flag| |fedora-review?
--- Comment #1 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-12-23 14:41:21 EDT --- Well,
* License - I guess the license for this package should be "GPL+ or Ruby or Artistic".
* rcov for %check - build.log says: ------------------------------------------------------- 89 + rake test 90 Hoe.new {...} deprecated. Switch to Hoe.spec. 91 (in /builddir/build/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16) 92 which: no dot in (/usr/sbin:/usr/bin:/sbin:/bin:/usr/X11R6/bin:/root/bin:/usr/local/sbin) 93 /usr/bin/ruby -w -Ilib:ext:bin:test -e 'require "rubygems"; require "test/unit"; require "test/test_mime_type.rb"; require "test/test_mime_types.rb"' 94 RCov is not available. In order to run rcov, you must: sudo gem install spicycode-rcov ------------------------------------------------------- I don't know well about RCov, however when I install rubygem-rcov, rake check fails as: ------------------------------------------------------- [tasaka1@localhost mime-types-1.16]$ rake test --trace (in /home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16) Hoe.new {...} deprecated. Switch to Hoe.spec. rake aborted! undefined method `test_files' for #Hoe:0xb75d9a78 /home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16/Rakefile:53 /usr/lib/ruby/gems/1.8/gems/rcov-0.9.6/lib/rcov/rcovtask.rb:91:in `initialize' /home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16/Rakefile:51:in `new' /home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16/Rakefile:51 /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2382:in `load' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2382:in `raw_load_rakefile' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2016:in `load_rakefile' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2067:in `standard_exception_handling' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2015:in `load_rakefile' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:1999:in `run' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2067:in `standard_exception_handling' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:1997:in `run' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/bin/rake:31 /usr/bin/rake:19:in `load' /usr/bin/rake:19 ------------------------------------------------------- ref: http://bugs.gentoo.org/288996 Would you check this?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
--- Comment #2 from Matthew Kent mkent@magoazul.com 2009-12-28 01:04:28 EDT --- (In reply to comment #1)
Well,
- License
- I guess the license for this package should be "GPL+ or Ruby or Artistic".
Sure! Fixed.
- rcov for %check
- build.log says:
89 + rake test 90 Hoe.new {...} deprecated. Switch to Hoe.spec. 91 (in/builddir/build/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16) 92 which: no dot in (/usr/sbin:/usr/bin:/sbin:/bin:/usr/X11R6/bin:/root/bin:/usr/local/sbin) 93 /usr/bin/ruby -w -Ilib:ext:bin:test -e 'require "rubygems"; require "test/unit"; require "test/test_mime_type.rb"; require "test/test_mime_types.rb"' 94 RCov is not available. In order to run rcov, you must: sudo gem install spicycode-rcov
I don't know well about RCov, however when I install rubygem-rcov, rake check fails as:
[tasaka1@localhost mime-types-1.16]$ rake test --trace (in /home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16) Hoe.new {...} deprecated. Switch to Hoe.spec. rake aborted! undefined method `test_files' for #Hoe:0xb75d9a78 /home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16/Rakefile:53 /usr/lib/ruby/gems/1.8/gems/rcov-0.9.6/lib/rcov/rcovtask.rb:91:in `initialize' /home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16/Rakefile:51:in `new' /home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16/Rakefile:51 /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2382:in `load' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2382:in `raw_load_rakefile' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2016:in `load_rakefile' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2067:in `standard_exception_handling' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2015:in `load_rakefile' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:1999:in `run' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2067:in `standard_exception_handling' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:1997:in `run' /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/bin/rake:31 /usr/bin/rake:19:in `load' /usr/bin/rake:19
ref: http://bugs.gentoo.org/288996 Would you check this?
Rcov will produce a pretty report of the test coverage but is by no means necessary for the unit tests themselves.
As to the error it looks like the Rakefile wants a specific version of rcov,
p.extra_dev_deps << %w(rcov ~>0.8)
while Fedora is on 0.9.6. I'll file a ticket with the upstream project about updating it to something more recent.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
--- Comment #3 from Matthew Kent mkent@magoazul.com 2009-12-28 01:18:04 EDT --- Spec URL: http://magoazul.com/wip/SPECS/rubygem-mime-types.spec SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-mime-types-1.16-2.fc13.src.rpm
* Sun Dec 27 2009 Matthew Kent mkent@magoazul.com - 1.16-2 - Fix license (#544964). - Add note about rcov warning in test phase (#544964).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
--- Comment #4 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-12-28 11:29:26 EDT --- Well, what I am concerned here is that $ rake test actually _fails_ is Fedora rubygem-rcov is installed (as I wrote in the comment 2), not just warnings, so people who has rubygem-rcov installed cannot rebuild your srpm, which I think should be avoided.
It seem that the following line -------------------------------------------------- 53 t.test_files = hoe.test_files -------------------------------------------------- in Rakefile seems unneeded. Would you again check this?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
--- Comment #5 from Matthew Kent mkent@magoazul.com 2009-12-30 03:46:05 EDT --- (In reply to comment #4)
Well, what I am concerned here is that $ rake test actually _fails_ is Fedora rubygem-rcov is installed (as I wrote in the comment 2), not just warnings, so people who has rubygem-rcov installed cannot rebuild your srpm, which I think should be avoided.
It seem that the following line
53 t.test_files = hoe.test_files
in Rakefile seems unneeded. Would you again check this?
Ah sorry, you're 100% right - I forget people may build without mock. I'll remove the line during the test phase.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
--- Comment #6 from Matthew Kent mkent@magoazul.com 2009-12-30 05:35:33 EDT --- Seems the rcov task isn't necessary at all, newer versions of hoe provide the exact same thing in lib/hoe/rcov.rb.
Spec URL: http://magoazul.com/wip/SPECS/rubygem-mime-types.spec SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-mime-types-1.16-3.fc13.src.rpm
* Wed Dec 30 2009 Matthew Kent mkent@magoazul.com - 1.16-3 - Remove needless rcov task in Rakefile causing issue (#544964).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #7 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-12-30 12:42:01 EDT --- One thing - The part ">= 1.8.3" of "BR(check): rubygem(hoe)" is not needed unless you want to import this package into EPEL because rubygem-hoe packages in currently supported branches of Fedora all satisfy this version.
ref: the last sentence of https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires (not a blocker)
------------------------------------------------------------- This package (rubygem-mime-types) is APPROVED by mtasaka -------------------------------------------------------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
Matthew Kent mkent@magoazul.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #8 from Matthew Kent mkent@magoazul.com 2009-12-30 19:33:31 EDT --- (In reply to comment #7)
One thing
The part ">= 1.8.3" of "BR(check): rubygem(hoe)" is not needed unless you want to import this package into EPEL because rubygem-hoe packages in currently supported branches of Fedora all satisfy this version.
ref: the last sentence of https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires (not a blocker)
Oops, thanks - missed that one.
This package (rubygem-mime-types) is APPROVED by mtasaka
Thanks for the review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
--- Comment #9 from Matthew Kent mkent@magoazul.com 2009-12-30 19:34:32 EDT --- New Package CVS Request ======================= Package Name: rubygem-mime-types Short Description: Return the MIME Content-Type for a given filename Owners: mkent Branches: F-11 F-12 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #10 from Kevin Fenzi kevin@tummy.com 2010-01-02 15:14:13 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2010-01-07 02:27:30 EDT --- rubygem-mime-types-1.16-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rubygem-mime-types-1.16-3.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2010-01-07 02:28:02 EDT --- rubygem-mime-types-1.16-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-mime-types-1.16-3.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #13 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-01-07 11:39:43 EDT --- Closing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2010-01-07 16:41:16 EDT --- rubygem-mime-types-1.16-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |1.16-3.fc11 Resolution|NEXTRELEASE |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2010-01-07 16:45:21 EDT --- rubygem-mime-types-1.16-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|1.16-3.fc11 |1.16-3.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
Michal Fojtik mfojtik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mfojtik@redhat.com
--- Comment #16 from Michal Fojtik mfojtik@redhat.com 2010-08-02 04:30:19 EDT --- Hi, could you please push this package to F14/EL6 branch ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
Michael Stahnke mastahnke@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mastahnke@gmail.com Flag|fedora-cvs+ |fedora-cvs?
--- Comment #17 from Michael Stahnke mastahnke@gmail.com 2010-09-10 14:14:07 EDT --- Package Change Request ====================== Package Name: rubygem-mime-type New Branches: el5 el6 Owners: stahnma
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
--- Comment #18 from Michael Stahnke mastahnke@gmail.com 2010-09-10 14:39:23 EDT --- Package Change Request ====================== Package Name: rubygem-mime-types New Branches: el5 el6 Owners: stahnma
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
--- Comment #19 from Michael Stahnke mastahnke@gmail.com 2010-09-10 14:40:07 EDT --- mkent is aware of request.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
--- Comment #20 from Kevin Fenzi kevin@tummy.com 2010-09-10 14:41:38 EDT --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla