Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457545 Parag AN(पराग) <panemade(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade(a)gmail.com AssignedTo|nobody(a)fedoraproject.org |panemade(a)gmail.com --- Comment #1 from Parag AN(पराग) <panemade(a)gmail.com&gt; 2008-08-04 00:40:56 EDT --- Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=756359 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 29c6cd74081861f4bffe1f83943f5792 Net-Ping-External-0.12.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package perl-Net-Ping-External-0.12-1.fc10 => Provides: perl(Net::Ping::External) = 0.12 Requires: perl(Carp) perl(Exporter) perl(Socket) perl(strict) perl(vars) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.