https://bugzilla.redhat.com/show_bug.cgi?id=1715379 Parag AN(पराग) <panemade(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade(a)gmail.com Assignee|nobody(a)fedoraproject.org |panemade(a)gmail.com Flags| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade(a)gmail.com&gt; --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= 1) Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/parag/1715379-adobe- source-han-mono-fonts/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ ==> Plain text files are always downloaded in raw format. So use this Source1: https://raw.githubusercontent.com/adobe-fonts/source-han-mono/master/LICE... Source2: https://raw.githubusercontent.com/adobe-fonts/source-han-mono/master/READ... 2) Can Appdata metainfo file be included for this package? Otherwise this package looks good. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 3 files have unknown license. Detailed output of licensecheck in /home/parag/1715379-adobe-source-han-mono- fonts/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 102400 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://github.com/adobe- fonts/source-han-mono/releases/download/1.000/SourceHanMono.ttc See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /home/parag/1715379-adobe-source-han-mono- fonts/srpm-unpacked/adobe-source-han-mono-fonts.spec See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). fonts: [!]: Run repo-font-audit on all fonts in package. Note: Cannot find createrepo, install createrepo package to make a comprehensive font review. See: url: undefined [!]: Run ttname on all fonts in package. Note: Cannot find ttname command, install ttname package to make a comprehensive font review. See: url: undefined Rpmlint ------- Checking: adobe-source-han-mono-fonts-1.000-1.fc31.noarch.rpm adobe-source-han-mono-fonts-1.000-1.fc31.src.rpm adobe-source-han-mono-fonts.noarch: W: spelling-error Summary(en_US) monospaced -> mono spaced, mono-spaced, monocled adobe-source-han-mono-fonts.noarch: W: hidden-file-or-dir /usr/share/fonts/adobe-source-han-mono/.uuid adobe-source-han-mono-fonts.noarch: E: non-readable /usr/share/fonts/adobe-source-han-mono/.uuid 0 adobe-source-han-mono-fonts.src: W: spelling-error Summary(en_US) monospaced -> mono spaced, mono-spaced, monocled adobe-source-han-mono-fonts.src: W: invalid-url Source0: https://github.com/adobe-fonts/source-han-mono/releases/download/1.000/So... <urlopen error timed out> 2 packages and 0 specfiles checked; 1 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') adobe-source-han-mono-fonts.noarch: W: spelling-error Summary(en_US) monospaced -> mono spaced, mono-spaced, monocled adobe-source-han-mono-fonts.noarch: W: invalid-url URL: https://github.com/adobe-fonts/source-han-mono/ <urlopen error [Errno -2] Name or service not known> adobe-source-han-mono-fonts.noarch: W: hidden-file-or-dir /usr/share/fonts/adobe-source-han-mono/.uuid adobe-source-han-mono-fonts.noarch: E: non-readable /usr/share/fonts/adobe-source-han-mono/.uuid 0 1 packages and 0 specfiles checked; 1 errors, 3 warnings. Source checksums ---------------- https://github.com/adobe-fonts/source-han-mono/blob/master/README.md : CHECKSUM(SHA256) this package : 3a4944c0f2d4d071b24a277d5061e7ea848e303eb44d4f3db4d1bb78dd53e2bb CHECKSUM(SHA256) upstream package : ac3f5240be84c481075faf3fd259a43ec188030a1b09d7af34f1c2a9ae1d90c2 https://github.com/adobe-fonts/source-han-mono/blob/master/LICENSE.md : CHECKSUM(SHA256) this package : 3c389e68fe2c5873f23aafb23a31784d0200d5438905c859925044b3d9841fd2 CHECKSUM(SHA256) upstream package : 43932fa2001596d7ba1ef70488919032b963ffa4310df4dbfedbeb56a45a76a9 diff -r also reports differences Requires -------- adobe-source-han-mono-fonts (rpmlib, GLIBC filtered): config(adobe-source-han-mono-fonts) fontpackages-filesystem Provides -------- adobe-source-han-mono-fonts: adobe-source-han-mono-fonts config(adobe-source-han-mono-fonts) font(:lang=aa) font(:lang=an) font(:lang=ay) font(:lang=bg) font(:lang=bi) font(:lang=bin) font(:lang=br) font(:lang=ch) font(:lang=da) font(:lang=de) font(:lang=en) font(:lang=es) font(:lang=eu) font(:lang=fil) font(:lang=fj) font(:lang=fo) font(:lang=fur) font(:lang=fy) font(:lang=gd) font(:lang=gl) font(:lang=gn) font(:lang=gv) font(:lang=haw) font(:lang=ho) font(:lang=ht) font(:lang=ia) font(:lang=id) font(:lang=ie) font(:lang=ig) font(:lang=io) font(:lang=is) font(:lang=it) font(:lang=ja) font(:lang=jv) font(:lang=ki) font(:lang=kj) font(:lang=ko) font(:lang=kum) font(:lang=kwm) font(:lang=lb) font(:lang=li) font(:lang=mg) font(:lang=ms) font(:lang=na) font(:lang=nb) font(:lang=nds) font(:lang=ng) font(:lang=nl) font(:lang=nn) font(:lang=no) font(:lang=nr) font(:lang=oc) font(:lang=om) font(:lang=os) font(:lang=pap-an) font(:lang=pap-aw) font(:lang=pt) font(:lang=rm) font(:lang=rn) font(:lang=ru) font(:lang=rw) font(:lang=sc) font(:lang=sel) font(:lang=sg) font(:lang=sm) font(:lang=sma) font(:lang=smj) font(:lang=sn) font(:lang=so) font(:lang=sq) font(:lang=ss) font(:lang=st) font(:lang=su) font(:lang=sv) font(:lang=sw) font(:lang=tl) font(:lang=to) font(:lang=ts) font(:lang=uz) font(:lang=vo) font(:lang=wa) font(:lang=xh) font(:lang=yap) font(:lang=za) font(:lang=zh-cn) font(:lang=zh-hk) font(:lang=zh-mo) font(:lang=zh-sg) font(:lang=zh-tw) font(:lang=zu) font(sourcehanmono) font(sourcehanmonoel) font(sourcehanmonoh) font(sourcehanmonohc) font(sourcehanmonohcel) font(sourcehanmonohch) font(sourcehanmonohcl) font(sourcehanmonohcm) font(sourcehanmonohcn) font(sourcehanmonok) font(sourcehanmonokel) font(sourcehanmonokh) font(sourcehanmonokl) font(sourcehanmonokm) font(sourcehanmonokn) font(sourcehanmonol) font(sourcehanmonom) font(sourcehanmonon) font(sourcehanmonosc) font(sourcehanmonoscel) font(sourcehanmonosch) font(sourcehanmonoscl) font(sourcehanmonoscm) font(sourcehanmonoscn) font(sourcehanmonotc) font(sourcehanmonotcel) font(sourcehanmonotch) font(sourcehanmonotcl) font(sourcehanmonotcm) font(sourcehanmonotcn) font(思源等宽) font(思源等宽el) font(思源等宽h) font(思源等宽l) font(思源等宽m) font(思源等宽n) font(思源等寬) font(思源等寬el) font(思源等寬h) font(思源等寬l) font(思源等寬m) font(思源等寬n) font(思源等寬香港) font(思源等寬香港el) font(思源等寬香港h) font(思源等寬香港l) font(思源等寬香港m) font(思源等寬香港n) font(源ノ等幅) font(源ノ等幅el) font(源ノ等幅h) font(源ノ等幅l) font(源ノ等幅m) font(源ノ等幅n) font(본모노) font(본모노el) font(본모노h) font(본모노l) font(본모노m) font(본모노n) Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -b 1715379 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, fonts Disabled plugins: R, Python, PHP, Haskell, Perl, SugarActivity, Java, C/C++, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1715379 --- Comment #3 from Akira TAGOH <tagoh(a)redhat.com&gt; --- Updated again: Spec URL: https://tagoh.fedorapeople.org/reviews/adobe-source-han-mono-fonts/adobe-... SRPM URL: https://tagoh.fedorapeople.org/reviews/adobe-source-han-mono-fonts/adobe-... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1715379 --- Comment #5 from Akira TAGOH <tagoh(a)redhat.com&gt; --- Updated again: Spec URL: https://tagoh.fedorapeople.org/reviews/adobe-source-han-mono-fonts/adobe-... SRPM URL: https://tagoh.fedorapeople.org/reviews/adobe-source-han-mono-fonts/adobe-... https://koji.fedoraproject.org/koji/taskinfo?taskID=35288866 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1715379 --- Comment #7 from Parag AN(पराग) <panemade(a)gmail.com&gt; --- Thanks for the updates. The above update fixed all the remaining issues. RE-APPROVED :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1715379 --- Comment #8 from Akira TAGOH <tagoh(a)redhat.com&gt; --- Thank you for reviewing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component