Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ruby-flexmock - Mock object library for ruby https://bugzilla.redhat.com/show_bug.cgi?id=369501 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2007-11-07 06:48 EST ------- For 0.7.1-1: * Virtual provides of ruby modules - unversioned-explicit-provides - At least this should have Provides: ruby(LIBRARY) = VERSION, not only ruby(LIBRARY) (ref: http://fedoraproject.org/wiki/Packaging/Ruby ) * Source0 URL - Please specify full URL of Source0. * CFLAGS - Why does CFLAGS in %build section needed? This is noarch and actually this does not seem to do anything. * Many non-executable-script complaints - Usually the permissions 0644 are correct, these scripts should not have shebangs. * spurious-executable-perm /usr/share/doc/ruby-flexmock-0.7.1/GoogleExample.rdoc - Perhaps the permisson of this file should be 0644. * License - IMO this is "Copyright only", according to http://fedoraproject.org/wiki/Licensing -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ruby-flexmock - Mock object library for ruby https://bugzilla.redhat.com/show_bug.cgi?id=369501 mtasaka(a)ioa.s.u-tokyo.ac.jp changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2007-11-08 08:44 EST ------- For 0.7.1-2: * repoid - I checked the URL and repoid for 0.7.1 tarball seems 25773, not 25733 (perhaps you know, however just I note that this number changes every time new version is released). Please fix the issue above when you commit into CVS. ------------------------------------------------------------ This package (ruby-flexmock) is APPROVED by me ------------------------------------------------------------ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ruby-flexmock - Mock object library for ruby https://bugzilla.redhat.com/show_bug.cgi?id=369501 kevin(a)tummy.com changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+ ------- Additional Comments From kevin(a)tummy.com 2007-11-10 15:38 EST ------- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ruby-flexmock - Mock object library for ruby https://bugzilla.redhat.com/show_bug.cgi?id=369501 pauln(a)truemesh.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE ------- Additional Comments From pauln(a)truemesh.com 2007-11-12 03:55 EST ------- I've built on devel, F-8, F-7 and requested on bodhi for F-8 and F-7. Thanks for your review review, closing the bug out. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.