Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
Summary: Review Request: php-pear-Mail Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: Fedora@FamilleCollet.com QAContact: fedora-package-review@redhat.com
Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-Mail.spec SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pear-Mail-1.1.10-1.fc5.src.rpm Description: PEAR's Mail package defines an interface for implementing mailers under the PEAR hierarchy. It also provides supporting functions useful to multiple mailer backends. Currently supported backends include: PHP's native mail() function, sendmail, and SMTP. This package also provides a RFC822 email address list validation utility class.
------ One important thing is that this extension (as HTML, Net_SMTP, Net_Socket and XML_Parser) was included until php-5.0.4 in FC4. So it's needed for backward compatibility of Fedora Core >= 5.
I'll will wait for feddback for this extension but spec for the others are ready.
Remi.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
andreas@bawue.net changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bugzilla-sink@leemhuis.info |andreas@bawue.net
------- Additional Comments From andreas@bawue.net 2006-04-27 19:42 EST ------- (In reply to comment #0)
One important thing is that this extension (as HTML, Net_SMTP, Net_Socket and
XML_Parser) was included until php-5.0.4 in FC4. So it's needed for backward compatibility of Fedora Core >= 5.
Are you certain about this? The php Package in core does include the mail() function, but AFAIK it never included pear-mail.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
------- Additional Comments From Fedora@FamilleCollet.com 2006-04-28 04:11 EST ------- Yes, i'm quite sure.
# rpm -qlp php-5.0.4-10.5.src.rpm | grep gz$ DB-1.7.6.tgz HTTP-1.3.5.tgz Mail-1.1.4.tgz Net_SMTP-1.2.6.tgz Net_Socket-1.0.6.tgz XML_Parser-1.2.6.tgz XML_RPC-1.4.0.tgz php-5.0.4.tar.gz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
Fedora@FamilleCollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NOTABUG OtherBugsDependingO| |177841 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
Fedora@FamilleCollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |NEW Keywords| |Reopened Resolution|NOTABUG |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
gauret@free.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|andreas@bawue.net |gauret@free.fr CC| |andreas@bawue.net OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From gauret@free.fr 2006-04-28 07:16 EST ------- Needs work: * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * The package cannot be noarch since it installs files to %{_libdir} (which is /usr/lib64 on x86_64) * Build section is useless, you can safely remove it * The test dir for PEAR packages is called "test", not "tests" (in /usr/share/pear/) * Build failed in mock with this message: install ok: channel://pear.php.net/Mail-1.1.10 PHP Fatal error: Call to a member function setConfig() on a non-object in /usr/share/pear/PEAR/Command/Install.php on line 546 error: Bad exit status from /var/tmp/rpm-tmp.10675 (%install)
I propose to install the files without the pear tool, by just copying them. It should make it much easier to debug. Incoming patch...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
------- Additional Comments From gauret@free.fr 2006-04-28 07:18 EST ------- Created an attachment (id=128357) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=128357&action=vie...) New install system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
------- Additional Comments From Fedora@FamilleCollet.com 2006-04-28 17:49 EST ------- I'm quite confused by the %{_libdir} problem because I follow Joe Orton & Tim Jackson work on Bug #176733 (for php-pear-DB).
For the install problem, i only have to substitue the --packagingroot option (which work with pear >= 1.4.8) by -R (for pear = 1.4.6)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
------- Additional Comments From gauret@free.fr 2006-04-28 18:27 EST -------
I'm quite confused by the %{_libdir} problem because I follow Joe Orton & Tim Jackson work on Bug #176733 (for php-pear-DB).
Well, %_libdir is different on AMD64 and on x86 & PPC. If you build your package as noarch, only one package will be build for all archs. Say the package was built on an AMD64 host: il will install the xml file in /usr/lib64/php/pear. If this package is installed on an x86 machine, the lib64 path will not be searched and the file will not be found.
For the install problem, i only have to substitue the --packagingroot option (which work with pear >= 1.4.8) by -R (for pear = 1.4.6)
Do as you want, you'll be maintaining it in the end. But just copying the files looked like the KISS way to me.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
------- Additional Comments From Fedora@FamilleCollet.com 2006-04-29 06:17 EST ------- I've opened Bug #190252 against PHP whch own %{_libdir]/php/pear about this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
Fedora@FamilleCollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |190252 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
rpm@timj.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |190252 OtherBugsDependingO|190252 | nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
------- Additional Comments From Fedora@FamilleCollet.com 2006-05-06 13:34 EST ------- New spec and SRPM using %{_datadir}/pear/.pkgxml
Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-Mail.spec SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pear-Mail-1.1.10-2.fc5.src.rpm
Build succed with mock.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
------- Additional Comments From gauret@free.fr 2006-05-08 07:11 EST ------- The PHP package uses "The PHP License" in the License tag, please do the same (avoids one rpmlint error)
Detail: in %install there is a php error message (it's just a notice, but there might be a real problem beneath): Notice: Undefined variable: php_dir in PEAR/Installer.php on line 1160 and 1161
Otherwise, it looks good to me. We'll have to wait until bug 190252 is fixed to publish it of course.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
------- Additional Comments From Fedora@FamilleCollet.com 2006-05-08 13:29 EST ------- I've change to "PHP License" which is listed in the DEFAULT_VALID_LICENSES (/usr/share/rpmlint/TagsCheck.py), but rpmlint still complain (i've tried a lot of others solutions, i really don't understand, rpmlint seems to use another list not including PHP License)?
Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-Mail.spec SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pear-Mail-1.1.10-3.fc5.src.rpm
Bug #183359 brings php-1.4.9 in Rawhide and solve the %install warning (really great) and the "%postun" error on some other package (php-pear-Log and php-pear-Net-SMTP).
php-1.4.9 own the %{_datadir}/pear/.pkgxml
So i think(hope) this package is ready for extras. As some others : #190007, #190101, #190156, #190956, #190957, #190958
I keep using -R (instead of --packagingroot) to have compatibility with php-pear-1.4.6. For packages where --packagingroot is mandatory (php-pear-PEAR-Command-Packaging, #185423) a BuildRequires: php-pear(PEAR) > 1.4.7 have to be add to the spec. (the "Sanity check" i put in the spec detect that case).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
------- Additional Comments From gauret@free.fr 2006-05-08 14:38 EST -------
I've change to "PHP License" which is listed in the DEFAULT_VALID_LICENSES (/usr/share/rpmlint/TagsCheck.py), but rpmlint still complain
This file is overriden by /usr/share/rpmlint/config which lacks the PHP License. I've opened a bug to add it, see bug 191078. This is not a blocker of course.
I'm waiting for the php package update to be published to test and approve this package, since it is dependant on it. Afterwards, I'll sponsor you.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
------- Additional Comments From Fedora@FamilleCollet.com 2006-05-10 12:53 EST ------- Bug #190252 has been affected to php-pear (instead of php)
php-pear-1.4.9 is available in rawhide and in FC5 testing.
Extract from mock/build.log ============================================================================= Installing: php-pear noarch 1:1.4.9-2 core 357 k
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
------- Additional Comments From gauret@free.fr 2006-05-14 12:22 EST ------- If you need php-pear >= 1:1.4.9 (for the .pkgxml dir), you need to reflect that in the Requires tag. Everything else looks OK.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
------- Additional Comments From Fedora@FamilleCollet.com 2006-05-15 14:02 EST ------- Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-Mail.spec SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pear-Mail-1.1.10-4.fc5.src.rpm Mock root.log : http://remi.collet.free.fr/rpms/extras/php-pear-Mail-root.log Mock build.log : http://remi.collet.free.fr/rpms/extras/php-pear-Mail-build.log
- Require php-pear(PEAR) >= 1.4.9 (no epoch on classname, only on package) - Requires(hint): php-pear(Net_SMTP) >= 1.1.0 (only comment actually) - bundle the v3.01 PHP LICENSE file (as php-pear package) - use --packagingroot (instead of -R, as it work with php-pear 1.4.9) - %check (move sanity check from %install to %check, as in php-pear)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
Bug 190066 depends on bug 190252, which changed state.
Bug 190252 Summary: /usr/lib/php/pear used for "noarch" pear RPM. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190252
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |ERRATA Status|MODIFIED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
gauret@free.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From gauret@free.fr 2006-05-19 17:16 EST ------- Review for release 4: * RPM name is OK * Source Mail-1.1.10.tgz is the same as upstream * rpmlint looks OK * File list looks OK * Works fine APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
Fedora@FamilleCollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|177841 | nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium
Fedora@FamilleCollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From Fedora@FamilleCollet.com 2007-03-31 04:25 EST ------- Package Change Request ====================== Package Name: php-pear-Mail New Branches: EL-5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190066
petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From petersen@redhat.com 2007-04-02 08:39 EST ------- done
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Mail
https://bugzilla.redhat.com/show_bug.cgi?id=190066
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org