https://bugzilla.redhat.com/show_bug.cgi?id=1431855 Julien Enselme <jujens(a)jujens.eu&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jujens(a)jujens.eu Assignee|nobody(a)fedoraproject.org |jujens(a)jujens.eu Flags| |fedora-review? --- Comment #1 from Julien Enselme <jujens(a)jujens.eu&gt; --- - I would rename python-devel into python2-devel - `Requires: python3` is not needed - From the setup.py, you need to require python2-chardet and python3-chardet - You must include the license file now - I reocommand that you to be more precise in your %files section: `%{python3_sitelib}/*` -> `%{python3_sitelib}/debrepo/` and `%{python3_sitelib}/debrepo-%{version}-py%{python3_verison}.egg-info/` - I believe RPM lints errors are false positive due to this change: https://fedoraproject.org/wiki/Changes/python3_c.utf-8_locale Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated". 9 files have unknown license. Detailed output of licensecheck in /tmp/1431855 -python-debrepo/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [X]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [X]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [X]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-debrepo , python3-debrepo [?]: Package functions as described. [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [X]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define srcname debrepo [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-debrepo-0.0.1-1.fc27.noarch.rpm python3-debrepo-0.0.1-1.fc27.noarch.rpm python-debrepo-0.0.1-1.fc27.src.rpm python2-debrepo.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically python2-debrepo.noarch: W: spelling-error %description -l en_US debrepodiff python3-debrepo.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically python3-debrepo.noarch: W: no-manual-page-for-binary debrepodiff python-debrepo.src: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically python-debrepo.src: W: spelling-error %description -l en_US debrepodiff python-debrepo.src: E: specfile-error Python runtime initialized with LC_CTYPE=C (a locale with default ASCII encoding), which may cause Unicode compatibility problems. Using C.UTF-8, C.utf8, or UTF-8 (if available) as alternative Unicode-compatible locales is recommended. 3 packages and 0 specfiles checked; 1 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- python3-debrepo.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically python3-debrepo.noarch: W: no-manual-page-for-binary debrepodiff python2-debrepo.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically python2-debrepo.noarch: W: spelling-error %description -l en_US debrepodiff 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Requires -------- python3-debrepo (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3 python3-debian python2-debrepo (rpmlib, GLIBC filtered): python(abi) python-debian Provides -------- python3-debrepo: python3-debrepo python3.6dist(debrepo) python3dist(debrepo) python2-debrepo: python-debrepo python2-debrepo python2.7dist(debrepo) python2dist(debrepo) Source checksums ---------------- https://files.pythonhosted.org/packages/source/d/debrepo/debrepo-0.0.1.ta... : CHECKSUM(SHA256) this package : 7edb23ba8d5c0f7d20f431fa91d681a6d4d14c5f58f847c2676d85c014793bbf CHECKSUM(SHA256) upstream package : 7edb23ba8d5c0f7d20f431fa91d681a6d4d14c5f58f847c2676d85c014793bbf Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1431855 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1431855 --- Comment #3 from Julien Enselme <jujens(a)jujens.eu&gt; --- - BuildRequires: python2-devel is present twice. - I didn't catch it during initial review: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define srcname debrepo Can you use %global or justify the %define? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1431855 Julien Enselme <jujens(a)jujens.eu&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #5 from Julien Enselme <jujens(a)jujens.eu&gt; --- You could rename python-setuptools to python2-setuptools but that's a detail. Package looks good. Approved! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1431855 --- Comment #7 from Gwyn Ciesla <limburgher(a)gmail.com&gt; --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-debrepo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component