Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lsvpd - A utility to list device Vital Product Data (VPD) information. https://bugzilla.redhat.com/show_bug.cgi?id=307901 ebmunson(a)us.ibm.com changed: What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |307891 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lsvpd - A utility to list device Vital Product Data (VPD) information. https://bugzilla.redhat.com/show_bug.cgi?id=307901 ------- Additional Comments From wolfy(a)nobugconsulting.ro 2007-11-15 16:44 EST ------- I am not a sponsor, so I cannot do an official review. However, I will try to push this a bit. Comments about your spec: - rpm is not meant to be used as a shell, therefore the first line of the spec (#! /usr/bin/rpm) should not be there - the preferred way to reference files hosted at sourceforge is described at http://fedoraproject.org/wiki/Packaging/SourceURL?highlight=%20downloads.... (For packages hosted on sourceforge, use Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz) In your case, the source is called %{name}-%{version}.src.tar.gz so adapt as needed. rpmlint has several complains: lsvpd.src: W: mixed-use-of-spaces-and-tabs (spaces: line 17, tab: line 5) -> easy one, cosmetic fix lsvpd.src: W: non-standard-group System Environment -> try to pick a better group description lsvpd.src: E: no-changelogname-tag -> add ad least one proper entry to %changelog lsvpd.src: W: invalid-license GPL -> license should probably be GPLv2 or even GPLv2+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lsvpd - A utility to list device Vital Product Data (VPD) information. https://bugzilla.redhat.com/show_bug.cgi?id=307901 ------- Additional Comments From wolfy(a)nobugconsulting.ro 2007-11-17 08:07 EST ------- The shape is much better now. The only suggestion I have is to ditch the INSTALL file from %doc because it brings no value to Fedora users. Just keep this in mind and implement whenever you happen to modify the spec, it's not at all critical. Make sure it occurs before the commit phase, once a sponsor approves the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lsvpd - A utility to list device Vital Product Data (VPD) information. https://bugzilla.redhat.com/show_bug.cgi?id=307901 bugzilla(a)redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide ------- Additional Comments From ebmunson(a)us.ibm.com 2007-12-17 19:10 EST ------- I have fixed your requests and they will go out at the next release. Calls to insserv and chkconfig have been removed On my build system, libvpd_cxx was not being added to the Requires section by the build process but it is required (and not provided by this package). So I added it by hand. It is provided by the libvpd package from bug #307891 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lsvpd - A utility to list device Vital Product Data (VPD) information. https://bugzilla.redhat.com/show_bug.cgi?id=307901 Bug 307901 depends on bug 307891, which changed state. Bug 307891 Summary: Review Request: libvpd - C++ library for system vpd access https://bugzilla.redhat.com/show_bug.cgi?id=307891 What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lsvpd - A utility to list device Vital Product Data (VPD) information. https://bugzilla.redhat.com/show_bug.cgi?id=307901 tibbs(a)math.uh.edu changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|177841 | nThis| | ------- Additional Comments From tibbs(a)math.uh.edu 2008-01-25 13:39 EST ------- Sponsorship is for the person, not the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lsvpd - A utility to list device Vital Product Data (VPD) information. https://bugzilla.redhat.com/show_bug.cgi?id=307901 dennis(a)ausil.us changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs- ------- Additional Comments From dennis(a)ausil.us 2008-01-26 08:54 EST ------- Package has not been approved. please re-request cvs when its approved -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lsvpd - A utility to list device Vital Product Data (VPD) information. https://bugzilla.redhat.com/show_bug.cgi?id=307901 ------- Additional Comments From ebmunson(a)us.ibm.com 2008-01-26 17:09 EST ------- Sorry, my mistake. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lsvpd - A utility to list device Vital Product Data (VPD) information. https://bugzilla.redhat.com/show_bug.cgi?id=307901 mtasaka(a)ioa.s.u-tokyo.ac.jp changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka(a)ioa.s.u-tokyo.ac.jp ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2008-01-27 10:03 EST ------- I just tried to rebuild this on koji but it failed. http://koji.fedoraproject.org/koji/taskinfo?taskID=375989 Note: As you are now cvs-extras member, you can try to rebuild a arbitrary srpm on koji by: $ koji build --scratch <target> <srpm_you_want_to_try> Currently target can be either: dist-f9, dist-f8-updates-candidate, dist-fc7-updates-candidate (and some special targets). If the scratch build is successful, the rebuilt rpms and some logs are put under: http://koji.fedoraproject.org/scratch/<your_FAS_name>/task_<task... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lsvpd - A utility to list device Vital Product Data (VPD) information. https://bugzilla.redhat.com/show_bug.cgi?id=307901 ------- Additional Comments From ebmunson(a)us.ibm.com 2008-03-12 12:20 EST ------- I am trying to start a scratch build on a new srpm. The build fails, but I never get any logs in my email or online. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lsvpd - A utility to list device Vital Product Data (VPD) information. https://bugzilla.redhat.com/show_bug.cgi?id=307901 ------- Additional Comments From ebmunson(a)us.ibm.com 2008-03-12 16:07 EST ------- Sorry for the spam, but in the ppc and ppc64 builds there is optional behavior if librtas (a IBM P-series library for reading system config and vpd) is present. How can I articulate that in the spec file? I would like lsvpd to use librtas if it is available. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lsvpd - A utility to list device Vital Product Data (VPD) information. https://bugzilla.redhat.com/show_bug.cgi?id=307901 ------- Additional Comments From ebmunson(a)us.ibm.com 2008-03-13 19:06 EST ------- I added the dependency, but I don't think that the library is in Fedora Core so I am working with the library maintainers on a spec file and will post it here (and update the dependency list for this bug) when it gets into bugzilla. Meanwhile, here is the new lsvpd, nothing has changed for x86 or x86_64. SPEC: http://downloads.sourceforge.net/linux-diag/lsvpd.spec SRPM: http://downloads.sourceforge.net/linux-diag/lsvpd-1.6.2-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lsvpd - A utility to list device Vital Product Data (VPD) information. https://bugzilla.redhat.com/show_bug.cgi?id=307901 ------- Additional Comments From ebmunson(a)us.ibm.com 2008-03-14 14:27 EST ------- I have added the conditional in front of the Build dep using your first suggestion. I have tested the build on koji and ppc/ppc64 succeeded. Here are the new files: SPEC: http://downloads.sourceforge.net/linux-diag/lsvpd.spec SRPM: http://downloads.sourceforge.net/linux-diag/lsvpd-1.6.2-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lsvpd - A utility to list device Vital Product Data (VPD) information. https://bugzilla.redhat.com/show_bug.cgi?id=307901 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2008-03-15 01:25 EST ------- I just tried koji scratch build for 1.6.2-3 and it was successful. http://koji.fedoraproject.org/koji/taskinfo?taskID=517551 (In reply to comment #24) "dist-rawhide" is not a valid target for koji build. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lsvpd - A utility to list device Vital Product Data (VPD) information. https://bugzilla.redhat.com/show_bug.cgi?id=307901 wolfy(a)nobugconsulting.ro changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? ------- Additional Comments From wolfy(a)nobugconsulting.ro 2008-03-19 10:13 EST ------- Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: devel/x86_64 [x] Rpmlint output: source RPM: empty binary RPM: lsvpd.x86_64: W: non-conffile-in-etc /etc/lsvpd/scsi_templates.conf -> you should mark as %config each of the config files lsvpd.x86_64: W: spurious-executable-perm /usr/share/doc/lsvpd-1.6.2/COPYING lsvpd.x86_64: W: spurious-executable-perm /usr/share/doc/lsvpd-1.6.2/TODO lsvpd.x86_64: W: spurious-executable-perm /usr/share/doc/lsvpd-1.6.2/INSTALL lsvpd.x86_64: W: spurious-executable-perm /usr/share/doc/lsvpd-1.6.2/README lsvpd.x86_64: W: spurious-executable-perm /usr/share/doc/lsvpd-1.6.2/NEWS -> either an %attr or a chmod -x would fix this lsvpd.x86_64: W: non-conffile-in-etc /etc/lsvpd/cpu_mod_conv.conf -> same as above lsvpd.x86_64: W: incoherent-version-in-changelog -1.6.2-3 1.6.2-3.fc9 -> ignorable lsvpd.x86_64: W: one-line-command-in-%post /usr/sbin/vpdupdate -> ignorable, although joining %post and the vpupdate line will make rpmlint happier [x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPLv2+ [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [!] Sources used to build the package matches the upstream source, as provided in the spec URL. SHA1SUM of package: 32596c0297884c42937380d06139c5ea2bf0e436 lsvpd-1.6.2.tar.gz (upstream) bdd61e818c2fbf71315168db95716393f2dc07e0 lsvpd-1.6.2.tar.gz.1 (included in the src.rpm) [x] Package is not known to require ExcludeArchd$ [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [-] Package requires other packages for directories it uses. [!] Package does not contain duplicates in %files. warning: File listed twice: /etc/lsvpd/cpu_mod_conv.conf warning: File listed twice: /etc/lsvpd/scsi_templates.conf -> Please either include the whole dir, or the files below it [!] Permissions on files are set properly. -> see above the issue with doc files [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: all archs supported by rawhide [x] Package should compile and build into binary rpms on all supported architectures. Tested on: all archs supported by rawhide [-] Package functions as described. I could not test, the package does not build in F-7/F-8 due to missing libvpd-devel. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. === Issues === 1. the bundled sources and the upstream ones do not coincide 2. some of the included files have unrecommended permissions 3. two files are included twice Please fix the above and we are good to go. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lsvpd - A utility to list device Vital Product Data (VPD) information. https://bugzilla.redhat.com/show_bug.cgi?id=307901 wolfy(a)nobugconsulting.ro changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From wolfy(a)nobugconsulting.ro 2008-03-24 15:04 EST ------- Your current spec misses ownership of /etc/lsvpd/. What you need over there is an additional %dir %{_sysconfdir}/lsvpd in the %files section. Otherwise, everything seems fine, sha1sum now matches upstream (73ea96d8a031572d25f99d437cbc0b97443fce9b lsvpd-1.6.3.tar.gz ) The package is APPROVED but please do nor forget to add the missing %dir before uploading to cvs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lsvpd - A utility to list device Vital Product Data (VPD) information. https://bugzilla.redhat.com/show_bug.cgi?id=307901 kevin(a)tummy.com changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+ ------- Additional Comments From kevin(a)tummy.com 2008-03-24 19:53 EST ------- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.