https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Michael Schwendt (Fedora Packager Sponsors Group) <bugs.micheal(a)gmx.net&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |python-UcsSdk - New package |python-UcsSdk - Python SDK | |for Cisco UCS Manager --- Comment #1 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.micheal(a)gmx.net&gt; --- Try pointing the fedora-review tool at this ticket: fedora-review -b 1242011 It evaluates the "Spec URL:" and "SRPM URL:" lines, downloads the latest files and packages, performs local test-builds and many checks related to the packaging guidelines. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1242011 --- Comment #3 from Brian Demers <brdemers(a)cisco.com&gt; --- Spec URL: https://raw.githubusercontent.com/CiscoSystems/UcsSdk-spec/master/python-... SRPM URL: https://github.com/CiscoSystems/UcsSdk-spec/releases/download/new-spec/py... Thanks Steve, I didn't think about needing the raw file URL -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Alan Pevec <apevec(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |apevec(a)redhat.com --- Comment #5 from Alan Pevec <apevec(a)redhat.com&gt; --- Anyone in packagers group can do the formal review, sponsorship is separate. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1242011 --- Comment #7 from Brian Demers <brdemers(a)cisco.com&gt; --- Informal reviews for other projects: 1243550, 1234664 Spec URL: https://raw.githubusercontent.com/CiscoSystems/UcsSdk-spec/d20dd9157aa9d2... SRPM URL: https://github.com/CiscoSystems/UcsSdk-spec/releases/download/new-spec-2/... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1242011 hguemar(a)redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brdemers(a)cisco.com, | |hguemar(a)redhat.com Flags| |needinfo?(brdemers(a)cisco.co | |m) --- Comment #9 from hguemar(a)redhat.com --- +1 I'd move the dos2unix one-liner in %setup too Is there a reason not to ship 0.8.3 ? it's the latest one and it provides license file? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Haïkel Guémar <karlthered(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) | Flags|fedora-review? |fedora-review+ --- Comment #11 from Haïkel Guémar <karlthered(a)gmail.com&gt; --- Thanks Brian, you did a great job hence I sponsored you into the packager group. Use your power for good, and never hesitate contacting me if you have any question or need help. As this package complies with Fedora packaging guidelines, I hereby approve it into Fedora packages collection. Please submit a SCM request as explained on the following wiki page. https://fedoraproject.org/wiki/Package_SCM_admin_requests#New_Packages Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)". Detailed output of licensecheck in /home/haikel/1242011-python-UcsSdk/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-UcsSdk-0.8.2.4-1.fc24.noarch.rpm python-UcsSdk-0.8.2.4-1.fc24.src.rpm python-UcsSdk.src: E: specfile-error warning: bogus date in %changelog: Wed Jul 30 2015 Brian Demers <brdemers(a)cisco.com&gt; 0.8.2.4-1 2 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- python-UcsSdk (rpmlib, GLIBC filtered): /usr/bin/python python(abi) Provides -------- python-UcsSdk: python-UcsSdk Source checksums ---------------- https://pypi.python.org/packages/source/U/UcsSdk/UcsSdk-0.8.2.4.tar.gz : CHECKSUM(SHA256) this package : 2819b71eaf019903c40f54561192c83caa0f77682312fc0ab107313f263fe688 CHECKSUM(SHA256) upstream package : 2819b71eaf019903c40f54561192c83caa0f77682312fc0ab107313f263fe688 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1242011 --- Comment #12 from Brian Demers <brdemers(a)cisco.com&gt; --- New Package SCM Request ======================= Package Name: python-UcsSdk Short Description: Python development kit for Cisco UCS Upstream URL: https://github.com/CiscoUcs/UcsPythonSDK Owners: bdemers Branches: f23 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Jon Ciesla <limburgher(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Ihar Hrachyshka <ihrachys(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(brdemers(a)cisco.co | |m) --- Comment #14 from Ihar Hrachyshka <ihrachys(a)redhat.com&gt; --- Was the initial package built for Fedora? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Alan Pevec <apevec(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(brdemers(a)cisco.co | |m) --- Comment #16 from Alan Pevec <apevec(a)gmail.com&gt; --- Brian, you need to run fedpkg update in each f23 and epel7 branches to push the update. Set type=newpackage and bugs=1242011 and Bodhi will update status in this BZ. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1242011 --- Comment #17 from Fedora Update System <updates(a)fedoraproject.org&gt; --- python-UcsSdk-0.8.2.4-1.fc23 has been submitted as an update for Fedora 23. https://admin.fedoraproject.org/updates/python-UcsSdk-0.8.2.4-1.fc23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA --- Comment #19 from Fedora Update System <updates(a)fedoraproject.org&gt; --- python-UcsSdk-0.8.2.4-1.el7 has been pushed to the Fedora EPEL 7 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1242011 --- Comment #21 from Fedora Update System <updates(a)fedoraproject.org&gt; --- python-UcsSdk-0.8.2.5-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update python-UcsSdk'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-7810 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Brian Demers <brdemers(a)cisco.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|python-UcsSdk-0.8.2.4-1.fc2 |python-UcsSdk-0.8.2.5-1.fc2 |4 |4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1242011 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version|python-UcsSdk-0.8.2.5-1.fc2 |0.8.2.5-1.fc23 |4 | Resolution|--- |NEXTRELEASE Last Closed| |2015-09-05 21:10:43 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component