[Bug 2158678] New: Review Request: libcamera-apps - A small suite of libcamera-based apps
https://bugzilla.redhat.com/show_bug.cgi?id=2158678
Bug ID: 2158678 Summary: Review Request: libcamera-apps - A small suite of libcamera-based apps Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: pbrobinson@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
SPEC: https://pbrobinson.fedorapeople.org/libcamera-apps.spec SRPM: https://pbrobinson.fedorapeople.org/libcamera-apps-1.0.2-1.fc37.src.rpm
Description: This is a small suite of libcamera-based apps that aim to copy the functionality of the existing "raspicam" apps.
FAS: pbrobinson
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=95790983
https://bugzilla.redhat.com/show_bug.cgi?id=2158678
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5203603 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/frostyx/fedora-review-215...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
https://bugzilla.redhat.com/show_bug.cgi?id=2158678
Petr Menšík pemensik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pemensik@redhat.com Doc Type|--- |If docs needed, set a value
--- Comment #2 from Petr Menšík pemensik@redhat.com --- This package contains a lot of lib*.so shared libraries used by executables, which lack soname versions [1]. They are required by packaging guidelines. Those libraries are used at link time as a normal library, not as plugins loaded runtime.
rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libcamera_app.so rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libencoders.so rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libimages.so rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/liboutputs.so rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libpost_processing_stages.so rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libpreview.so
Such format is usually provided by *-devel subpackages, but this package does not have such thing.
I think they are supposed to be internal for the program and they should be placed into %{_libdir}/%{name} with using rpath for this case [2]. It seems those libraries are not meant to be reused by any other tools directly, because no -devel headers allows linking to them. It seems those names do not conflicts with any existing packages now, but those names are not specialized enough. I think moving them to to application specific subdirectory is desireable to avoid future conflicts.
[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_na... [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_rpath_for_intern...
https://bugzilla.redhat.com/show_bug.cgi?id=2158678
--- Comment #3 from Peter Robinson pbrobinson@gmail.com --- (In reply to Petr Menšík from comment #2)
This package contains a lot of lib*.so shared libraries used by executables, which lack soname versions [1]. They are required by packaging guidelines. Those libraries are used at link time as a normal library, not as plugins loaded runtime.
In some cases if the .so is a plugin and not a library it's not always the cases, there are numerous examples of this.
rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libcamera_app. so rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libencoders.so rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libimages.so rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/liboutputs.so rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/ libpost_processing_stages.so rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libpreview.so
We already have a fix posted for upstream: https://github.com/raspberrypi/libcamera-apps/pull/441
https://bugzilla.redhat.com/show_bug.cgi?id=2158678
--- Comment #4 from Peter Robinson pbrobinson@gmail.com --- Updated: SPEC: https://pbrobinson.fedorapeople.org/libcamera-apps.spec SRPM: https://pbrobinson.fedorapeople.org/libcamera-apps-1.1.0-1.fc37.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2158678
--- Comment #5 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5252674 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
https://bugzilla.redhat.com/show_bug.cgi?id=2158678
--- Comment #6 from Peter Robinson pbrobinson@gmail.com --- SPEC: https://pbrobinson.fedorapeople.org/libcamera-apps.spec SRPM: https://pbrobinson.fedorapeople.org/libcamera-apps-1.1.1-1.fc37.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=96948309
https://bugzilla.redhat.com/show_bug.cgi?id=2158678
Javier Martinez Canillas fmartine@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fmartine@redhat.com
--- Comment #7 from Javier Martinez Canillas fmartine@redhat.com --- All looks good to me now!
https://bugzilla.redhat.com/show_bug.cgi?id=2158678
Javier Martinez Canillas fmartine@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |fmartine@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=2158678
Javier Martinez Canillas fmartine@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=2158678
Javier Martinez Canillas fmartine@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=2158678
--- Comment #8 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/libcamera-apps
https://bugzilla.redhat.com/show_bug.cgi?id=2158678
--- Comment #9 from Jakub Kadlčík jkadlcik@redhat.com --- Created attachment 1941486 --> https://bugzilla.redhat.com/attachment.cgi?id=1941486&action=edit The .spec file difference from Copr build 5252674 to 5385625
https://bugzilla.redhat.com/show_bug.cgi?id=2158678
--- Comment #10 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5385625 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
https://bugzilla.redhat.com/show_bug.cgi?id=2158678
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2023-02-01 09:28:33
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com