https://bugzilla.redhat.com/show_bug.cgi?id=1853644
Bug ID: 1853644 Summary: Review Request: perl-ColorThemeBase-Static - Base class for color theme modules with static list of items Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jplesnik@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://jplesnik.fedorapeople.org/perl-ColorThemeBase-Static/perl-ColorTheme... SRPM URL: https://jplesnik.fedorapeople.org/perl-ColorThemeBase-Static/perl-ColorTheme...
Description: This is base class for color theme modules with static list of items (from object's colors key). This class is now alias for ColorThemeBase::Static::FromStructColors. You can use that class directly.
Fedora Account System Username: jplesnik@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1853644
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1853571 Depends On| |1853629
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1853571 [Bug 1853571] perl-JSON-Color-0.130 is available https://bugzilla.redhat.com/show_bug.cgi?id=1853629 [Bug 1853629] Review Request: perl-Color-RGB-Util - Utilities related to RGB colors
https://bugzilla.redhat.com/show_bug.cgi?id=1853644
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- URL and Source addresses are Ok. Source archive (SHA-256: b9c473290bf4915847b264030e68e06e8ed100f98e80f8bf9619b1b1a6bafb31) is original. Ok. Summary verified from lib/ColorThemeBase/Base.pm. Ok. Description verified. Ok. License verified from README and lib/ColorThemeBase/Base.pm. Ok. No XS code, noarch BuildArch is Ok.
Pod::Coverage::TrustPod, Test::Pod::Coverage, Test::Perl::Critic, and Test::Pod are not used. Ok. AUTHOR_TESTING variable is unset before executing "make test". Ok.
$ rpmlint perl-ColorThemeBase-Static.spec review-perl-ColorThemeBase-Static/results/perl-ColorThemeBase-Static-0.008-1.fc33.noarch.rpm
review-perl-ColorThemeBase-Static/results/perl-ColorThemeBase-Static-0.008-1.fc33.src.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpm -q -lv -p review-perl-ColorThemeBase-Static/results/perl-ColorThemeBase-Static-0.008-1.fc33.noarch.rpm 12:47:44 drwxr-xr-x 2 root root 0 Jul 4 12:45 /usr/share/doc/perl-ColorThemeBase-Static -rw-r--r-- 1 root root 1229 Jun 19 17:57 /usr/share/doc/perl-ColorThemeBase-Static/Changes -rw-r--r-- 1 root root 1255 Jun 19 17:57 /usr/share/doc/perl-ColorThemeBase-Static/README drwxr-xr-x 2 root root 0 Jul 4 12:45 /usr/share/licenses/perl-ColorThemeBase-Static -rw-r--r-- 1 root root 18367 Jun 19 17:57 /usr/share/licenses/perl-ColorThemeBase-Static/LICENSE -rw-r--r-- 1 root root 1612 Jul 4 12:45 /usr/share/man/man3/ColorTheme::Test::Dynamic.3pm.gz -rw-r--r-- 1 root root 1608 Jul 4 12:45 /usr/share/man/man3/ColorTheme::Test::Static.3pm.gz -rw-r--r-- 1 root root 1638 Jul 4 12:45 /usr/share/man/man3/ColorThemeBase::Base.3pm.gz -rw-r--r-- 1 root root 1625 Jul 4 12:45 /usr/share/man/man3/ColorThemeBase::Constructor.3pm.gz -rw-r--r-- 1 root root 1713 Jul 4 12:45 /usr/share/man/man3/ColorThemeBase::Static.3pm.gz -rw-r--r-- 1 root root 1850 Jul 4 12:45 /usr/share/man/man3/ColorThemeBase::Static::FromObjectColors.3pm.gz -rw-r--r-- 1 root root 1790 Jul 4 12:45 /usr/share/man/man3/ColorThemeBase::Static::FromStructColors.3pm.gz drwxr-xr-x 2 root root 0 Jul 4 12:45 /usr/share/perl5/vendor_perl/ColorTheme drwxr-xr-x 2 root root 0 Jul 4 12:45 /usr/share/perl5/vendor_perl/ColorTheme/Test -rw-r--r-- 1 root root 2197 Jun 19 17:57 /usr/share/perl5/vendor_perl/ColorTheme/Test/Dynamic.pm -rw-r--r-- 1 root root 1783 Jun 19 17:57 /usr/share/perl5/vendor_perl/ColorTheme/Test/Static.pm drwxr-xr-x 2 root root 0 Jul 4 12:45 /usr/share/perl5/vendor_perl/ColorThemeBase -rw-r--r-- 1 root root 1701 Jun 19 17:57 /usr/share/perl5/vendor_perl/ColorThemeBase/Base.pm -rw-r--r-- 1 root root 2567 Jun 19 17:57 /usr/share/perl5/vendor_perl/ColorThemeBase/Constructor.pm drwxr-xr-x 2 root root 0 Jul 4 12:45 /usr/share/perl5/vendor_perl/ColorThemeBase/Static -rw-r--r-- 1 root root 1671 Jun 19 17:57 /usr/share/perl5/vendor_perl/ColorThemeBase/Static.pm -rw-r--r-- 1 root root 2547 Jun 19 17:57 /usr/share/perl5/vendor_perl/ColorThemeBase/Static/FromObjectColors.pm -rw-r--r-- 1 root root 2496 Jun 19 17:57 /usr/share/perl5/vendor_perl/ColorThemeBase/Static/FromStructColors.pm File layout ans permissions are Ok.
$ rpm -q --requires -p review-perl-ColorThemeBase-Static/results/perl-ColorThemeBase-Static-0.008-1.fc33.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.32.0) 1 perl(Color::RGB::Util) >= 0.600 1 perl(ColorThemeBase::Base) 1 perl(ColorThemeBase::Constructor) 1 perl(ColorThemeBase::Static::FromStructColors) 1 perl(Exporter) >= 5.57 1 perl(parent) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1
I can't find the need for perl(Exporter) anywhere in the code, are you sure it is needed?
$ rpm -q --provides -p review-perl-ColorThemeBase-Static/results/perl-ColorThemeBase-Static-0.008-1.fc33.noarch.rpm | sort -f | uniq -c 1 perl(ColorTheme::Test::Dynamic) = 0.008 1 perl(ColorTheme::Test::Static) = 0.008 1 perl(ColorThemeBase::Base) = 0.008 1 perl(ColorThemeBase::Constructor) = 0.008 1 perl(ColorThemeBase::Static) = 0.008 1 perl(ColorThemeBase::Static::FromObjectColors) = 0.008 1 perl(ColorThemeBase::Static::FromStructColors) = 0.008 1 perl-ColorThemeBase-Static = 0.008-1.fc33 Binary provides are Ok.
The package builds in Fedora 33 (Mock). Ok.
The package is in line with Fedora and Perl packagaging guidelines.
Resolution: Package approved. Please check if perl(Exporter) >= 5.57 is really needed by the package.
https://bugzilla.redhat.com/show_bug.cgi?id=1853644
--- Comment #2 from Jitka Plesnikova jplesnik@redhat.com --- You are right, I'll remove perl(Exporter)
https://pagure.io/releng/fedora-scm-requests/issue/26873
https://bugzilla.redhat.com/show_bug.cgi?id=1853644
--- Comment #3 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-ColorThemeBase-Static
https://bugzilla.redhat.com/show_bug.cgi?id=1853644 Bug 1853644 depends on bug 1853629, which changed state.
Bug 1853629 Summary: Review Request: perl-Color-RGB-Util - Utilities related to RGB colors https://bugzilla.redhat.com/show_bug.cgi?id=1853629
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1853644
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Fixed In Version| |perl-ColorThemeBase-Static- | |0.008-1.fc33 Resolution|--- |RAWHIDE Last Closed| |2020-07-07 17:05:11
package-review@lists.fedoraproject.org