https://bugzilla.redhat.com/show_bug.cgi?id=1872427 Artur Iwicki <fedora(a)svgames.pl&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora(a)svgames.pl --- Comment #1 from Artur Iwicki <fedora(a)svgames.pl&gt; --- Not used in Fedora. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sect... Fedora uses the "ASL 2.0" short name for this licence. https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses Ideally, this should be a downloadable URL. In case that's not possible, a comment explaining how the tarball was created is highly recommended, for the sake of reproducibility. https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ Python2 is considered deprecated, to bring any new software depending on Python2 into Fedora you'll need an exception from the Engineering Steering Committee. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_python... Why not just specify %{buildroot} as the --root, instead of installing to $RPM_BUILD_ROOT and then manually copying files? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 --- Comment #3 from Mohamed Aboubakr <mabouba(a)amazon.com&gt; --- Created attachment 1715005 --> https://bugzilla.redhat.com/attachment.cgi?id=1715005&action=edit Spec file that include changes for Fedora and Redhat. I resolved the comments that were given in previous RPM. Also I added extra changes to support REDHAT and Fedora because the previous spec file was supporting Amazon-linux only. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 David Duncan <davdunc(a)amazon.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(davdunc(a)amazon.co | |m) --- Comment #5 from David Duncan <davdunc(a)amazon.com&gt; --- (In reply to Carl George 🤠 from comment #4) I am still working on this Carl. Mohamed is working on the upstream integration and getting us through the internal Amazon reviews for the code. As you can imagine, he is eager to get this working to meet his team goals so he is submitting changes ahead of my validations. Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Product: Fedora Version: rawhide Component: Package Review David Duncan <davdunc(a)amazon.com&gt; has asked Package Review <package-review(a)lists.fedoraproject.org&gt; for needinfo: Bug 1872427: Review Request: ec2-hibinit-agent - support for hibernation for Amazon ec2 https://bugzilla.redhat.com/show_bug.cgi?id=1872427 --- Comment #6 from David Duncan <davdunc(a)amazon.com&gt; --- Updated Spec URL: https://davdunc.fedorapeople.org/ec2-hibinit-agent.spec SRPM URL: https://davdunc.fedorapeople.org/ec2-hibinit-agent-1.0.3-2.fc33.src.rpm Updated with a comment for the source0. Waiting on final approval for the source uri to be valid.

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 --- Comment #8 from Robert-André Mauchin 🐧 <zebob.m(a)gmail.com&gt; --- As this is a Python package, you may simply specify BuildArch: noarch since it is not an arched package. No need for the debuginfo then. I find it weird that you provides egg-info without providing the library supposedly installed in %{python3_sitelib}/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 leigh scott <leigh123linux(a)googlemail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(package-review@li | |sts.fedoraproject.org) | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 Neal Gompa <ngompa13(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13(a)gmail.com Assignee|nobody(a)fedoraproject.org |ngompa13(a)gmail.com Flags|needinfo?(nobody@fedoraproj |fedora-review? |ect.org) | --- Comment #11 from Neal Gompa <ngompa13(a)gmail.com&gt; --- I will take this formal review, since nobody has so far. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 --- Comment #13 from Neal Gompa <ngompa13(a)gmail.com&gt; --- Actually, to more concretely word this correctly: Do not use upstream release versions in the "Release:" tag. Please decouple them so things like mass rebuilds don't break. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 David Duncan <davdunc(a)amazon.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(davdunc(a)amazon.co | |m) --- Comment #15 from David Duncan <davdunc(a)amazon.com&gt; --- Hi Neal, Did not realize that was going on there. Will fix. Ack. Will modify to ensure that we are not putting that at risk. Ack, will add that in. That's important, thanks. got it. Thanks. This enables workloads that don't include the following patch: https://lore.kernel.org/linux-mm/20200820045323.7809-1-hsiangkao@redhat.com/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 David Duncan <davdunc(a)amazon.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(davdunc(a)amazon.co | |m) | --- Comment #17 from David Duncan <davdunc(a)amazon.com&gt; --- (In reply to Neal Gompa from comment #16) @nea I worked on this with Mohamed and I think we have a better submission this time, but looking forward to the next review. This was a super helpful review and I think this is more inline with the expectations. [...] Mohamed is pushing the update to the github repo for setup.py so that the cfg file lands somewhere sane, not ```/usr/config``` [...] A spec file is up for review with the release changes and in anticipation of modify in setup.py to move back to /etc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 --- Comment #19 from Neal Gompa <ngompa13(a)gmail.com&gt; --- This is effectively no longer needed, so you can replace all usage of "%{gittag}" with "%{version}". This needs to be marked as "%config(noreplace)" "%{_localstatedir}/lib" should be replaced with "%{_sharedstatedir}" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 Neal Gompa <ngompa13(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ngompa13(a)gmail.co | |m) | --- Comment #21 from Neal Gompa <ngompa13(a)gmail.com&gt; --- The "URL" is missing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 David Duncan <davdunc(a)amazon.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ngompa13(a)gmail.co | |m) --- Comment #23 from David Duncan <davdunc(a)amazon.com&gt; --- Added the URL: back. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 David Duncan <davdunc(a)amazon.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(davdunc(a)amazon.co | |m) | --- Comment #25 from David Duncan <davdunc(a)amazon.com&gt; --- Spec URL: https://davdunc.fedorapeople.org/ec2-hibinit-agent.spec SRPM URL: https://davdunc.fedorapeople.org/ec2-hibinit-agent-1.0.3-3.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 --- Comment #26 from Mohamed Aboubakr <mabouba(a)amazon.com&gt; --- Any updates on this ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 --- Comment #28 from Mohamed Aboubakr <mabouba(a)amazon.com&gt; --- Do you have in SOURCE folder this amazon-ec2-hibinit-agent-1.0.3 ? cd ~/rpmbuild/SOURCES wget https://github.com/aws/amazon-ec2-hibinit-agent/archive/v1.0.3/ec2-hibini... tar -xf ec2-hibinit-agent-1.0.3.tar.gz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 --- Comment #30 from David Duncan <davdunc(a)amazon.com&gt; --- (In reply to Neal Gompa from comment #29) Absolutely agreed! I have the current SRPM built for f33 here: https://davdunc.fedorapeople.org/ec2-hibinit-agent-1.0.3-3.fc33.src.rpm I apologize for the previous one. This one is verified to function as expected. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 David Duncan <davdunc(a)amazon.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ngompa13(a)gmail.co | |m) --- Comment #32 from David Duncan <davdunc(a)amazon.com&gt; --- @ngompa13(a)gmail.com https://davdunc.fedorapeople.org/ec2-hibinit-agent-1.0.3-3.fc33.src.rpm updated with the content modifications for sleep-handler.sh and 00-hibinitagent.conf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 David Duncan <davdunc(a)amazon.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ngompa13(a)gmail.co | |m) --- Comment #34 from David Duncan <davdunc(a)amazon.com&gt; --- @ngompa13(a)gmail.com https://davdunc.fedorapeople.org/ec2-hibinit-agent-1.0.3-3.fc33.src.rpm Updated Spec file: https://davdunc.fedorapeople.org/ec2-hibinit-agent.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 Neal Gompa <ngompa13(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ngompa13(a)gmail.co | |m) | --- Comment #36 from Neal Gompa <ngompa13(a)gmail.com&gt; --- (In reply to Mohamed Aboubakr from comment #35) My feedback in comment 31 is still not addressed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 --- Comment #38 from Neal Gompa <ngompa13(a)gmail.com&gt; --- (In reply to David Duncan from comment #37) It's still there. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 --- Comment #40 from Neal Gompa <ngompa13(a)gmail.com&gt; --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache License 2.0", "Unknown or generated", "Apache License 2.0". 16 files have unknown license. Detailed output of licensecheck in /home/ngompa/1872427-ec2-hibinit- agent/licensecheck.txt [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/systemd/system- sleep(tlp, systemd-udev) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in ec2-hibinit-agent [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ec2-hibinit-agent-1.0.3-3.fc34.noarch.rpm ec2-hibinit-agent-1.0.3-3.fc34.src.rpm ec2-hibinit-agent.noarch: E: executable-marked-as-config-file /etc/acpi/actions/sleep.sh ec2-hibinit-agent.noarch: E: non-readable /var/lib/hibinit-agent/hibernation-enabled 600 ec2-hibinit-agent.noarch: W: no-manual-page-for-binary hibinit-agent ec2-hibinit-agent.noarch: W: dangerous-command-in-%pre cp ec2-hibinit-agent.noarch: W: dangerous-command-in-%posttrans rm 2 packages and 0 specfiles checked; 2 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- ec2-hibinit-agent.noarch: E: executable-marked-as-config-file /etc/acpi/actions/sleep.sh ec2-hibinit-agent.noarch: E: non-readable /var/lib/hibinit-agent/hibernation-enabled 600 ec2-hibinit-agent.noarch: W: no-manual-page-for-binary hibinit-agent ec2-hibinit-agent.noarch: W: dangerous-command-in-%pre cp ec2-hibinit-agent.noarch: W: dangerous-command-in-%posttrans rm 1 packages and 0 specfiles checked; 2 errors, 3 warnings. Source checksums ---------------- https://github.com/aws/amazon-ec2-hibinit-agent/archive/v1.0.3/ec2-hibini... : CHECKSUM(SHA256) this package : 6ac264c6c67381e2458c1af534aea34b482e69f266ea00aa5d678f2817dadb09 CHECKSUM(SHA256) upstream package : 6ac264c6c67381e2458c1af534aea34b482e69f266ea00aa5d678f2817dadb09 Requires -------- ec2-hibinit-agent (rpmlib, GLIBC filtered): /bin/sh /usr/bin/bash /usr/bin/python3 /usr/bin/sh acpid config(ec2-hibinit-agent) grubby libselinux-utils policycoreutils policycoreutils-python-utils python(abi) selinux-policy selinux-policy-base systemd tuned Provides -------- ec2-hibinit-agent: config(ec2-hibinit-agent) ec2-hibinit-agent python3.9dist(ec2-hibinit-agent) python3dist(ec2-hibinit-agent) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1872427 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: R, PHP, Ocaml, Perl, Haskell, fonts, Python, SugarActivity, Java, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 --- Comment #42 from Gwyn Ciesla <gwync(a)protonmail.com&gt; --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ec2-hibinit-agent -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 --- Comment #43 from Fedora Update System <updates(a)fedoraproject.org&gt; --- FEDORA-2021-58b86608cb has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-58b86608cb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|NEXTRELEASE |ERRATA --- Comment #45 from Fedora Update System <updates(a)fedoraproject.org&gt; --- FEDORA-2021-58b86608cb has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 --- Comment #47 from Fedora Update System <updates(a)fedoraproject.org&gt; --- FEDORA-EPEL-2021-a5d5e1ef36 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-a5d5e1ef36 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 --- Comment #49 from Fedora Update System <updates(a)fedoraproject.org&gt; --- FEDORA-EPEL-2023-236199f4d4 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-236199f4d4 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1872427

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 --- Comment #51 from Fedora Update System <updates(a)fedoraproject.org&gt; --- FEDORA-2023-642382d570 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-642382d570 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1872427

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 --- Comment #53 from Fedora Update System <updates(a)fedoraproject.org&gt; --- FEDORA-2023-4edd939f66 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-4edd939f66` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-4edd939f66 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1872427

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 --- Comment #55 from Fedora Update System <updates(a)fedoraproject.org&gt; --- FEDORA-EPEL-2023-236199f4d4 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1872427

https://bugzilla.redhat.com/show_bug.cgi?id=1872427 --- Comment #57 from Fedora Update System <updates(a)fedoraproject.org&gt; --- FEDORA-2023-4edd939f66 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1872427 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...