Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: pastebinit - command line tool to pastebin file
https://bugzilla.redhat.com/show_bug.cgi?id=620181
Summary: Review Request: pastebinit - command line tool to pastebin file Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: alexisis-pristontale@hotmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://pikachu.2014.free.fr/public/alexises/packaging/pastebinit/pastebinit.... SRPM URL: http://pikachu.2014.free.fr/public/alexises/packaging/pastebinit/pastebinit-... Description: A software that lets you send anything you want directly to a pastebin from the command line. This software lets you send a file or simply the result of a command directly to the pastebin you want (if it's supported) and gives you the URL in return.
the program pass correctly mock compil and here are the rpmlint output :
[packager@tux SPECS]$ rpmlint pastebinit.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [packager@tux SPECS]$ rpmlint ../SRPMS/pastebinit-1.1-1.fc13.src.rpm pastebinit.src: W: spelling-error Summary(en_US) pastebin -> paste bin, paste-bin, pasteboard pastebinit.src: W: spelling-error %description -l en_US pastebin -> paste bin, paste-bin, pasteboard 1 packages and 0 specfiles checked; 0 errors, 2 warnings. [packager@tux SPECS]$ rpmlint ../RPMS/noarch/pastebinit-1.1-1.fc13.noarch.rpm pastebinit.noarch: W: spelling-error Summary(en_US) pastebin -> paste bin, paste-bin, pasteboard pastebinit.noarch: W: spelling-error %description -l en_US pastebin -> paste bin, paste-bin, pasteboard pastebinit.noarch: W: non-conffile-in-etc /etc/pastebin.d/paste.debian.net.conf pastebinit.noarch: W: non-conffile-in-etc /etc/pastebin.d/stikked.com.conf pastebinit.noarch: W: non-conffile-in-etc /etc/pastebin.d/slexy.org.conf pastebinit.noarch: W: non-conffile-in-etc /etc/pastebin.d/pastebin.com.conf pastebinit.noarch: W: non-conffile-in-etc /etc/pastebin.d/paste2.org.conf pastebinit.noarch: W: non-conffile-in-etc /etc/pastebin.d/yourpaste.net.conf pastebinit.noarch: W: non-conffile-in-etc /etc/pastebin.d/fpaste.org.conf pastebinit.noarch: W: non-conffile-in-etc /etc/pastebin.d/pastebin.ca.conf pastebinit.noarch: W: non-conffile-in-etc /etc/pastebin.d/paste.ubuntu.com.conf pastebinit.noarch: W: non-conffile-in-etc /etc/pastebin.d/pastie.org.conf 1 packages and 0 specfiles checked; 0 errors, 12 warnings. [packager@tux SPECS]$
All warnings are false positives, especially the spelling issues; the /etc/* files should not be edited, so in this case the %config macro is not needed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620181
Lameire Alexis alexisis-pristontale@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841(FE-NEEDSPONSOR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620181
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@ioa.s.u-tokyo.ac.jp
--- Comment #1 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-08-21 14:09:07 EDT --- Before checking this package:
(In reply to comment #0)
All warnings are false positives, especially the spelling issues; the /etc/* files should not be edited, so in this case the %config macro is not needed.
- Then these files currently under /etc should be moved to /usr/share (%_datadir). Files under /etc must be used for actually "configuration" files, and if the files are not expected to be modified, /usr/share should be used instead of /etc.
http://www.pathname.com/fhs/pub/fhs-2.3.html#ETCHOSTSPECIFICSYSTEMCONFIGURAT...
http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREARCHITECTUREINDEPENDENT...
- Also I fail to understand why this package uses "pastebin.d" name for directory name. I guess %{_datadir}/%{name} (/usr/share/pastebinit) is more suitable to avoid potential namespace conflict.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620181
--- Comment #2 from Lameire Alexis alexisis-pristontale@hotmail.com 2010-08-21 15:04:18 EDT --- This dir is hardcoded on the script. I can't do anything unless I patch the sources. That is what I will do and by the way I will warn the developers about this issue
Thanks for having a look at my package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620181
--- Comment #3 from Lameire Alexis alexisis-pristontale@hotmail.com 2010-08-21 15:57:29 EDT --- New version with your suggestions; I submitted your fixes upstream: https://bugs.launchpad.net/pastebinit/+bug/62192
SPEC : http://pikachu.2014.free.fr/public/alexises/packaging/pastebinit/1.1-2/paste... SRPM : http://pikachu.2014.free.fr/public/alexises/packaging/pastebinit/1.1-2/paste...
rpmlint output :
[packager@gnu SRPMS]$ rpmlint pastebinit-1.1-2.fc13.src.rpm pastebinit.src: W: spelling-error Summary(en_US) pastebin -> paste bin, paste-bin, pasteboard pastebinit.src: W: spelling-error %description -l en_US pastebin -> paste bin, paste-bin, pasteboard 1 packages and 0 specfiles checked; 0 errors, 2 warnings. [packager@gnu SRPMS]$ rpmlint ../RPMS/noarch/pastebinit-1.1-2.fc13.noarch.rpm pastebinit.noarch: W: spelling-error Summary(en_US) pastebin -> paste bin, paste-bin, pasteboard pastebinit.noarch: W: spelling-error %description -l en_US pastebin -> paste bin, paste-bin, pasteboard 1 packages and 0 specfiles checked; 0 errors, 2 warnings. [packager@gnu SRPMS]$
All are done :) ready to recheck, more speed them pizza hut :D
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620181
--- Comment #4 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-08-22 15:06:14 EDT --- Some comments:
* BuildRoot - For Fedora and EPEL6, BuildRoot tag is no longer needed: https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
* "sed"ing ---------------------------------------------------------------------- sed "s|/etc/pastebin.d|%{_datadir}%{name}|g" %{name} ---------------------------------------------------------------------- - This line does nothing (just outputs the result of sed to stdout) Perhaps you meant "sed -i"
- %{_datadir}%{name} is expanded as /usr/sharepastebinit (%{_datadir} = /usr/share, not /usr/share/)
- Also perhaps you want to modify README file, and "/.pastebin.d" in pastebinit and README.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620181
--- Comment #5 from Lameire Alexis alexisis-pristontale@hotmail.com 2010-08-22 16:57:22 EDT --- Hi,
thanks again for your comment. Here is the new version: SPEC : http://pikachu.2014.free.fr/public/alexises/packaging/pastebinit/1.1-3/paste... SRPM : http://pikachu.2014.free.fr/public/alexises/packaging/pastebinit/1.1-3/paste...
- solved the -i and the missing / - added new sed to modify the name of the user config. file (~/.pastebinit.d -> ~/.pastebinit) - moved an example conf. file to %{_docdir} - deleted BuildRootTag.
I hope this should be OK now :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620181
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED QAContact|extras-qa@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620181
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #6 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-08-23 14:56:06 EDT --- Almost okay.
For -3:
* Macros ---------------------------------------------------------------- xsltproc -''-nonet /usr/share/sgml/docbook/xsl-stylesheets*/manpages/docbook.xsl pastebinit.xml ---------------------------------------------------------------- - Please use %{_datadir} for /usr/share here.
---------------------------------------------------------- This package (pastebinit) is APPROVED by mtasaka ----------------------------------------------------------
Please follow the procedure written on: http://fedoraproject.org/wiki/PackageMaintainers/Join from "Get a Fedora Account". After you create your account on FAS (Fedora Account System), please write your account name on this bug. Then I will sponsor you.
If you want to import this package into Fedora 12/13/14, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on koji Fedora rebuilding system).
When using Fedora SCM system, please check below for reference: http://fedoraproject.org/wiki/Using_Fedora_GIT
If you have questions, please ask me.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620181
--- Comment #7 from Lameire Alexis alexisis-pristontale@hotmail.com 2010-08-23 15:04:38 EDT --- I have already a Fas account, my username is alexises. thenks for approuving my job.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620181
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) |
--- Comment #8 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-08-23 15:31:42 EDT --- Okay, now I am sponsoring you. Please follow "Join" wiki again.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620181
Lameire Alexis alexisis-pristontale@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841(FE-NEEDSPONSOR)
--- Comment #9 from Lameire Alexis alexisis-pristontale@hotmail.com 2010-08-23 16:58:05 EDT --- New Package SCM Request ======================= Package Name: pastebinit Short Description: command line tool to pastebin file Owners: alexises Branches: f13 f14 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620181
Lameire Alexis alexisis-pristontale@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) | Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620181
--- Comment #10 from Kevin Fenzi kevin@tummy.com 2010-08-24 19:54:01 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620181
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620181
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2010-08-25 13:25:07 EDT --- pastebinit-1.1-4.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/pastebinit-1.1-4.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620181
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2010-08-25 13:32:15 EDT --- pastebinit-1.1-4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/pastebinit-1.1-4.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620181
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution| |NEXTRELEASE AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp QAContact|mtasaka@ioa.s.u-tokyo.ac.jp |extras-qa@fedoraproject.org Last Closed| |2010-08-25 14:31:08
--- Comment #13 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-08-25 14:31:08 EDT --- Closing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620181
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2010-09-07 22:19:39 EDT --- pastebinit-1.1-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620181
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |pastebinit-1.1-4.fc13 Resolution|NEXTRELEASE |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620181
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2010-09-08 00:34:32 EDT --- pastebinit-1.1-4.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620181
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|pastebinit-1.1-4.fc13 |pastebinit-1.1-4.fc14
package-review@lists.fedoraproject.org