Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208072
Summary: Review Request: brasero - Gnome CD/DVD burning application Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: denis@poolshark.org QAContact: fedora-package-review@redhat.com
(project formerly known as "bonfire")
Spec URL: http://www.poolshark.org/src/brasero.spec SRPM URL: http://www.poolshark.org/src/brasero-0.4.4-1.src.rpm
Description: Simple and easy to use CD/DVD burning application for the Gnome desktop.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: brasero - Gnome CD/DVD burning application
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208072
------- Additional Comments From bdpepple@ameritech.net 2006-09-26 09:23 EST ------- Here's a quick items:
1. Why are you redefining %version? 2. Duplicate BuildRequires: glib2-devel (by gtk2-devel), libxml2-devel (by libgnome-devel), gnome-vfs2-devel (by libgnome-devel), gtk2-devel (by libgnomeui-devel), libgnome-devel (by libgnomeui-devel)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: brasero - Gnome CD/DVD burning application
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208072
------- Additional Comments From denis@poolshark.org 2006-09-26 10:10 EST ------- 1. *bonk*. fixed 2. fixed.
Spec URL: http://www.poolshark.org/src/brasero.spec SRPM URL: http://www.poolshark.org/src/brasero-0.4.4-2.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: brasero - Gnome CD/DVD burning application
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208072
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin@tummy.com
------- Additional Comments From kevin@tummy.com 2006-10-02 21:30 EST ------- Humm. I can't make much from the URL and Source0 links here. Do they need to be updated?
The URL points to a graphic design web site with lots of flash and javascript, but no mention of open source software I can see. The Source0 url on sourceforge doesn't seem to point to any files... ;(
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: brasero - Gnome CD/DVD burning application
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208072
------- Additional Comments From denis@poolshark.org 2006-10-03 05:14 EST ------- Homepage changes yes thx. Fixed.
http://www.poolshark.org/src/brasero.spec http://www.poolshark.org/src/brasero-0.4.4-3.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: brasero - Gnome CD/DVD burning application
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208072
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |kevin@tummy.com OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From kevin@tummy.com 2006-10-03 13:09 EST ------- ok. That looks much better. ;)
Look for a full review later today...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: brasero - Gnome CD/DVD burning application
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208072
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From kevin@tummy.com 2006-10-03 13:25 EST ------- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 1ef6ae66677ed9136634692d8bc1cc7a brasero-0.4.4.tar.bz2 1ef6ae66677ed9136634692d8bc1cc7a brasero-0.4.4.tar.bz2.1 OK - Package compiles and builds on at least one arch. OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package is a GUI app and has a .desktop file OK - Package doesn't own any directories other packages own. OK - No rpmlint output.
SHOULD Items:
OK - Should include License or ask upstream to include it. OK - Should build in mock.
Issues:
1. 0.4.91 seems to be out but it looks like thats a unstable testing version (hard to be sure).
No other blockers I can see... this package is APPROVED.
Please remember to close this package NEXTRELEASE once it's been imported and built.
Consider reviewing another waiting package to help spread the reviewing load. :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: brasero - Gnome CD/DVD burning application
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208072
denis@poolshark.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From denis@poolshark.org 2006-10-04 06:22 EST ------- I'll test the unstable release and consider them for upgrades. I'm actually working on this upstream project at the moment.
Built. Thanks for the review!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: brasero - Gnome CD/DVD burning application
https://bugzilla.redhat.com/show_bug.cgi?id=208072
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla