Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190958
Summary: Review Request: php-pear-Net-SMTP Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: Fedora@FamilleCollet.com QAContact: fedora-package-review@redhat.com
Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP.spec SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP-1.2.8-1.fc5.src.rpm Description: Provides an implementation of the SMTP protocol using PEAR's Net_Socket class.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-SMTP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190958
Fedora@FamilleCollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |190956, 190957
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-SMTP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190958
------- Additional Comments From Fedora@FamilleCollet.com 2006-05-20 12:50 EST ------- Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP.spec SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP-1.2.8-2.fc5.src.rpm Mock build.log : http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP-build.log
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-SMTP Alias: php-pear-Net-SMTP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190958
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |chris.stone@gmail.com BugsThisDependsOn| |190007 OtherBugsDependingO|163776 |163778 nThis| | Alias| |php-pear-Net-SMTP
------- Additional Comments From chris.stone@gmail.com 2006-06-27 05:58 EST ------- I will do a formal review on this package but you will not be able to check it in until you are sponsered with bug #190007
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-SMTP Alias: php-pear-Net-SMTP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190958
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn|190007 |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-SMTP Alias: php-pear-Net-SMTP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190958
------- Additional Comments From chris.stone@gmail.com 2006-06-27 18:55 EST ------- MUST ITEM CHECKLIST: - rpmlint output: W: php-pear-Net-SMTP invalid-license PHP License W: php-pear-Net-SMTP dangerous-command-in-%post install W: php-pear-Net-SMTP invalid-license PHP License
Warnings can be ignored
- package is named according to php packaging naming guidelines - spec file name matches %{name} - package meets packaging guidelines - package is licensed with open source compatible license - license field matches actual license - source contains license file in %doc - spec file is in American English (and french) - spec file is legible - sources match upstream acd7c31aa6a083ff6bff86ffba02bcbb Net_SMTP-1.2.8.tgz - package successfully compiles and builds on FC-5 x86_64 O This package is missing: Requires(post): php-pear >= 1.4.9 Requires(postun): php-pear >= 1.4.9 Requires(hint): php-pear(Auth_SASL) - package does not use locales - package does not contain shared libraries in default paths (no need to run ldconfig) - package is not relocatable - package does not own all directories it creates It does not own the /usr/share/pear/Net directory. - package does not contain any duplicate %files - permissions are set properly - package contains proper %clean section - macro usage is consistant - package contains permissible content - package does not have large documentation - package does not include header files or static libraries - package does not use pkgconfig files - package does not contain library with suffix - package does not require a devel subpackage - package does not contain any .la files - package is not a gui and does not need a .desktop file - package does not own files or directories owned by other packages This may change in future.
MUST - Must own the /usr/share/pear/Net directory add a %dir %{peardir}/Net - Must Add: Requires(post): php-pear >= 1.4.9 Requires(postun): php-pear >= 1.4.9 - Uncomment Requires(hint): php-pear(Auth_SASL) - Explain why adding || : in %post and %postun sections was added, should we not fail if this step fails? - Change %defattr to (-,root,root,-) - Remove dist tages in changelog version numbers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-SMTP Alias: php-pear-Net-SMTP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190958
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |196824 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-SMTP Alias: php-pear-Net-SMTP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190958
------- Additional Comments From chris.stone@gmail.com 2006-06-28 05:38 EST ------- It appears Auth_SASL is not optional, so this should be in Requires: not Requries(hint):
Also you should add Requires: php >= 4.0.5 The version dependency on php-pear is not needed in the Requires, its only needed in building
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-SMTP Alias: php-pear-Net-SMTP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190958
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|196824 | nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-SMTP Alias: php-pear-Net-SMTP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190958
------- Additional Comments From Fedora@FamilleCollet.com 2006-09-02 03:52 EST ------- Spec: http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP.spec SRPM: http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP-1.2.8-3.fc5.src.rpm Mock: http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP-build.log
Changes: - install Licence in prep - use new macros from /etc/rpm/macros.pear - own /usr/share/pear/Net - require php >= 4.0.5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-SMTP Alias: php-pear-Net-SMTP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190958
------- Additional Comments From Fedora@FamilleCollet.com 2006-09-03 12:33 EST ------- Spec: http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP.spec SRPM: http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP-1.2.8-4.fc5.src.rpm Mock: http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP-build.log
Changes: - new and simpler %%prep and %%install
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-SMTP Alias: php-pear-Net-SMTP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190958
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From chris.stone@gmail.com 2006-09-03 20:09 EST ------- Change: %defattr(-,root,root)
To: %defattr(-,root,root,-)
After checking into CVS. Approved.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-SMTP Alias: php-pear-Net-SMTP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190958
Bug 190958 depends on bug 190956, which changed state.
Bug 190956 Summary: Review Request: php-pear-Auth-SASL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190956
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-SMTP Alias: php-pear-Net-SMTP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190958
Bug 190958 depends on bug 190957, which changed state.
Bug 190957 Summary: Review Request: php-pear-Net-Socket https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190957
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-SMTP Alias: php-pear-Net-SMTP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190958
Fedora@FamilleCollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-SMTP Alias: php-pear-Net-SMTP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190958
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium
Fedora@FamilleCollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From Fedora@FamilleCollet.com 2007-03-31 04:29 EST ------- Package Change Request ====================== Package Name: php-pear-Net-SMTP New Branches: EL-5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-SMTP Alias: php-pear-Net-SMTP
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190958
petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From petersen@redhat.com 2007-04-02 09:03 EST ------- done
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-SMTP Alias: php-pear-Net-SMTP
https://bugzilla.redhat.com/show_bug.cgi?id=190958
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org