Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538673 Pádraig Brady <p(a)draigbrady.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bruno(a)clisp.org, | |jim(a)meyering.net --- Comment #1 from Pádraig Brady <p(a)draigbrady.com&gt; 2009-11-19 03:56:05 EDT --- Oops, obviously the package name is libunistring not libunitstring. Also adding Jim and Bruno to CC -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538673 Parag AN(पराग) <panemade(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade(a)gmail.com --- Comment #3 from Parag AN(पराग) <panemade(a)gmail.com&gt; 2009-11-19 06:14:44 EDT --- oops while working on this review I guess Jim already took this. Anyway here is my review work Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1815778 + rpmlint is silent for SRPM and for RPM. + source files match upstream url (sha1sum) 75e9d6f79a321a62497f1808db35a1b52b7ba765 libunistring-0.9.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + %clean is present. + package installed properly. + Package contains code, not content. + no .pc file present. + -devel subpackage present. + no .la files. + no translations are available + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Package libunistring-0.9.1-1.fc13.i686 => Provides: libunistring.so.0 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libunistring.so.0 rtld(GNU_HASH) + Package libunistring-devel-0.9.1-1.fc13.i686 => Requires: libunistring.so.0 + Not a GUI application Suggestions: 1) you can simply write description for -devel package as Development files for programs using libunistring. 2) to preserve timestamps of upstream files that are copied as it is use make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" 3)defattr for devel should be %defattr(-,root,root,-) 4) Good if you follow same way of writing macros as defined at https://fedoraproject.org/wiki/Packaging/RPMMacros though %_libdir is same as %{_libdir} 5) Use scriptlet format given at https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Texinfo including changing Requires also. 6) I don't see any use of including Requires: pkgconfig for -devel package. Please remove it. 7) you don't need BuildRequires: automake libtool remove them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538673 Parag AN(पराग) <panemade(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|meyering(a)redhat.com |panemade(a)gmail.com Flag| |fedora-review? --- Comment #5 from Parag AN(पराग) <panemade(a)gmail.com&gt; 2009-11-19 07:32:32 EDT --- Thanks you. I will review this. Please feel free to comment if I miss anything to check in this review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538673 Ralf Corsepius <rc040203(a)freenet.de&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203(a)freenet.de --- Comment #7 from Ralf Corsepius <rc040203(a)freenet.de&gt; 2009-11-19 11:17:06 EDT --- These BuildRequires: glibc-devel texinfo also not needed. Please remove them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538673 --- Comment #9 from Pádraig Brady <p(a)draigbrady.com&gt; 2009-11-19 11:58:54 EDT --- Now no BuildRequires at all and ${RPM_BUILD_ROOT} -> $RPM_BUILD_ROOT http://www.pixelbeat.org/patches/libunistring/libunistring.spec http://www.pixelbeat.org/patches/libunistring/libunistring-0.9.1-3.fc11.s... cheers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538673 Pádraig Brady <p(a)draigbrady.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? --- Comment #11 from Pádraig Brady <p(a)draigbrady.com&gt; 2009-11-20 10:59:02 EDT --- New Package CVS Request ======================= Package Name: libunistring Short Description: GNU Unicode string library Owners: pbrady meyering Branches: F-11 F-12 InitialCC: i18n-team -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538673 Parag AN(पराग) <panemade(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE --- Comment #13 from Parag AN(पराग) <panemade(a)gmail.com&gt; 2009-12-09 01:16:17 EDT --- This looks already built for all branches. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.