Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcompris - Educational suite for kids 2-10 years old https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189717 j.w.r.degoede(a)hhs.nl changed: What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |189699 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcompris - Educational suite for kids 2-10 years old https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189717 ------- Additional Comments From j.w.r.degoede(a)hhs.nl 2006-04-25 04:10 EST ------- I've updated both the spec file ant he -files.tar.gz with a -2 version, this fixes issue 1) unfortunatly upstreams fix for issue 2) was not correct / did not fix the issue. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcompris - Educational suite for kids 2-10 years old https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189717 ------- Additional Comments From j.w.r.degoede(a)hhs.nl 2006-04-27 03:04 EST ------- (In reply to comment #3) My bad I added a changelog entry for my changes but forgot to bump Release: I will fix this (easy). Thats because it depends on gcompris-libs, where the actual libs are thats what you get with program and libs (and data) in one _big_ upstream tarbal. gcompris comes with plenty of documentation in the main package in a lot of languages, so yes I intend to ignore these :) Thats because I used diff not gendiff to generate the diff, this is totaly harmless, but I can remove it if it makes you happy. My grand master plan was / is to ask for a FC-5 cvs branch for libassetml, gnucap and gcompris all at the same time. Other .desktop files have this too (gsview for example) it works fine either way,but my desktop patch did screw up the .desktop translations, so I have to fix that anyways, I can also add the .png at the same time if you want, but that would be unnescesarry deviation from upstream. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcompris - Educational suite for kids 2-10 years old https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189717 Bug 189717 depends on bug 189699, which changed state. Bug 189699 Summary: Review Request: gnucap - The Gnu Circuit Analysis Package https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189699 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcompris - Educational suite for kids 2-10 years old https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189717 wart(a)kobold.org changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From wart(a)kobold.org 2006-04-30 03:12 EST ------- rpmlint output: E: gcompris hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/menu - This is a bogus warning. rpmlint is complaining about the src rpm without realizing that this file is being removed, not included. W: gcompris-devel no-dependency-on gcompris - This is ok by design. -devel requires -libs so that it doesn't need to pull in rather large (and unnecessary) base package. W: gcompris-devel no-documentation W: gcompris-libs no-documentation - This can be ignored. The developers documentation is integrated with the base package's documentation. W: gcompris-flags no-documentation W: gcompris-sound-da no-documentation W: gcompris-sound-de no-documentation W: gcompris-sound-en no-documentation W: gcompris-sound-es no-documentation W: gcompris-sound-eu no-documentation W: gcompris-sound-fi no-documentation W: gcompris-sound-fr no-documentation W: gcompris-sound-hu no-documentation W: gcompris-sound-it no-documentation W: gcompris-sound-nl no-documentation W: gcompris-sound-pt no-documentation W: gcompris-sound-ru no-documentation W: gcompris-sound-sv no-documentation - These can be ignored. There's no need for documentation for localized sound/flag files. MUST ==== * GPL license ok, license file included * Package and spec file named appropriately * Spec file legible and in Am. English (except for the localized parts) * Sources for the review came from upstream: d80e55da21170a98d671c98b3e582cc3 SOURCES/gcompris-7.4.tar.gz * Builds in mock on devel-i386, devel-x86_64 * Locales handled appropriately * ldconfig called for shared libs in -libs subpackage * Not relocatable * Owns directories that it creates * No duplicate %files * Contains code and permissible content * $RPM_BUILD_ROOT cleaned correctly in %install and %clean * File permissions appear to be ok * headers, .so, and pkgconfig files in -devel * -devel requires -libs, not base (this is acceptable, see above) * .la files not included * .desktop files installed correctly * No need for -doc subpackage SHOULD ========= * Consider adding Requires: tuxpaint for the tuxpaint launcher I did a quick check of the english/german sounds on a handful of the games and it worked with no obvious problems. No blockers found. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.