https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Robert-André Mauchin zebob.m@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com

--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- Hello,

I've got an issue with the doc, they are to large, around 13MB, and thus they should be in a separate noarch doc subpackage:

[!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 13772800 bytes in /usr/share ghc- foundation-devel-0.0.13-1.fc26.x86_64.rpm:13762560 See:

http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guid...

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Robert-André Mauchin zebob.m@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+

--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- All good, package accepted.

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (unspecified)", "BSD (2 clause)", "Unknown or generated", "*No copyright* BSD (unspecified)". 106 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/ghc- foundation/review-ghc-foundation/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc/ghc/html, /usr/share/doc/ghc/html/libraries, /usr/share/doc/ghc [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ghc- foundation-devel-doc [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 13793280 bytes in /usr/share ghc- foundation-devel-doc-0.0.13-2.fc26.x86_64.rpm:13762560 See:

http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guid... [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: ghc-foundation-0.0.13-2.fc26.x86_64.rpm ghc-foundation-devel-0.0.13-2.fc26.x86_64.rpm ghc-foundation-devel-doc-0.0.13-2.fc26.x86_64.rpm ghc-foundation-0.0.13-2.fc26.src.rpm ghc-foundation.x86_64: W: spelling-error %description -l en_US bugfixes -> bug fixes, bug-fixes, suffixes ghc-foundation.x86_64: W: spelling-error %description -l en_US unicode -> Unicode, uni code, uni-code ghc-foundation.x86_64: W: no-documentation ghc-foundation.src: W: spelling-error %description -l en_US bugfixes -> bug fixes, bug-fixes, suffixes ghc-foundation.src: W: spelling-error %description -l en_US unicode -> Unicode, uni code, uni-code 4 packages and 0 specfiles checked; 0 errors, 5 warnings.

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

--- Comment #5 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-foundation

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Elliott Sales de Andrade quantum.analyst@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1487900

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1487900 [Bug 1487900] Review Request: ghc-memory - Memory and related abstraction stuff

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Elliott Sales de Andrade quantum.analyst@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1488611

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1488611 [Bug 1488611] Review Request: ghc-cryptonite - Cryptography Primitives sink

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-09-09 19:50:49

--- Comment #7 from Fedora Update System updates@fedoraproject.org --- ghc-foundation-0.0.13-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Elliott Sales de Andrade quantum.analyst@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1494336

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1494336 [Bug 1494336] Review Request: ghc-x509 - X509 reader and writer

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Elliott Sales de Andrade quantum.analyst@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1494879

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1494879 [Bug 1494879] Review Request: ghc-x509-system - Handle per-operating-system X.509 accessors and storage

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Elliott Sales de Andrade quantum.analyst@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1495018

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1495018 [Bug 1495018] Review Request: ghc-tls - TLS/SSL protocol native implementation (Server and Client)

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Elliott Sales de Andrade quantum.analyst@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1496285

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1496285 [Bug 1496285] Review Request: ghc-http-client-tls - Http-client backend using the connection package and tls library

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Elliott Sales de Andrade quantum.analyst@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1513301

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1513301 [Bug 1513301] Review Request: ghc-aws - Amazon Web Services (AWS) for Haskell