https://bugzilla.redhat.com/show_bug.cgi?id=2041476 --- Comment #1 from Major Hayden 🤠 <mhayden(a)redhat.com&gt; --- Have you considered using pyproject-rpm-macros to make your packaging a little easier? I've been working on the Goolgle Cloud Python SDKs for a while and it has made things easier: https://src.fedoraproject.org/rpms/python-google-cloud-automl/blob/rawhid... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2041476

https://bugzilla.redhat.com/show_bug.cgi?id=2041476 Juan Orti <jortialc(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jortialc(a)redhat.com --- Comment #3 from Juan Orti <jortialc(a)redhat.com&gt; --- Hi, thanks for taking the review. I'm not familiar with those macros, but they look easier indeed. I will look into that and the mock issue later today. Cheers. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2041476

https://bugzilla.redhat.com/show_bug.cgi?id=2041476 Major Hayden 🤠 <mhayden(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #5 from Major Hayden 🤠 <mhayden(a)redhat.com&gt; --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= 👍🏻 Looks good! Approved. ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache License 2.0", "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* [generated file]". 67 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/python-google-cloud-dns/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-google-cloud-dns-0.34.0-1.fc36.noarch.rpm python-google-cloud-dns-0.34.0-1.fc36.src.rpm python-google-cloud-dns.src:68: W: macro-in-%changelog %autochangelog python-google-cloud-dns.src: W: patch-not-applied Patch0: python-google-cloud-dns-mock.patch 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/googleapis/python-dns/archive/v0.34.0/python-dns-0.34.... : CHECKSUM(SHA256) this package : f85024b50a1ae56202fb85da9e4576b0a8ce58f4eda076beacf20340b288c58f CHECKSUM(SHA256) upstream package : f85024b50a1ae56202fb85da9e4576b0a8ce58f4eda076beacf20340b288c58f Requires -------- python3-google-cloud-dns (rpmlib, GLIBC filtered): (python3.10dist(google-cloud-core) < 3~~dev0 with python3.10dist(google-cloud-core) >= 1.3) python(abi) Provides -------- python3-google-cloud-dns: python-google-cloud-dns python3-google-cloud-dns python3.10-google-cloud-dns python3.10dist(google-cloud-dns) python3dist(google-cloud-dns) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name python-google-cloud-dns --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: PHP, R, SugarActivity, Java, Haskell, fonts, C/C++, Perl, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2041476

https://bugzilla.redhat.com/show_bug.cgi?id=2041476 Juan Orti <jorti(a)protonmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2022-01-18 16:03:02 --- Comment #7 from Juan Orti <jorti(a)protonmail.com&gt; --- Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2041476