https://bugzilla.redhat.com/show_bug.cgi?id=2087174 Ali Erdinc Koroglu <ali.erdinc.koroglu(a)intel.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value --- Comment #1 from Ali Erdinc Koroglu <ali.erdinc.koroglu(a)intel.com&gt; --- This package is runtime dependency for Polari (#2064643). After the reviewing process I'll open unretire request in pagure. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2087174

https://bugzilla.redhat.com/show_bug.cgi?id=2087174 Mamoru TASAKA <mtasaka(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka(a)fedoraproject.org --- Comment #2 from Mamoru TASAKA <mtasaka(a)fedoraproject.org&gt; --- So as I happen to be telepathy-glib maintainer, I comment for now. * Now for new packages License field must use SPDX identifier: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidel... https://spdx.org/licenses/ * For BuildRequires: using "BuildRequires: pkgconfig(foo)" is preferred than to use "BuildRequires: dbus-glib-devel" or so https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildR... * Unneeded BR - At least "BR: openssl-devel" seems unneeded - Also check if there is any more unneeded BRs left. * Using "python-unversioned-command" as BR is strongly discouraged. Patch out not to use non-version python and use python3. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_depend... * scratch build says: checking for Python with Twisted and IRC protocol support... no https://koji.fedoraproject.org/koji/taskinfo?taskID=91402714 Looking at configure.ac, this perhaps means that some twisted tests are disabled. Please consider to enable this. * Directory ownership: https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirector... With "mock --init" and doint "mock --install telepathy-idle.x86_64.rpm", /usr/share/dbus-1/services/ is not owned by any packages. ============================================================= [mockbuild@93f3667e0cdb434cb87064920e66e928 ~]$ rpm -qf /usr/share/dbus-1/services/ file /usr/share/dbus-1/services is not owned by any package ============================================================= Make it sure this directory is owned by some package when telepathy-idle is installed. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2087174

https://bugzilla.redhat.com/show_bug.cgi?id=2087174 --- Comment #3 from Mamoru TASAKA <mtasaka(a)fedoraproject.org&gt; --- Some notes: * For BR: pkgconfig(foo), you can check for configure.ac, and check what is used with PKG_CHECK_MODULES macro or so. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2087174

https://bugzilla.redhat.com/show_bug.cgi?id=2087174 Ali Erdinc Koroglu <ali.erdinc.koroglu(a)intel.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ali.erdinc.korogl | |u(a)intel.com) | --- Comment #5 from Ali Erdinc Koroglu <ali.erdinc.koroglu(a)intel.com&gt; --- I've taken as is from F36 but I updated the spec as you recommended Spec URL: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedor... SRPM URL: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedor... -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2087174

https://bugzilla.redhat.com/show_bug.cgi?id=2087174 Mamoru TASAKA <mtasaka(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2087174

https://bugzilla.redhat.com/show_bug.cgi?id=2087174 --- Comment #8 from Ali Erdinc Koroglu <ali.erdinc.koroglu(a)intel.com&gt; --- I checked the code so license is LGPL-2.1-or-later and as you're saying /usr/share/dbus-1/services belongs to dbus-common which is added as "requires" SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedor... SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedor... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2087174

https://bugzilla.redhat.com/show_bug.cgi?id=2087174 --- Comment #10 from Ali Erdinc Koroglu <ali.erdinc.koroglu(a)intel.com&gt; --- Project's license (https://gitlab.freedesktop.org/telepathy/telepathy-idle/-/blob/master/COP...) is LGPL-2.1-or-later, probably they forgot to change that while migrating from SF.net to SVN 15 years ago :) But we can do like "LGPL-2.1-only AND LGPL-2.1-or-later" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2087174

https://bugzilla.redhat.com/show_bug.cgi?id=2087174 --- Comment #12 from Ali Erdinc Koroglu <ali.erdinc.koroglu(a)intel.com&gt; --- Sure, license is changed as requested SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedor... SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedor... -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2087174

https://bugzilla.redhat.com/show_bug.cgi?id=2087174 Ali Erdinc Koroglu <ali.erdinc.koroglu(a)intel.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ASSIGNED |CLOSED Last Closed| |2022-09-15 06:09:28 --- Comment #14 from Ali Erdinc Koroglu <ali.erdinc.koroglu(a)intel.com&gt; --- Thank you Mamoru https://koji.fedoraproject.org/koji/buildinfo?buildID=2062783 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2087174

https://bugzilla.redhat.com/show_bug.cgi?id=2087174 Ali Erdinc Koroglu <aekoroglu(a)linux.intel.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aekoroglu(a)linux.intel.com --- Comment #16 from Ali Erdinc Koroglu <aekoroglu(a)linux.intel.com&gt; --- Yep I did, thanks https://bodhi.fedoraproject.org/updates/FEDORA-2022-d23557aec2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2087174