https://bugzilla.redhat.com/show_bug.cgi?id=1379830 Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek(a)in.waw.pl Assignee|nobody(a)fedoraproject.org |zbyszek(a)in.waw.pl Flags| |fedora-review? --- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; --- %{!?_licensedir: %global license %%doc} %if 0%{?rhel} && 0%{?rhel} <= 6 %{!?__python2: %global __python2 /usr/bin/python2} %{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} %{!?python2_sitearch: %global python2_sitearch %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} %endif I think this is all unnecessary, tibbs packported the macros. Group → not necessary [https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections]. .egg-info doesn't have to be removed (it's not a "binary egg" that the guidelines talk about). %py2_build %py2_install Source0 returns 404. Is python3 support out of question? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1379830 --- Comment #4 from Ralph Bean <rbean(a)redhat.com&gt; --- OK, the following release should address all your other comments: Spec URL: http://threebean.org/rpm/SPECS/pdc-updater.spec SRPM URL: http://threebean.org/rpm/SRPMS/pdc-updater-0.4.0-1.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1379830 Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #6 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; --- According to the guidelines, Provides: python2-pdc-updater must be added [https://fedoraproject.org/wiki/Packaging:Python#Provides]. + package name is OK + latest version + license is acceptable (LGPGv2+) + license is specified correctly + R/BR look correct - Provides look OK, with one exception, see note above + builds and installs OK + no scriptlets necessary You could replace: %{__python2} setup.py build with %py2_build and %{__python2} setup.py install -O1 --skip-build --root=%{buildroot} with %py2_install. Package is APPROVED, please fix up the Provides when importing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1379830 --- Comment #8 from Ralph Bean <rbean(a)redhat.com&gt; --- Good call! I'll make the update. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1379830 --- Comment #10 from Jon Ciesla <limburgher(a)gmail.com&gt; --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/pdc-updater -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1379830 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1379830 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-12-03 21:50:07 --- Comment #13 from Fedora Update System <updates(a)fedoraproject.org&gt; --- pdc-updater-0.4.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component