https://bugzilla.redhat.com/show_bug.cgi?id=1729763 Robert-André Mauchin <zebob.m(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m(a)gmail.com Assignee|nobody(a)fedoraproject.org |zebob.m(a)gmail.com Flags| |fedora-review? --- Comment #1 from Robert-André Mauchin <zebob.m(a)gmail.com&gt; --- - You need to remove the sphinx build leftovers python3-hpilo.noarch: W: hidden-file-or-dir /usr/share/doc/python3-hpilo/html/.buildinfo python3-hpilo.noarch: W: hidden-file-or-dir /usr/share/doc/python3-hpilo/html/.doctrees python3-hpilo.noarch: W: hidden-file-or-dir /usr/share/doc/python3-hpilo/html/.doctrees %build %py3_build sphinx-build -b html docs html # remove the sphinx-build leftovers rm -rf html/.{doctrees,buildinfo} - Split the doc into a separate doc subpackage: - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 9748480 bytes in 161 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 9748480 bytes in 161 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License (v2.0) or GNU General Public License", "*No copyright* Apache License", "GPL (v3 or later)". 117 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/python-hpilo/review-python- hpilo/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-hpilo-4.3-1.fc31.noarch.rpm python-hpilo-4.3-1.fc31.src.rpm python3-hpilo.noarch: W: spelling-error Summary(en_US) iLO -> i Lo, PLO, lo python3-hpilo.noarch: W: summary-not-capitalized C iLO automation from python or shell python3-hpilo.noarch: W: spelling-error %description -l en_US iLO -> i Lo, PLO, lo python3-hpilo.noarch: W: hidden-file-or-dir /usr/share/doc/python3-hpilo/html/.buildinfo python3-hpilo.noarch: W: hidden-file-or-dir /usr/share/doc/python3-hpilo/html/.doctrees python3-hpilo.noarch: W: hidden-file-or-dir /usr/share/doc/python3-hpilo/html/.doctrees python3-hpilo.noarch: W: no-manual-page-for-binary hpilo_cli python-hpilo.src: W: spelling-error Summary(en_US) iLO -> i Lo, PLO, lo python-hpilo.src: W: summary-not-capitalized C iLO automation from python or shell python-hpilo.src: W: spelling-error %description -l en_US iLO -> i Lo, PLO, lo 2 packages and 0 specfiles checked; 0 errors, 10 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1729763 Robert-André Mauchin <zebob.m(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin <zebob.m(a)gmail.com&gt; --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1729763 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED --- Comment #5 from Fedora Update System <updates(a)fedoraproject.org&gt; --- FEDORA-EPEL-2019-ff588491b6 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-ff588491b6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1729763 --- Comment #7 from Fedora Update System <updates(a)fedoraproject.org&gt; --- python-hpilo-4.3-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component