https://bugzilla.redhat.com/show_bug.cgi?id=2181020 Fabio Valentini <decathorpe(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe(a)gmail.com Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED Flags| |fedora-review? Assignee|nobody(a)fedoraproject.org |decathorpe(a)gmail.com --- Comment #2 from Fabio Valentini <decathorpe(a)gmail.com&gt; --- Package looks good, with two exceptions: 1. Both the MIT and Apache-2.0 licenses require that redistributed sources contain a copy of the license text, but the published crates for the cargo_toml crate do not contain license texts (this is why there's a FIXME in the generated spec file). Looking at the upstream project, there's also no license files there: https://gitlab.com/crates.rs/cargo_toml Please report this with the upstream project. They should include license files, otherwise their own project isn't conforming to the license(s) they chose :) I've already filed similar issues with dozens of other projects ... for example, you can take this one as a template: https://github.com/danieldg/ordered-stream/issues/1 2. The latest version is 0.15.2, but you're packaging 0.13.3. I assume this is intentional (i.e. firecracker depends on ^0.13?)? If that is the case, just confirm this in this bug here. This is enough of a justification to not package the latest version. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2181020

https://bugzilla.redhat.com/show_bug.cgi?id=2181020 --- Comment #4 from Fabio Valentini <decathorpe(a)gmail.com&gt; --- Oh, sorry, I missed that you already filed a ticket. The COPR build service is nice, but it sure adds noise to these tickets ... If the upstream project doesn't respond, please file a PR to include the license files, and include the files from the PR in your package. Great, thanks, that is fine then. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2181020

https://bugzilla.redhat.com/show_bug.cgi?id=2181020 --- Comment #6 from Fabio Valentini <decathorpe(a)gmail.com&gt; --- Hm, true, it is weird to include a photo of a person in the sources ... If it's unclear what the license / rights situation is wrt/ that photo, then yes, it would probably need to be removed from the crate, and the sources re-packaged without it. But as you mention, it's apparently only used in one test file in firecracker, so dropping the dependency and skipping these tests (which don't look that useful) would be easiest. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2181020

https://bugzilla.redhat.com/show_bug.cgi?id=2181020 --- Comment #8 from Fabio Valentini <decathorpe(a)gmail.com&gt; --- The easiest solution for skipping a file with integration tests is: $ rm src/firecracker/tests/verify_dependencies.rs Otherwise, that looks good to me. Feel free to close this ticket as CLOSED/NOTABUG if you no longer need cargo_toml packaged. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2181020