Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=350781
Summary: Review Request: libvoikko - A library for spellcheckers and hyphenators Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: vpivaini@cs.helsinki.fi QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://vpv.fedorapeople.org/packages/libvoikko.spec SRPM URL: http://vpv.fedorapeople.org/packages/libvoikko-1.5-0.1.fc7.src.rpm Description: This is libvoikko, library for spellcheckers and hyphenators using Malaga natural language grammar development tool. The library is written in C.
Currently only Finnish is supported, but the API of the library has been designed to allow adding support for other languages later.
Voikko depends on malaga and suomi-malaga (upstream name, I've named my package malaga-suomi-voikko), please see bug #346121 and bug #349191.
Rpmlint output: libvoikko-devel.i386: W: no-documentation - but there is no documentation that would be suitable for the -devel package, the main package will have all the docs.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libvoikko - A library for spellcheckers and hyphenators
https://bugzilla.redhat.com/show_bug.cgi?id=350781
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |346121, 349191
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libvoikko - A library for spellcheckers and hyphenators
https://bugzilla.redhat.com/show_bug.cgi?id=350781
Bug 350781 depends on bug 346121, which changed state.
Bug 346121 Summary: Review Request: malaga - Programming language for modelling of language-dependent grammatical information https://bugzilla.redhat.com/show_bug.cgi?id=346121
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libvoikko - A library for spellcheckers and hyphenators
https://bugzilla.redhat.com/show_bug.cgi?id=350781
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-11-01 12:32 EST ------- When the rebuild of malaga-suomi-voikko is done for F-9, I will check this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libvoikko - A library for spellcheckers and hyphenators
https://bugzilla.redhat.com/show_bug.cgi?id=350781
Bug 350781 depends on bug 349191, which changed state.
Bug 349191 Summary: Review Request: malaga-suomi-voikko - A description of Finnish morphology written in Malaga (Voikko edition) https://bugzilla.redhat.com/show_bug.cgi?id=349191
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libvoikko - A library for spellcheckers and hyphenators
https://bugzilla.redhat.com/show_bug.cgi?id=350781
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-11-02 02:57 EST ------- Some quick comment: * Rebuild fails at least on i386. http://koji.fedoraproject.org/koji/taskinfo?taskID=224229 It seems at least malaga-devel is missing from BR. * malaga-suomi-voikko already requires malaga. * Please remove static archive.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libvoikko - A library for spellcheckers and hyphenators
https://bugzilla.redhat.com/show_bug.cgi?id=350781
------- Additional Comments From vpivaini@cs.helsinki.fi 2007-11-07 06:39 EST ------- New SPEC: http://vpv.fedorapeople.org/packages/libvoikko.spec New SRPM: http://vpv.fedorapeople.org/packages/libvoikko-1.5-0.2.fc7.src.rpm
I believe I fixed all those issues you pointed out. I also built it in koji as a scratch build, which succeeded.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libvoikko - A library for spellcheckers and hyphenators
https://bugzilla.redhat.com/show_bug.cgi?id=350781
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-11-07 07:08 EST ------- For 1.5-0.2:
* Requires for libvoikko-devel - Would you explain why libvoikko-devel should have "Requires: malaga-devel"? It seems that no header files in libvoikko-devel requires header files in malaga-devel.
* Timestamps - Adding 'INSTALL="install -p"' option to "make install" will save timestamps on man files and header files. (This method usually works for most recent Makefiles).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libvoikko - A library for spellcheckers and hyphenators
https://bugzilla.redhat.com/show_bug.cgi?id=350781
------- Additional Comments From vpivaini@cs.helsinki.fi 2007-11-07 10:44 EST ------- New Spec: http://vpv.fedorapeople.org/packages/libvoikko.spec New SRPM: http://vpv.fedorapeople.org/packages/libvoikko-1.5-0.3.fc7.src.rpm
I removed Requires: malaga-devel from libvoikko-devel, it really wasn't needed. I also added INSTALL="install -p" to make install as you requested.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libvoikko - A library for spellcheckers and hyphenators
https://bugzilla.redhat.com/show_bug.cgi?id=350781
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-11-08 09:22 EST ------- Okay.
----------------------------------------------------------------- This package (libvoikko) is APPROVED by me -----------------------------------------------------------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libvoikko - A library for spellcheckers and hyphenators
https://bugzilla.redhat.com/show_bug.cgi?id=350781
vpivaini@cs.helsinki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From vpivaini@cs.helsinki.fi 2007-11-08 13:00 EST ------- New Package CVS Request ======================= Package Name: libvoikko Short Description: A library for spellcheckers and hyphenators Owners: vpv Branches: F-7 F-8 Cvsextras Commits: yes
Mamoru Tasaka, thanks again for your review and help.
I'm planning to package tmispell-voikko and openoffice.org-voikko later, those would enable using voikko in some KDE and GNOME applications and OO.o. They're both a bit difficult, since tmispell-voikko replaces a possibly installed "original" tmispell and OO.o updates with the voikko component can apparently be a bit problematic. I'll probably send an email to fedora-devel when I have time to start packaging those.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libvoikko - A library for spellcheckers and hyphenators
https://bugzilla.redhat.com/show_bug.cgi?id=350781
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-11-08 13:47 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libvoikko - A library for spellcheckers and hyphenators
https://bugzilla.redhat.com/show_bug.cgi?id=350781
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-11-14 06:08 EST ------- Please close this bug when rebuild and request on koji is done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libvoikko - A library for spellcheckers and hyphenators
https://bugzilla.redhat.com/show_bug.cgi?id=350781
vpivaini@cs.helsinki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From vpivaini@cs.helsinki.fi 2007-11-14 06:19 EST ------- Sorry about leaving this open, I just forgot to close it. Libvoikko has been built in Rawhide, I haven't yet requested for the dependencies to be added to F-7 and F-8 buildroots, I'll probably do that soon.
package-review@lists.fedoraproject.org