[Bug 490724] New: Review Request: R-RUnit - R Unit test framework - package-review

[Bug 490724] New: Review Request: R-RUnit - R Unit test framework

[Bug 490400] New: Review Request:...

[Bug 491570] New: Review Request:...

Red Hat Bugzilla

Tuesday, 17 March 2009 Tue, 17 Mar '09

1:18 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: R-RUnit - R Unit test framework https://bugzilla.redhat.com/show_bug.cgi?id=490724 Summary: Review Request: R-RUnit - R Unit test framework Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody(a)fedoraproject.org ReportedBy: pingou(a)pingoured.fr QAContact: extras-qa(a)fedoraproject.org CC: notting(a)redhat.com, fedora-package-review(a)redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://pingou.fedorapeople.org/RPMs/R-RUnit.spec SRPM URL: http://pingou.fedorapeople.org/RPMs/R-RUnit-0.4.21-1.fc10.src.rpm Description: R functions implementing a standard Unit Testing framework, with additional code inspection and report generation tools -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

Wednesday, 18 March Wed, 18 Mar

4:55 a.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 Pierre-YvesChibon <pingou(a)pingoured.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |490723 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

Friday, 20 March Fri, 20 Mar

3:38 p.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 Conrad Meyer <konrad(a)tylerc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |konrad(a)tylerc.org AssignedTo|nobody(a)fedoraproject.org |konrad(a)tylerc.org Flag| |fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:54 p.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 --- Comment #1 from Conrad Meyer <konrad(a)tylerc.org> 2009-03-20 16:54:05 EDT --- Created an attachment (id=336118) --> (https://bugzilla.redhat.com/attachment.cgi?id=336118) [Review] Attached is my initial review. In summary: - Fix the UTF-8 and one-line-command-in-%post(un) rpmlint warnings. - Fix the License (GPLv2+) - Fix the duplicate files - Why is %{_bindir}/R used in %check? Also, you may want to use %{version} in your Source0. But that's discretionary. Everything else looks good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:15 p.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

...

Created an attachment (id=336118)

--> (https://bugzilla.redhat.com/attachment.cgi?id=336118) [details]

...

[Review] Attached is my initial review. In summary: - Fix the UTF-8 and one-line-command-in-%post(un) rpmlint warnings.

I would rather not because if I do so the pdf generated is corrupted. In addition please see : https://www.redhat.com/archives/fedora-devel-list/2009-January/msg00741.html Regarding the one-line-command-in-%post(un) see: http://fedoraproject.org/wiki/Packaging/R

...

- Fix the License (GPLv2+)

This actually needs information from upstream since the license version are different in the DESCRIPTION file, the website and the sources.

...

- Fix the duplicate files

Fixed

...

- Why is %{_bindir}/R used in %check?

Fixed (change R CMD INSTALL to %{_bindir}R CMD INSTALL)

...

Also, you may want to use %{version} in your Source0. But that's discretionary.

Fixed I will upload the new version as soon as I have news from upstream concerning the license used. Thanks for the review -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:44 p.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

...

(In reply to comment #1) > - Fix the UTF-8 and one-line-command-in-%post(un) rpmlint warnings. I would rather not because if I do so the pdf generated is corrupted. In addition please see : https://www.redhat.com/archives/fedora-devel-list/2009-January/msg00741.html Regarding the one-line-command-in-%post(un) see: http://fedoraproject.org/wiki/Packaging/R

Ok, I accept these warnings.

...

> - Fix the License (GPLv2+) This actually needs information from upstream since the license version are different in the DESCRIPTION file, the website and the sources.

Either way it is an issue to resolve.

...

I will upload the new version as soon as I have news from upstream concerning the license used. Thanks for the review

Thank you for the quick responses. I will approve it when you figure out the license situation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

Saturday, 21 March Sat, 21 Mar

7:30 a.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 Mattias Ellert <mattias.ellert(a)fysast.uu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mattias.ellert(a)fysast.uu.se --- Comment #4 from Mattias Ellert <mattias.ellert(a)fysast.uu.se> 2009-03-21 08:29:56 EDT --- R packaging guildlines say: "Note that other files, such as CONTENTS, INDEX, NAMESPACE, and help/ are not %doc, since proper R functionality depends on their presence." The spec file lists CONTENTS, INDEX and NAMESPACE as %doc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:37 a.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

...

R packaging guildlines say: "Note that other files, such as CONTENTS, INDEX, NAMESPACE, and help/ are not %doc, since proper R functionality depends on their presence." The spec file lists CONTENTS, INDEX and NAMESPACE as %doc.

These should be fixed, then. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:47 a.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 --- Comment #6 from Pierre-YvesChibon <pingou(a)pingoured.fr> 2009-03-21 12:47:22 EDT --- Oups, thanks for pointing this out, I'll fix this. The mail to upstream has been sent yesterday, I'm waiting for an answer. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

Wednesday, 1 April Wed, 1 Apr

3:59 a.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 --- Comment #7 from Pierre-YvesChibon <pingou(a)pingoured.fr> 2009-04-01 04:59:13 EDT --- Second mail sent to the R-devel mailing list -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:09 a.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

...

Hello Pierre, I must have missed your original email. GPL-2 is the intended license specification as given in the DESCRIPTION file. I'll check and update the code headers as soon as I have time for. Thanks for pointing this out. Best regards, Matthias

Update: Spec URL: http://pingou.fedorapeople.org/RPMs/R-RUnit.spec SRPM URL: http://pingou.fedorapeople.org/RPMs/R-RUnit-0.4.21-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:56 a.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 Conrad Meyer <konrad(a)tylerc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #9 from Conrad Meyer <konrad(a)tylerc.org> 2009-04-01 11:56:38 EDT --- Thanks for getting that resolved. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:11 a.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 --- Comment #10 from Pierre-YvesChibon <pingou(a)pingoured.fr> 2009-04-01 12:11:40 EDT --- Thanks for the review :) New Package CVS Request ======================= Package Name: R-RUnit Short Description: R Unit test framework Owners: pingou Branches: F-9 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:12 a.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 Pierre-YvesChibon <pingou(a)pingoured.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:31 a.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 Dennis Gilmore <dennis(a)ausil.us> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+ --- Comment #11 from Dennis Gilmore <dennis(a)ausil.us> 2009-04-01 12:31:33 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

Friday, 3 April Fri, 3 Apr

3:36 a.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 --- Comment #12 from Fedora Update System <updates(a)fedoraproject.org> 2009-04-03 04:36:43 EDT --- R-RUnit-0.4.21-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/R-RUnit-0.4.21-2.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:36 a.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 --- Comment #13 from Fedora Update System <updates(a)fedoraproject.org> 2009-04-03 04:36:49 EDT --- R-RUnit-0.4.21-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/R-RUnit-0.4.21-2.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:38 a.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 --- Comment #14 from Fedora Update System <updates(a)fedoraproject.org> 2009-04-03 05:38:08 EDT --- R-RUnit-0.4.21-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/R-RUnit-0.4.21-3.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:38 a.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 --- Comment #15 from Fedora Update System <updates(a)fedoraproject.org> 2009-04-03 05:38:13 EDT --- R-RUnit-0.4.21-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/R-RUnit-0.4.21-3.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

Monday, 6 April Mon, 6 Apr

6:03 a.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 Pierre-YvesChibon <pingou(a)pingoured.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:27 p.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 --- Comment #16 from Fedora Update System <updates(a)fedoraproject.org> 2009-04-06 16:27:01 EDT --- R-RUnit-0.4.21-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:27 p.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 Fedora Update System <updates(a)fedoraproject.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |0.4.21-3.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:34 p.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 --- Comment #17 from Fedora Update System <updates(a)fedoraproject.org> 2009-04-06 16:34:24 EDT --- R-RUnit-0.4.21-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:34 p.m.

New subject: [Bug 490724] Review Request: R-RUnit - R Unit test framework

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 Fedora Update System <updates(a)fedoraproject.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0.4.21-3.fc10 |0.4.21-3.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

5520

days inactive

5540

days old

package-review@lists.fedoraproject.org

Manage subscription

23 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

[Bug 490724] New: Review Request: R-RUnit - R Unit test framework