10:40 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1445412
Bug ID: 1445412
Summary: Review Request: python-fpylll - A Python wrapper for
fplll
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: paulo.cesar.pereira.de.andrade(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: https://pcpa.fedorapeople.org/python-fpylll.spec
SRPM URL: https://pcpa.fedorapeople.org/python-fpylll-0.2.3dev-1.fc27.src.rpm
Description: A Python wrapper for fplll.
Fedora Account System Username: pcpa
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:41 a.m.
New subject: [Bug 1445412] Review Request: python-fpylll - A Python wrapper for
fplll
https://bugzilla.redhat.com/show_bug.cgi?id=1445412
Paulo Andrade <paulo.cesar.pereira.de.andrade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends On| |1445411
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1445411
[Bug 1445411] Review Request: python-cysignals - Interrupt and signal
handling for Cython
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:34 a.m.
New subject: [Bug 1445412] Review Request: python-fpylll - A Python wrapper for
fplll
https://bugzilla.redhat.com/show_bug.cgi?id=1445412
--- Comment #1 from Paulo Andrade <paulo.cesar.pereira.de.andrade(a)gmail.com> ---
Spec URL: https://pcpa.fedorapeople.org/python-fpylll.spec
SRPM URL: https://pcpa.fedorapeople.org/python-fpylll-0.2.3dev-2.fc27.src.rpm
Update to a very higher quality initial package (based on
python-cysignals review), and to match dependencies in the
current state of the python-cysignals review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:31 a.m.
New subject: [Bug 1445412] Review Request: python-fpylll - A Python wrapper for
fplll
https://bugzilla.redhat.com/show_bug.cgi?id=1445412
Bug 1445412 depends on bug 1445411, which changed state.
Bug 1445411 Summary: Review Request: python-cysignals - Interrupt and signal handling for
Cython
https://bugzilla.redhat.com/show_bug.cgi?id=1445411
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |CLOSED
Resolution|--- |RAWHIDE
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:08 p.m.
New subject: [Bug 1445412] Review Request: python-fpylll - A Python wrapper for
fplll
https://bugzilla.redhat.com/show_bug.cgi?id=1445412
Michel Alexandre Salim <michel(a)michel-slm.name> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |michel(a)michel-slm.name,
| |paulo.cesar.pereira.de.andr
| |ade(a)gmail.com
Assignee|nobody(a)fedoraproject.org |michel(a)michel-slm.name
Flags| |fedora-review?
| |needinfo?(paulo.cesar.perei
| |ra.de.andrade(a)gmail.com)
--- Comment #2 from Michel Alexandre Salim <michel(a)michel-slm.name> ---
Swap with https://bugzilla.redhat.com/show_bug.cgi?id=1448997 ? It's a
dependency for building neovim in EPEL7. Thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:16 a.m.
New subject: [Bug 1445412] Review Request: python-fpylll - A Python wrapper for
fplll
https://bugzilla.redhat.com/show_bug.cgi?id=1445412
Charles R. Anderson <cra(a)wpi.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cra(a)wpi.edu
--- Comment #3 from Charles R. Anderson <cra(a)wpi.edu> ---
(In reply to Michel Alexandre Salim from comment #2)
Swap with https://bugzilla.redhat.com/show_bug.cgi?id=1448997 ?
It's a
dependency for building neovim in EPEL7. Thanks!
I was already going to swap this one for my #1447741, but I'll take #1448997
instead and you can take this one. Thanks.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
11:37 p.m.
New subject: [Bug 1445412] Review Request: python-fpylll - A Python wrapper for
fplll
https://bugzilla.redhat.com/show_bug.cgi?id=1445412
Michel Alexandre Salim <michel(a)michel-slm.name> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(paulo.cesar.perei |
|ra.de.andrade(a)gmail.com) |
--- Comment #4 from Michel Alexandre Salim <michel(a)michel-slm.name> ---
Sorry for the delay! Having problems testing this on mock-rawhide (it can't
install the generated RPMs), will try doing this on F26 by rebuilding the
dependency.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:09 a.m.
New subject: [Bug 1445412] Review Request: python-fpylll - A Python wrapper for
fplll
https://bugzilla.redhat.com/show_bug.cgi?id=1445412
Michel Alexandre Salim <michel(a)michel-slm.name> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #5 from Michel Alexandre Salim <michel(a)michel-slm.name> ---
Package looks good. Might want to upstream the test patch and link to the bug
report / mailing list discussion, or if the patch comes from a newer version of
the software, link to where it comes from -- but this is not a blocker.
APPROVED
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later)", "Unknown or generated". 59 files
have
unknown license. Detailed output of licensecheck in
/home/michel/1445412-python-fpylll/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python2-fpylll , python3-fpylll , python-fpylll-debuginfo
[?]: Package functions as described.
[!]: Latest version is packaged.
packager cites compatibility reason for this
[!]: Package does not include license text files separate from upstream.
license file backported from next version
[!]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
might want to upstream this patch (or note if it comes from a
newer version)
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: python2-fpylll-0.2.3dev-2.fc27.x86_64.rpm
python3-fpylll-0.2.3dev-2.fc27.x86_64.rpm
python-fpylll-debuginfo-0.2.3dev-2.fc27.x86_64.rpm
python-fpylll-0.2.3dev-2.fc27.src.rpm
python2-fpylll.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
python2-fpylll.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
python3-fpylll.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
python3-fpylll.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
python-fpylll.src: W: spelling-error Summary(en_US) fplll -> fillip
python-fpylll.src: W: spelling-error %description -l en_US fplll -> fillip
4 packages and 0 specfiles checked; 0 errors, 6 warnings.
Requires
--------
python2-fpylll (rpmlib, GLIBC filtered):
libc.so.6()(64bit)
libfplll.so.2()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgmp.so.10()(64bit)
libm.so.6()(64bit)
libmpfr.so.4()(64bit)
libpari-gmp.so.5()(64bit)
libpthread.so.0()(64bit)
libpython2.7.so.1.0()(64bit)
libqd.so.0()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
python(abi)
rtld(GNU_HASH)
python3-fpylll (rpmlib, GLIBC filtered):
libc.so.6()(64bit)
libfplll.so.2()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgmp.so.10()(64bit)
libm.so.6()(64bit)
libmpfr.so.4()(64bit)
libpari-gmp.so.5()(64bit)
libpthread.so.0()(64bit)
libpython3.6m.so.1.0()(64bit)
libqd.so.0()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
python(abi)
rtld(GNU_HASH)
python-fpylll-debuginfo (rpmlib, GLIBC filtered):
Provides
--------
python2-fpylll:
python-fpylll
python-fpylll(x86-64)
python2-fpylll
python2-fpylll(x86-64)
python2.7dist(fpylll)
python2dist(fpylll)
python3-fpylll:
python3-fpylll
python3-fpylll(x86-64)
python3.6dist(fpylll)
python3dist(fpylll)
python-fpylll-debuginfo:
python-fpylll-debuginfo
python-fpylll-debuginfo(x86-64)
Unversioned so-files
--------------------
python2-fpylll: /usr/lib64/python2.7/site-packages/fpylll/config.so
python2-fpylll: /usr/lib64/python2.7/site-packages/fpylll/fplll/bkz.so
python2-fpylll: /usr/lib64/python2.7/site-packages/fpylll/fplll/bkz_param.so
python2-fpylll: /usr/lib64/python2.7/site-packages/fpylll/fplll/enumeration.so
python2-fpylll: /usr/lib64/python2.7/site-packages/fpylll/fplll/gso.so
python2-fpylll:
/usr/lib64/python2.7/site-packages/fpylll/fplll/integer_matrix.so
python2-fpylll: /usr/lib64/python2.7/site-packages/fpylll/fplll/lll.so
python2-fpylll: /usr/lib64/python2.7/site-packages/fpylll/fplll/pruner.so
python2-fpylll: /usr/lib64/python2.7/site-packages/fpylll/fplll/svpcvp.so
python2-fpylll: /usr/lib64/python2.7/site-packages/fpylll/fplll/wrapper.so
python2-fpylll: /usr/lib64/python2.7/site-packages/fpylll/gmp/pylong.so
python2-fpylll: /usr/lib64/python2.7/site-packages/fpylll/io.so
python2-fpylll: /usr/lib64/python2.7/site-packages/fpylll/numpy.so
python2-fpylll: /usr/lib64/python2.7/site-packages/fpylll/util.so
python3-fpylll:
/usr/lib64/python3.6/site-packages/fpylll/config.cpython-36m-x86_64-linux-gnu.so
python3-fpylll:
/usr/lib64/python3.6/site-packages/fpylll/fplll/bkz.cpython-36m-x86_64-linux-gnu.so
python3-fpylll:
/usr/lib64/python3.6/site-packages/fpylll/fplll/bkz_param.cpython-36m-x86_64-linux-gnu.so
python3-fpylll:
/usr/lib64/python3.6/site-packages/fpylll/fplll/enumeration.cpython-36m-x86_64-linux-gnu.so
python3-fpylll:
/usr/lib64/python3.6/site-packages/fpylll/fplll/gso.cpython-36m-x86_64-linux-gnu.so
python3-fpylll:
/usr/lib64/python3.6/site-packages/fpylll/fplll/integer_matrix.cpython-36m-x86_64-linux-gnu.so
python3-fpylll:
/usr/lib64/python3.6/site-packages/fpylll/fplll/lll.cpython-36m-x86_64-linux-gnu.so
python3-fpylll:
/usr/lib64/python3.6/site-packages/fpylll/fplll/pruner.cpython-36m-x86_64-linux-gnu.so
python3-fpylll:
/usr/lib64/python3.6/site-packages/fpylll/fplll/svpcvp.cpython-36m-x86_64-linux-gnu.so
python3-fpylll:
/usr/lib64/python3.6/site-packages/fpylll/fplll/wrapper.cpython-36m-x86_64-linux-gnu.so
python3-fpylll:
/usr/lib64/python3.6/site-packages/fpylll/gmp/pylong.cpython-36m-x86_64-linux-gnu.so
python3-fpylll:
/usr/lib64/python3.6/site-packages/fpylll/io.cpython-36m-x86_64-linux-gnu.so
python3-fpylll:
/usr/lib64/python3.6/site-packages/fpylll/numpy.cpython-36m-x86_64-linux-gnu.so
python3-fpylll:
/usr/lib64/python3.6/site-packages/fpylll/util.cpython-36m-x86_64-linux-gnu.so
Source checksums
----------------
https://github.com/fplll/fpylll/releases/download/0.2.3dev/fpylll-0.2.3de...
:
CHECKSUM(SHA256) this package :
f5652639ba87c90ca449277bf2d55e8adda06fe0ecd8e319ec9d2d88cf8f6340
CHECKSUM(SHA256) upstream package :
f5652639ba87c90ca449277bf2d55e8adda06fe0ecd8e319ec9d2d88cf8f6340
https://raw.githubusercontent.com/fplll/fpylll/master/LICENSE :
CHECKSUM(SHA256) this package :
c03cea027b4b40e4402fabd08557736727ec3d5bc54ad64ab6472de432198cad
CHECKSUM(SHA256) upstream package :
c03cea027b4b40e4402fabd08557736727ec3d5bc54ad64ab6472de432198cad
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1445412 -m fedora-rawhide-x86_64 -o
--no-cleanup-after --no-clean --uniqueext=fpylll
Buildroot used: fedora-rawhide-x86_64-fpylll
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:15 a.m.
New subject: [Bug 1445412] Review Request: python-fpylll - A Python wrapper for
fplll
https://bugzilla.redhat.com/show_bug.cgi?id=1445412
--- Comment #6 from Paulo Andrade <paulo.cesar.pereira.de.andrade(a)gmail.com> ---
Thanks for the review!
The test case is completely rewritten in latest versions
(master branch or 0.2.4dev) where the patch would not make
sense.
The package is not the latest version (0.2.3dev), but the
one required by sagemath 7.6 (to be updated).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:29 p.m.
New subject: [Bug 1445412] Review Request: python-fpylll - A Python wrapper for
fplll
https://bugzilla.redhat.com/show_bug.cgi?id=1445412
--- Comment #7 from Gwyn Ciesla <limburgher(a)gmail.com> ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-fpylll
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:42 a.m.
New subject: [Bug 1445412] Review Request: python-fpylll - A Python wrapper for
fplll
https://bugzilla.redhat.com/show_bug.cgi?id=1445412
--- Comment #8 from Fedora Update System <updates(a)fedoraproject.org> ---
python-fpylll-0.2.3dev-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e21d9975a2
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:42 a.m.
New subject: [Bug 1445412] Review Request: python-fpylll - A Python wrapper for
fplll
https://bugzilla.redhat.com/show_bug.cgi?id=1445412
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |MODIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:18 p.m.
New subject: [Bug 1445412] Review Request: python-fpylll - A Python wrapper for
fplll
https://bugzilla.redhat.com/show_bug.cgi?id=1445412
Bug 1445412 depends on bug 1445411, which changed state.
Bug 1445411 Summary: Review Request: python-cysignals - Interrupt and signal handling for
Cython
https://bugzilla.redhat.com/show_bug.cgi?id=1445411
What |Removed |Added
----------------------------------------------------------------------------
Status|CLOSED |ON_QA
Resolution|RAWHIDE |---
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:19 p.m.
New subject: [Bug 1445412] Review Request: python-fpylll - A Python wrapper for
fplll
https://bugzilla.redhat.com/show_bug.cgi?id=1445412
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System <updates(a)fedoraproject.org> ---
python-fpylll-0.2.3dev-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e21d9975a2
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:54 p.m.
New subject: [Bug 1445412] Review Request: python-fpylll - A Python wrapper for
fplll
https://bugzilla.redhat.com/show_bug.cgi?id=1445412
Bug 1445412 depends on bug 1445411, which changed state.
Bug 1445411 Summary: Review Request: python-cysignals - Interrupt and signal handling for
Cython
https://bugzilla.redhat.com/show_bug.cgi?id=1445411
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Resolution|--- |ERRATA
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:54 p.m.
New subject: [Bug 1445412] Review Request: python-fpylll - A Python wrapper for
fplll
https://bugzilla.redhat.com/show_bug.cgi?id=1445412
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Resolution|--- |ERRATA
Last Closed| |2017-07-07 18:54:45
--- Comment #10 from Fedora Update System <updates(a)fedoraproject.org> ---
python-fpylll-0.2.3dev-2.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2501
days inactive
2574
days old
package-review@lists.fedoraproject.org
15 comments
1 participants
participants (1)
-
bugzilla＠redhat.com