Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226532
Summary: Merge Review: vorbis-tools Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: besfahbo@redhat.com
Fedora Merge Review: vorbis-tools
http://cvs.fedora.redhat.com/viewcvs/devel/vorbis-tools/ Initial Owner: besfahbo@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: vorbis-tools
https://bugzilla.redhat.com/show_bug.cgi?id=226532
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |j.w.r.degoede@hhs.nl
------- Additional Comments From j.w.r.degoede@hhs.nl 2007-11-14 10:15 EST ------- To all interested reviewers, I've become a vorbis-tools co-maitainer recently and I would like to push gnome-games through its merge review. I've taken an initial look and the specfile looks ok. Please review and tell me what needs fixing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: vorbis-tools
https://bugzilla.redhat.com/show_bug.cgi?id=226532
michel.sylvan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |michel.sylvan@gmail.com
------- Additional Comments From michel.sylvan@gmail.com 2007-11-14 10:29 EST ------- Will be able to do the review in a couple of hours. Hans, do you want to officially assign yourself the bug?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: vorbis-tools
https://bugzilla.redhat.com/show_bug.cgi?id=226532
------- Additional Comments From j.w.r.degoede@hhs.nl 2007-11-14 10:41 EST ------- (In reply to comment #2)
Will be able to do the review in a couple of hours. Hans, do you want to officially assign yourself the bug?
Normal reviews are always assigned to the reviewer, not the one requesting the review, is this different for merge reviews?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: vorbis-tools
https://bugzilla.redhat.com/show_bug.cgi?id=226532
michel.sylvan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |michel.sylvan@gmail.com Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From michel.sylvan@gmail.com 2007-11-14 17:39 EST ------- Ah, I mean the reporter, but I just realized it cannot be changed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: vorbis-tools
https://bugzilla.redhat.com/show_bug.cgi?id=226532
------- Additional Comments From michel.sylvan@gmail.com 2007-11-14 17:51 EST ------- - License field needs updating (should be GPLv2) - Provides and Obsoletes should probably be versioned
Provides: oldpackagename = $provEVR Obsoletes: oldpackagename < $obsEVR
- This is probably cosmetic, but rpmlint suggests that the summary should not end with a period.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: vorbis-tools
https://bugzilla.redhat.com/show_bug.cgi?id=226532
------- Additional Comments From j.w.r.degoede@hhs.nl 2007-11-15 03:34 EST ------- Thanks for the comments sofar, I'm waiting with doing a new revision until you've done a complete review, so that hopefully I can get everything fixed in one iteration.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: vorbis-tools
https://bugzilla.redhat.com/show_bug.cgi?id=226532
------- Additional Comments From michel.sylvan@gmail.com 2007-11-15 13:18 EST ------- Here's the full review; didn't find anything else to fix.
MUST failed: • license field accurate
passed: • rpmlint: OK • package name: OK • spec file name: OK • package guideline-compliant: OK • license complies with guidelines: OK • license file not deleted: OK • spec in US English: OK • spec legible: OK • source matches upstream: OK • builds under >= 1 archs, others excluded: OK • build dependencies complete: OK • locales handled using %find_lang, no %{_datadir}/locale: OK • library -> ldconfig: NA • relocatable: give reason: NA • own all directories: OK • no dupes in %files: OK • permission: OK • %clean RPM_BUILD_ROOT: OK • macros used consistently: OK • Package contains code: OK • large docs => -doc: NA • doc not runtime dependent: NA • headers in -devel: NA • static in -static: NA • if contains *.pc, req pkgconfig: NA • if libfiles are suffixed, the non-suffixed goes to devel: NA • devel requires versioned base package: NA • desktop file uses desktop-file-install: NA • clean buildroot before install: OK • filenames UTF-8: OK
SHOULD failed: • other subpackages should require versioned base Obsoletes/Provides should be versioned as well • summary ending with period
passed: • if license text missing, ask upstream to include it: NA • desc and summary contain translations if available • package build in mock on all architectures: OK • package functioned as described: OK • scriplets are sane: OK • if main pkg is development-wise, pkgconfig can go in main package: NA • require package not files: OK
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: vorbis-tools
https://bugzilla.redhat.com/show_bug.cgi?id=226532
------- Additional Comments From j.w.r.degoede@hhs.nl 2007-11-15 14:03 EST ------- Ok,
1:1.1.1.svn20070412-5 has just been committed to CVS and is now building, this fixes: • license field accurate • other subpackages should require versioned base Obsoletes/Provides should be versioned as well • summary ending with period
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: vorbis-tools
https://bugzilla.redhat.com/show_bug.cgi?id=226532
michel.sylvan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE Flag|fedora-review? |fedora-review+
package-review@lists.fedoraproject.org