Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=659895
Jussi Lehtola <jussi.lehtola(a)iki.fi> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |jussi.lehtola(a)iki.fi
AssignedTo|nobody(a)fedoraproject.org |jussi.lehtola(a)iki.fi
Flag| |fedora-review+
--- Comment #1 from Jussi Lehtola <jussi.lehtola(a)iki.fi> 2010-12-05 05:54:41 EST
---
rpmlint output:
makedepf90.src: W: spelling-error %description -l en_US cpp -> cop, cp, pp
makedepf90.src: W: spelling-error %description -l en_US gcc -> cc, acc, g cc
makedepf90.x86_64: W: spelling-error %description -l en_US cpp -> cop, cp, pp
makedepf90.x86_64: W: spelling-error %description -l en_US gcc -> cc, acc, g cc
3 packages and 0 specfiles checked; 0 errors, 4 warnings.
MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK
- IMHO using macros for rm and make is a bit silly, but it's not disallowed.
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
514a32147e956264ac5e60cc12fd5f5d makedepf90-2.8.8.tar.gz
514a32147e956264ac5e60cc12fd5f5d ../SOURCES/makedepf90-2.8.8.tar.gz
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. ~OK
- Please add INSTALL="install -p" to make install so that time stamp of the man
page is preserved.
MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. N/A
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK
EPEL: Clean section exists. OK
EPEL: Buildroot cleaned before install. OK
EPEL: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A
Package APPROVED. Please check the time stamp issue before importing to git.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.