https://bugzilla.redhat.com/show_bug.cgi?id=1132670 Vít Ondruch <vondruch(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |vondruch(a)redhat.com Assignee|nobody(a)fedoraproject.org |vondruch(a)redhat.com Flags| |fedora-review? --- Comment #1 from Vít Ondruch <vondruch(a)redhat.com&gt; --- I'll take this for a review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1132670 --- Comment #3 from Mo Morsi <mmorsi(a)redhat.com&gt; --- Thx for review. Updated: Spec: https://mmorsi.fedorapeople.org/staging/rubygem-compass-core.spec SRPM: http://mmorsi.fedorapeople.org/staging/rubygem-compass-core-1.0.1-2.fc20.... Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7476096 The upstream compass test suite isn't minitest5 compatible yet, filed a few PR's and will update the latest to the most recent master shortly. After that we can backport the updates to 1.0.1 and should be able to include the test suite in compass. See this issue regarding the md5 algorithm: https://github.com/Compass/compass/pull/1266 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1132670 Mo Morsi <mmorsi(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1142508 --- Comment #5 from Mo Morsi <mmorsi(a)redhat.com&gt; --- Spec: https://mmorsi.fedorapeople.org/staging/rubygem-compass-core.spec SRPM: http://mmorsi.fedorapeople.org/staging/rubygem-compass-core-1.0.1-3.fc20.... Updated to run tests. Updated test suite pulls in rubygem-true, which has been seperately packaged / submitted. Minitest5 patch backported. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1142508 [Bug 1142508] Review Request: rubygem-true - Testing framework for Sass libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1132670 Vít Ondruch <vondruch(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from Vít Ondruch <vondruch(a)redhat.com&gt; --- * Test suite - I'd suggest to execute the test suite using following command: ruby -Ilib:test/units \ -e 'Dir.glob "./test/units/*_test.rb", &method(:require)' - Please expand the test suite in %check section. This way you keep in RPM just the content which was originally shipped by upstream. This also avoids several rpmlint complains. - It seems that the timecop and true are needed just for integration tests. Since there is circular dependency between true and compass, I'd suggest to use boostrap macro [1] to disable the integration tests during bootstrap. Otherwise the package is legit => APPROVED [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Bootstrapping -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1132670 Mo Morsi <mmorsi(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs? --- Comment #8 from Mo Morsi <mmorsi(a)redhat.com&gt; --- New Package SCM Request ======================= Package Name: rubygem-compass-core Short Description: The Compass core stylesheet library Upstream URL: http://rubygems.org/gems/compass-core Owners: mmorsi Branches: f20 f21 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1132670 --- Comment #9 from Jon Ciesla <limburgher(a)gmail.com&gt; --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component