Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vtkdata - Example data file for VTK https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199406 ------- Additional Comments From Axel.Thimm(a)ATrpms.net 2006-07-19 08:26 EST ------- Spec URL: http://people.atrpms.net/~athimm/fedorasubmit/vtk/vtkdata.spec SRPM URL: http://people.atrpms.net/~athimm/fedorasubmit/vtk/vtkdata-5.0.1-4.at.src.rpm * Wed Jul 19 2006 Axel Thimm <Axel.Thimm(a)ATrpms.net&gt; - 5.0.1-4 - Fix some permissions. See bug 199405 comment 1, rpmlint is much cleaner now. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vtkdata - Example data file for VTK https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199406 ------- Additional Comments From Axel.Thimm(a)ATrpms.net 2006-07-20 04:38 EST ------- One of recent features of vtk was to allow for several concurrent vtkdata installs due to user demand and be able to switch back and forth. I don't intend to ever have a second package coinstall a different data set, but if the user wants to do so, I'd like to avoid any conflicts and be verbose on filesytem level about what is actually on the system. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vtkdata - Example data file for VTK https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199406 ------- Additional Comments From Axel.Thimm(a)ATrpms.net 2006-07-20 06:56 EST ------- How strongly the application and its data are tied varies in vtk's past. Currently it is quite high, as both got a simultaneous minor release. (In reply to comment #4) Now I'm going to break out in tears ;) Ignoring actual user demand which is acknowledged by upstream development and even implemneted isn't really constructive. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vtkdata - Example data file for VTK https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199406 bugzilla(a)redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium ------- Additional Comments From Axel.Thimm(a)ATrpms.net 2007-04-22 09:55 EST ------- http://dl.atrpms.net/all/vtkdata-5.0.3-6.at.src.rpm http://dl.atrpms.net/all/vtkdata.spec * Sun Apr 15 2007 Axel Thimm <Axel.Thimm(a)ATrpms.net&gt; - 5.0.3-6 - Update to 5.0.3. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vtkdata - Example data file for VTK https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199406 ------- Additional Comments From ed(a)eh3.com 2007-05-28 22:23 EST ------- GOOD: + spec is simple, legible, follows naming guidelines, etc. + rpmlint reports only a few ignore-able warnings: W: vtkdata no-%prep-section W: vtkdata no-%build-section W: vtkdata no-documentation + builds in mock on FC6 x86_64 + permissions and dir ownership looks good to me + license matches that of VTK -- good NEEDSWORK: + the srpm in comment #8 seems to be a broken link so I could not verify that source matches upstream -- but I do not consider that to be a blocker as I was able to build a working package from the spec file (which was not a broken link) In regards to comment #6, I don't think it matters whether the directory is versioned or not. If Axel would like to version it then I think that's OK -- I just don't see how it voilates any of the guidelines or does any real harm. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vtkdata - Example data file for VTK https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199406 ed(a)eh3.com changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ ------- Additional Comments From ed(a)eh3.com 2007-06-01 09:38 EST ------- Ooops! Thank you for pointing that out. :-) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vtkdata - Example data file for VTK https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199406 kevin(a)tummy.com changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+ ------- Additional Comments From kevin(a)tummy.com 2007-06-03 14:38 EST ------- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vtkdata - Example data file for VTK https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199406 ------- Additional Comments From axel.thimm(a)atrpms.net 2007-08-02 06:24 EST ------- The only thing I don't really like is the disttag in the name. Even though I'm a disttag fan this package is distro-agnostic and should be used w/o rebuilding on any other distro. But that isn't reason enough to rebuild this package and repush it, I'll just drop the disttag on the next update. (FWIW I forgot to remove the disttag, as the disttag is used at ATrpms to denote repotag&disttag and is set to only have a repotag in this case) Thanks Ed for reviewing and Kevin for cvs work :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vtkdata - Example data file for VTK https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199406 updates(a)fedoraproject.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |ERRATA Fixed In Version| |5.0.3-6.fc7 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.