Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcircuit - Electronic circuit schematic drawing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203774 mtasaka(a)ioa.s.u-tokyo.ac.jp changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka(a)ioa.s.u-tokyo.ac.jp ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2006-08-24 01:43 EST ------- Well, as far as I check this rpm very quickly, the packaging issue is almost okay. # rpmlint is clean. # mock build okay. * Source: http://xcircuit.ece.jhu.edu/... They say that http://xcircuit.ece.jhu.edu/ is obsolete, and I can find this source on: http://opencircuitdesign.com/xcircuit/archive/xcircuit-3.4.26.tgz . * %patch0 -p0 -b . For kindness, please add some suffix. * %post if [ -x %{_bindir}/gtk-update-icon-cache ]; then Require %{_bindir}/gtk-update-icon-cache on post and postun. * The included file /usr/lib/xcircuit-3.4/man/xcircuit.1 is necessary? * I don't know well how to use this, however, when I launch this by just typing "xcircuit &", then I see the following error message: loading history file ... 1 events added error in slave eval: image type "xpm" doesn't exist Main console display active (Tcl8.4.13 / Tk8.4.13) Is this okay? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcircuit - Electronic circuit schematic drawing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203774 mtasaka(a)ioa.s.u-tokyo.ac.jp changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody(a)fedoraproject.org |mtasaka(a)ioa.s.u-tokyo.ac.jp OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2006-08-25 01:17 EST ------- Assigning to me. * manual file issue Well, I should have explained why I asked for this manual. My build log by using mock says: ...... /usr/bin/install -c -m 644 lib/xcircuit.1 /var/tmp/xcircuit-3.4.26-2.fc6-root-mockbuild/usr/lib/xcircuit-3.4/man/xcircuit.1 ...... /usr/bin/install -c -m 644 './lib/xcircuit.1' '/var/tmp/xcircuit-3.4.26-2.fc6-root-mockbuild/usr/share/man/man1/xcircuit.1' ...... So, actually the file /usr/lib/xcircuit-3.4/man/xcircuit.1 and /usr/share/man/man1/xcircuit.1.gz are the same. So I mentioned that /usr/lib/xcircuit-3.4/man/xcircuit.1 may be unnecessary. * desktop-file-install --vendor fedora \ -add-category Engineering \ This requires "update-desktop-database /usr/share/applications" on %post and %postun stage and adding %{_bindir}/update-desktop-database to Requires(post), Requires(postun) . Now /usr/share/applications/fedora-xcircuit.desktop says: --------------------- [Desktop Entry] Encoding=UTF-8 Name=XCircuit Exec=xcircuit Icon=xcircuit Type=Application Terminal=false GenericName=xcircuit Categories=Qt;KDE;Education;Science;X-Fedora;Engineering; X-Desktop-File-Install-Version=0.10 --------------------- Does Qt or KDE required? I still gain the following error message: --------------------- loading history file ... 1 events added error in slave eval: image type "xpm" doesn't exist Main console display active (Tcl8.4.13 / Tk8.4.13) (xcircuit) 2 % --------------------- Is this message related to Qt or KDE? Please check why I get this message or tell me what other information you want to diagnose this. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcircuit - Electronic circuit schematic drawing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203774 ------- Additional Comments From cgoorah(a)yahoo.com.au 2006-08-25 03:45 EST ------- Updated: Spec URL: http://chitlesh.funpic.de/rpm/xcircuit.spec SRPM URL: http://chitlesh.funpic.de/rpm/xcircuit-3.4.26-3.src.rpm Since I'm unable to recreate the "image type "xpm" doesn't exist" error, can you test the patch I've included ? %changelog - 3.4.26-3 - Fixed xcircuit.desktop and removed unneccessary installation for manual - Used update-desktop-database in %%post and %%postun - patch for "image type "xpm" doesn't exist" -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcircuit - Electronic circuit schematic drawing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203774 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2006-08-25 04:56 EST ------- Created an attachment (id=134899) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134899&action=...) Build log of 3.4.26-2 withOUT mock Build log of 3.4.26-2 with normal rpmbuild. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcircuit - Electronic circuit schematic drawing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203774 ------- Additional Comments From cgoorah(a)yahoo.com.au 2006-08-25 05:15 EST ------- In accordance to http://opencircuitdesign.com/pipermail/xcircuit-dev/2006/000232.html, I've patched the wrapper.tcl. If this doesn't help I'll add libXpm-devel and zlib-devel as BR -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcircuit - Electronic circuit schematic drawing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203774 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2006-08-25 08:01 EST ------- Well, I temporally downgraded yum to 2.9.3-2 to use mock. (In reply to comment #8) Well, mock build 3.4.26-3.fc6 still bear the same error, no icons appear on left side, while normal rpmbuild 3.4.26-3 seems okay. Try adding some BR. BTW, %SOURCE2 (xcircuit.png) is something that one can get from some URL? If so, specify the URL where xcircuit.png exists. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcircuit - Electronic circuit schematic drawing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203774 ------- Additional Comments From cgoorah(a)yahoo.com.au 2006-08-25 10:58 EST ------- What do you mean? in the kmenu/gnome menu ? The original png is from http://opencircuitdesign.com/xcircuit/archive/xcircuit.xpm but I've changed it to 32x32 in order to use you it in the kmenu/gnome menu -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcircuit - Electronic circuit schematic drawing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203774 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2006-08-25 11:26 EST ------- Created an attachment (id=134930) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134930&action=...) snapshot of xcircuit build by usual rpmbuild snapshot of 3.4.26-3 rebuild by usual rpmbuild. I can see some colorful icons on the right side, perhaps which is expected. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcircuit - Electronic circuit schematic drawing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203774 ------- Additional Comments From karlthered(a)gmail.com 2006-08-25 11:37 EST ------- I tested the rpm, it worked fine on x86. I got the same result as here. https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134930&action=... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcircuit - Electronic circuit schematic drawing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203774 ------- Additional Comments From cgoorah(a)yahoo.com.au 2006-08-25 15:19 EST ------- Updated: Spec URL: http://chitlesh.funpic.de/rpm/xcircuit.spec SRPM URL: http://chitlesh.funpic.de/rpm/xcircuit-3.4.26-5.src.rpm - Added libXpm-devel as BR to prevent "image type "xpm" doesn't exist" error -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcircuit - Electronic circuit schematic drawing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203774 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2006-08-26 03:14 EST ------- Still I am checking...... Remove windows related files, i.e. please remove /usr/share/doc/xcircuit-3.4.26/examples/win32 . -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcircuit - Electronic circuit schematic drawing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203774 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2006-08-26 08:27 EST ------- Fully checked. The remained things are: * Using %{buildroot} and %{optflags} vs $RPM_BUILD_ROOT and $RPM_OPT_FLAGS You use both %{_builddir} and $RPM_BUILD_ROOT . Choose one (although this is very cosmetic). - All is okay. Other packaging issues: * %{__rm} %{_builddir}/%{name}-%{version}/examples/.xcircuitrc The explicit description of the directory %{_builddir}/%{name}-%{version}/ is not necessary because the working directory is that directory. * Well, you removed /usr/share/man/man1/xcircuit.1.gz and decided to install /usr/lib/xcircuit-3.4/man/xcircuit.1 , right? However, by doing this the simple use of "man xcircuit" no longer works, I have to explicitly point to the manual file "man /usr/lib/xcircuit-3.4/man/xcircuit.1", which is unpleasant to me. Could you explain why? Other functional issues: - All is okay. xcircuit surely works. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcircuit - Electronic circuit schematic drawing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203774 mtasaka(a)ioa.s.u-tokyo.ac.jp changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2006-08-26 11:27 EST ------- Sorry, one thing I missed to notice.... %{__cp} %{SOURCE2} %{buildroot}%{_datadir}/..... Please use %{__cp} -p to keep timestamp. Aside for above, nothing to be fixed is left. Now I am pleased to say that this package (xcircuit) is APPROVED. ---------------------------------------------------- BTW, if you don't mind, would you review my package (bug 204112) ? (this package is usually for Japanese people using a BBS known to Japanese people) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcircuit - Electronic circuit schematic drawing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203774 cgoorah(a)yahoo.com.au changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |NEW Keywords| |Reopened Resolution|NEXTRELEASE | ------- Additional Comments From cgoorah(a)yahoo.com.au 2006-08-26 13:59 EST ------- The build of x86_64 is failing :( + /bin/rm /var/tmp/xcircuit-3.4.26-9.fc5-root-mockbuild/usr/lib64/xcircuit-3.4/man/xcircuit.1 /bin/rm: cannot remove `/var/tmp/xcircuit-3.4.26-9.fc5-root-mockbuild/usr/lib64/xcircuit-3.4/man/xcircuit.1': No such file or directory error: Bad exit status from /var/tmp/rpm-tmp.6460 (%install) http://buildsys.fedoraproject.org/build-status/job.psp?uid=14606 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcircuit - Electronic circuit schematic drawing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203774 ------- Additional Comments From cgoorah(a)yahoo.com.au 2006-08-26 14:50 EST ------- + /bin/rm /var/tmp/xcircuit-3.4.26-12.fc5-root-mockbuild/usr/lib/xcircuit-3.4/man/xcircuit.1 As you can see this one is OK + chmod -x /var/tmp/xcircuit-3.4.26-12.fc5-root-mockbuild/usr/lib/xcircuit-3.4/console.tcl chmod: cannot access `/var/tmp/xcircuit-3.4.26-12.fc5-root-mockbuild/usr/lib/xcircuit-3.4/console.tcl': No such file or directory error: Bad exit status from /var/tmp/rpm-tmp.80812 (%install) but it fails here. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcircuit - Electronic circuit schematic drawing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203774 mtasaka(a)ioa.s.u-tokyo.ac.jp changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2006-08-27 01:09 EST ------- Build of xcircuit-3.4.26-16.fc{5,6} succeeded on all archs (i386, x86_64, ppc). Please check: http://buildsys.fedoraproject.org/build-status/job.psp?uid=14637 http://buildsys.fedoraproject.org/build-status/job.psp?uid=14638 Closing this bug as CLOSED NEXTRELEASE. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcircuit - Electronic circuit schematic drawing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203774 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2006-09-04 12:33 EST ------- Chitlesh, owner.list entry for xcircuit has a typo. It says "xcicuit". Please fix owner.list . http://fedoraproject.org/wiki/Extras/PackageStatus -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcircuit - Electronic circuit schematic drawing program https://bugzilla.redhat.com/show_bug.cgi?id=203774 bugzilla(a)redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=203774 Kevin Fenzi <kevin(a)tummy.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+ --- Comment #34 from Kevin Fenzi <kevin(a)tummy.com&gt; 2008-11-10 11:57:04 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.