9:11 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1434003
Bug ID: 1434003
Summary: Review Request: tilix - Tiling terminal emulator
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: klember(a)redhat.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: https://kalev.fedorapeople.org/tilix.spec
SRPM URL: http://kalev.fedorapeople.org/tilix-1.5.4-1.fc26.src.rpm
Description:
Tilix is a tiling terminal emulator with the following features:
- Layout terminals in any fashion by splitting them horizontally or vertically
- Terminals can be re-arranged using drag and drop both within and between
windows
- Terminals can be detached into a new window via drag and drop
- Input can be synchronized between terminals so commands typed in one
terminal are replicated to the others
- The grouping of terminals can be saved and loaded from disk
- Terminals support custom titles
- Color schemes are stored in files and custom color schemes can be created by
simply creating a new file
- Transparent background
- Supports notifications when processes are completed out of view
The application was written using GTK 3 and an effort was made to conform to
GNOME Human Interface Guidelines (HIG).
Fedora Account System Username: kalev
Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=18489998
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:32 a.m.
New subject: [Bug 1434003] Review Request: tilix - Tiling terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1434003
--- Comment #1 from Kalev Lember <klember(a)redhat.com> ---
* Mon Mar 20 2017 Kalev Lember <klember(a)redhat.com> - 1.5.4-2
- Use _d_optflags and disable debug print to stderr
Spec URL: https://kalev.fedorapeople.org/tilix.spec
SRPM URL: https://kalev.fedorapeople.org/tilix-1.5.4-1.fc26.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:55 a.m.
New subject: [Bug 1434003] Review Request: tilix - Tiling terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1434003
--- Comment #2 from Gerald Nunn <gnunn(a)redhat.com> ---
I'm the author of Tilix and I've subscribed to this. If there are any questions
or issues that need resolving in the application to make this happen just let
me know.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:32 p.m.
New subject: [Bug 1434003] Review Request: tilix - Tiling terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1434003
Neal Gompa <ngompa13(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ngompa13(a)gmail.com
Assignee|nobody(a)fedoraproject.org |ngompa13(a)gmail.com
Flags| |fedora-review?
--- Comment #3 from Neal Gompa <ngompa13(a)gmail.com> ---
Taking this review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:34 p.m.
New subject: [Bug 1434003] Review Request: tilix - Tiling terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1434003
--- Comment #4 from Neal Gompa <ngompa13(a)gmail.com> ---
@Kalev,
Your SRPM and spec don't match.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:40 p.m.
New subject: [Bug 1434003] Review Request: tilix - Tiling terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1434003
--- Comment #5 from Kalev Lember <klember(a)redhat.com> ---
Sorry, I typoed the SRPM link above.
Spec URL: https://kalev.fedorapeople.org/tilix.spec
SRPM URL: https://kalev.fedorapeople.org/tilix-1.5.4-2.fc26.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1:29 p.m.
New subject: [Bug 1434003] Review Request: tilix - Tiling terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1434003
--- Comment #6 from Neal Gompa <ngompa13(a)gmail.com> ---
Created attachment 1264822
--> https://bugzilla.redhat.com/attachment.cgi?id=1264822&action=edit
licensecheck output for tilix
Some issues encountered by fedora-review:
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later)", "GPL (v3 or later)", "*No
copyright* CC
by-sa (v3.0)", "Unknown or generated", "*No copyright* MPL
(v2.0)",
"MPL (v2.0)". 126 files have unknown license. Detailed output of
licensecheck in /home/makerpm/1434003-tilix/licensecheck.txt
Please verify with upstream that the licensing is sane. licensecheck output
attached to this bug.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/metainfo
Until we migrate from /usr/share/appdata to /usr/share/metainfo completely
(tooling, dependency generators, etc.), please move metainfo/appdata files to
/usr/share/appdata.
[!]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/icons/hicolor/22x22/apps,
/usr/share/icons/hicolor/32x32/apps, /usr/share/metainfo,
/usr/share/dbus-1/services, /usr/share/icons/hicolor/24x24,
/usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/16x16,
/usr/share/icons/hicolor/48x48/apps,
/usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor,
/usr/share/icons/hicolor/24x24/apps, /usr/share/dbus-1,
/usr/share/icons/hicolor/512x512/apps, /usr/share/icons/hicolor/32x32,
/usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/22x22,
/usr/share/glib-2.0, /usr/share/icons/hicolor/512x512,
/usr/share/glib-2.0/schemas, /usr/share/icons/hicolor/48x48,
/usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor/scalable
The hicolor dir ownership can be fixed with Req on hicolor-icon-theme. The dbus
dir ownership can be fixed with Req on dbus, I believe. The glib-2.0 dirs issue
can probably be fixed by Req glib2, though that should be happening already...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:11 p.m.
New subject: [Bug 1434003] Review Request: tilix - Tiling terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1434003
--- Comment #7 from Kalev Lember <klember(a)redhat.com> ---
(In reply to Neal Gompa from comment #6)
Created attachment 1264822 [details]
licensecheck output for tilix
Some issues encountered by fedora-review:
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later)", "GPL (v3 or later)", "*No
copyright* CC
by-sa (v3.0)", "Unknown or generated", "*No copyright* MPL
(v2.0)",
"MPL (v2.0)". 126 files have unknown license. Detailed output of
licensecheck in /home/makerpm/1434003-tilix/licensecheck.txt
Please verify with upstream that the licensing is sane. licensecheck output
attached to this bug.
Thanks. I've updated the licensing breakdown, which now reads:
# The tilix source code is MPLv2.0,
# source/gx/gtk/x11.d is GPLv2+,
# source/secret is LGPLv3+,
# source/x11 and com.gexperts.Tilix.gschema.xml are GPLv3+,
# icons are CC-BY-SA.
# This makes the combined license:
License: MPLv2.0 and GPLv3+ and CC-BY-SA
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/metainfo
Until we migrate from /usr/share/appdata to /usr/share/metainfo completely
(tooling, dependency generators, etc.), please move metainfo/appdata files
to /usr/share/appdata.
Putting appdata files in that directory is completely fine. I just recently
fixed the appstream generator to work with /usr/share/metainfo. As for the
directory ownership, this belongs to the filesystem package. I've already filed
a filesystem ticket earlier today to add it,
https://bugzilla.redhat.com/show_bug.cgi?id=1434008
[!]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/icons/hicolor/22x22/apps,
/usr/share/icons/hicolor/32x32/apps, /usr/share/metainfo,
/usr/share/dbus-1/services, /usr/share/icons/hicolor/24x24,
/usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/16x16,
/usr/share/icons/hicolor/48x48/apps,
/usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor,
/usr/share/icons/hicolor/24x24/apps, /usr/share/dbus-1,
/usr/share/icons/hicolor/512x512/apps, /usr/share/icons/hicolor/32x32,
/usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/22x22,
/usr/share/glib-2.0, /usr/share/icons/hicolor/512x512,
/usr/share/glib-2.0/schemas, /usr/share/icons/hicolor/48x48,
/usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor/scalable
The hicolor dir ownership can be fixed with Req on hicolor-icon-theme. The
dbus dir ownership can be fixed with Req on dbus, I believe. The glib-2.0
dirs issue can probably be fixed by Req glib2, though that should be
happening already...
Thanks, I've added explicit dbus and hicolor-icon-theme deps. glib2 is
definitely pulled in via dependencies and there's no need to add it.
* Mon Mar 20 2017 Kalev Lember <klember(a)redhat.com> - 1.5.4-3
- Update licensing breakdown (#1434003)
- Add explicit dbus and hicolor-icon-theme deps for directory ownership
Spec URL: https://kalev.fedorapeople.org/tilix.spec
SRPM URL: https://kalev.fedorapeople.org/tilix-1.5.4-3.fc26.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:30 p.m.
New subject: [Bug 1434003] Review Request: tilix - Tiling terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1434003
--- Comment #8 from Neal Gompa <ngompa13(a)gmail.com> ---
Can you get upstream to include license files for all licenses that the project
is covered under?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:32 p.m.
New subject: [Bug 1434003] Review Request: tilix - Tiling terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1434003
--- Comment #9 from Kalev Lember <klember(a)redhat.com> ---
Probably, but this shouldn't be a blocker for the package review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:39 p.m.
New subject: [Bug 1434003] Review Request: tilix - Tiling terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1434003
--- Comment #10 from Kalev Lember <klember(a)redhat.com> ---
I've updated the spec file to make sure all the license files that upstream
ships are included.
* Mon Mar 20 2017 Kalev Lember <klember(a)redhat.com> - 1.5.4-4
- Include data/icons/LICENSE and source/x11/LICENSE as %%license (#1434003)
Spec URL: https://kalev.fedorapeople.org/tilix.spec
SRPM URL: https://kalev.fedorapeople.org/tilix-1.5.4-4.fc26.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:42 p.m.
New subject: [Bug 1434003] Review Request: tilix - Tiling terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1434003
--- Comment #11 from Neal Gompa <ngompa13(a)gmail.com> ---
Actually, it appears that glib2 isn't pulled in by *any* dependencies, so it
needs to be added as a Requires. It's also needed to ensure the file trigger
fires.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:44 p.m.
New subject: [Bug 1434003] Review Request: tilix - Tiling terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1434003
--- Comment #12 from Kalev Lember <klember(a)redhat.com> ---
It most definitely gets pulled in. Something like tilix->gtkd->gtk3->glib2 dep
chain or so.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3 p.m.
New subject: [Bug 1434003] Review Request: tilix - Tiling terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1434003
Neal Gompa <ngompa13(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #13 from Neal Gompa <ngompa13(a)gmail.com> ---
Hmm, if you're sure... Aside from this and the metainfo thing, fedora-review
and rpmlint are happy, so...
PACKAGE APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:01 p.m.
New subject: [Bug 1434003] Review Request: tilix - Tiling terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1434003
--- Comment #14 from Kalev Lember <klember(a)redhat.com> ---
Excellent. Thank you for the quick review, Neal!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:50 p.m.
New subject: [Bug 1434003] Review Request: tilix - Tiling terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1434003
--- Comment #15 from Gwyn Ciesla <limburgher(a)gmail.com> ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/tilix
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:07 a.m.
New subject: [Bug 1434003] Review Request: tilix - Tiling terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1434003
--- Comment #16 from Fedora Update System <updates(a)fedoraproject.org> ---
tilix-1.5.4-4.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2e32be8694
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:07 a.m.
New subject: [Bug 1434003] Review Request: tilix - Tiling terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1434003
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |MODIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:26 a.m.
New subject: [Bug 1434003] Review Request: tilix - Tiling terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1434003
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|MODIFIED |ON_QA
--- Comment #17 from Fedora Update System <updates(a)fedoraproject.org> ---
tilix-1.5.4-4.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2e32be8694
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:20 p.m.
New subject: [Bug 1434003] Review Request: tilix - Tiling terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1434003
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Resolution|--- |ERRATA
Last Closed| |2017-04-01 13:20:16
--- Comment #18 from Fedora Update System <updates(a)fedoraproject.org> ---
tilix-1.5.4-4.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2584
days inactive
2596
days old
package-review@lists.fedoraproject.org
19 comments
1 participants
participants (1)
-
bugzilla＠redhat.com