https://bugzilla.redhat.com/show_bug.cgi?id=1178528
Bug ID: 1178528 Summary: Review Request: python-Send2Trash - Python module to send files to trash natively Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: chkr@plauener.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://chkr.fedorapeople.org/review/python-Send2Trash.spec SRPM URL: https://chkr.fedorapeople.org/review/python-Send2Trash-1.3.0-1.fc20.src.rpm Description: Send2Trash is a small package that sends files to the Trash (or Recycle Bin) natively and on all platforms.
Fedora Account System Username: chkr
Comments: This package is required to debundle the Send2Trash module from the anki package: https://bugzilla.redhat.com/show_bug.cgi?id=1173410
https://bugzilla.redhat.com/show_bug.cgi?id=1178528
Christian Krause chkr@plauener.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |173410
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=173410 [Bug 173410] Elinks translations not in UTF-8
https://bugzilla.redhat.com/show_bug.cgi?id=1178528
Christian Krause chkr@plauener.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|173410 |1173410
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=173410 [Bug 173410] Elinks translations not in UTF-8 https://bugzilla.redhat.com/show_bug.cgi?id=1173410 [Bug 1173410] anki bundles the send2trash python module
https://bugzilla.redhat.com/show_bug.cgi?id=1178528
Kevin Kofler kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |python-Send2Trash, | |python-send2trash
--- Comment #1 from Kevin Kofler kevin@tigcc.ticalc.org --- Do we really want to use mixed case in the package name? The module name to import from Python is all lowercase, the GitHub project also uses all lowercase, only the pypi page uses mixed case.
https://bugzilla.redhat.com/show_bug.cgi?id=1178528
--- Comment #2 from Christian Krause chkr@plauener.de --- I just checked: other python packages, e.g. python-werkzeug, are in the same category:
- mixed-case tarball name - mixed-case directory in tarball - mixed-case in egg-info
- but lowercase package name
I'll change the package name in the next few days unless there are any objections.
https://bugzilla.redhat.com/show_bug.cgi?id=1178528
--- Comment #3 from Christian Krause chkr@plauener.de --- Here are the update files using a lowercase package name:
Spec URL: https://chkr.fedorapeople.org/review/python-send2trash.spec SRPM URL: https://chkr.fedorapeople.org/review/python-send2trash-1.3.0-1.fc20.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1178528
William Moreno williamjmorenor@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |williamjmorenor@gmail.com Assignee|nobody@fedoraproject.org |williamjmorenor@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1178528
--- Comment #4 from William Moreno williamjmorenor@gmail.com --- You must update your spec file:
1. Provide python2 and python3 subpackages. 2. Update the python macros 3. Use the python-provides macro 4. Ping upstream about include the license text in the tarball
https://bugzilla.redhat.com/show_bug.cgi?id=1178528
--- Comment #5 from Eduardo Mayorga e@mayorgalinux.com --- (In reply to William Moreno from comment #4)
- Update the python macros
By this I think he meant to use the %py2_build, %py3_build, %py2_install, and %py3_install macros, as shown here: https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
https://bugzilla.redhat.com/show_bug.cgi?id=1178528
William Moreno williamjmorenor@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |chkr@plauener.de Flags| |needinfo?(chkr@plauener.de)
--- Comment #6 from William Moreno williamjmorenor@gmail.com --- Any update here?
https://bugzilla.redhat.com/show_bug.cgi?id=1178528
William Moreno williamjmorenor@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|williamjmorenor@gmail.com | Assignee|williamjmorenor@gmail.com |nobody@fedoraproject.org Flags|fedora-review? | |needinfo?(chkr@plauener.de) |
https://bugzilla.redhat.com/show_bug.cgi?id=1178528
Kevin Kofler kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |python-Send2Trash - Python |python-send2trash - Python |module to send files to |module to send files to |trash natively |trash natively
https://bugzilla.redhat.com/show_bug.cgi?id=1178528
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@redhat.com
--- Comment #7 from Miro Hrončok mhroncok@redhat.com --- I need this package. Will open a new review request, given there's no reply to a needinfo for 2 years.
https://bugzilla.redhat.com/show_bug.cgi?id=1178528
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed| |2018-01-09 06:59:14
--- Comment #8 from Miro Hrončok mhroncok@redhat.com ---
*** This bug has been marked as a duplicate of bug 1532588 ***
package-review@lists.fedoraproject.org