https://bugzilla.redhat.com/show_bug.cgi?id=1462412
Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
CC| |zbyszek(a)in.waw.pl
Assignee|nobody(a)fedoraproject.org |zbyszek(a)in.waw.pl
Flags| |fedora-review+
--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
rpmlint:
tworld-data.noarch: E: incorrect-fsf-address
/usr/share/licenses/tworld-data/COPYING
Who cares? ;)
tworld.x86_64: W: manual-page-warning /usr/share/man/man6/tworld.6.gz 2:
warning: macro `LO' not defined
The page seems to display OK, so this can be ignored.
4 packages and 0 specfiles checked; 2 errors, 8 warnings.
make %{?_smp_mflags} → %make_build, optionally.
$ appstream-util validate /usr/share/appdata/tworld.appdata.xml
/usr/share/appdata/tworld.appdata.xml: FAILED:
• tag-invalid : <metadata_license> is not valid [CC-BY-SA-3.04.0]
• tag-invalid : <project_license> is not valid [GPLv2+]SPDX ID
'GPLv2+' unknown
• tag-missing : <translation> not specified
• tag-missing : <update_contact> is not present
• attribute-invalid : <screenshot> width too small
[
http://www.muppetlabs.com/~breadbox/software/tworld/ss/full1.jpg]
• attribute-invalid : <screenshot> height too small
[
http://www.muppetlabs.com/~breadbox/software/tworld/ss/full1.jpg]
metadata_license should be " CC-BY-SA-3.0", project_license
"GPL-2.0+",
according to
https://spdx.org/licenses/. Displays OK in gnome-software apart
from the license.
The game data satisfies the requirements for "firmware"
[
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging...],
and can be packaged. The license text is in CCLP?.html.
+ license is acceptable for Fedora (GPLv2+, "no mods" for the game data)
+ license is specified correctly
+ package name is OK
+ builds, install, runs OK
+ scriptlets are correct according to guidelines
+ P/R/BR look correct
Just some nitpicks. Your packaging foo is very strong ;)
Package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component