https://bugzilla.redhat.com/show_bug.cgi?id=970418
Bug ID: 970418 Summary: Review Request: mingw-flac - Free Lossless Audio Codec Library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Assignee: nobody@fedoraproject.org Reporter: ulatekh@yahoo.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: https://www.box.com/s/0bvt8meu0nnwt658mf5x SRPM URL: https://www.box.com/s/dwu6vakhb9nkg0y8obk8 Description: FLAC is an open source lossless audio codec developed by Josh Coalson. This is the MinGW version of a package that Fedora already has in its repository. Fedora Account System Username: ulatekh
https://bugzilla.redhat.com/show_bug.cgi?id=970418
Steve ulatekh@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
https://bugzilla.redhat.com/show_bug.cgi?id=970418
Steve ulatekh@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |970423
https://bugzilla.redhat.com/show_bug.cgi?id=970418
František Dvořák valtri@civ.zcu.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |valtri@civ.zcu.cz
--- Comment #1 from František Dvořák valtri@civ.zcu.cz --- Hello,
my observations of the packaging:
1) there were many changes in native package (source URL, descriptions, new version - currently 1.3.0, patches, build flags, ...).
MinGW packages should follow the native packages as closely as possible. With the new version and different patches, it will probably need a lot changes...
2) I guess the macros mingw_build_win32 and mingw_build_win64 are not needed?
3) having just two static subpackages mingw32-flac-static and mingw64-flac-static would simplify the packaging (= merging C and C++ static subpackages), but that's mere suggestion
https://bugzilla.redhat.com/show_bug.cgi?id=970418
František Dvořák valtri@civ.zcu.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ulatekh@yahoo.com Flags| |needinfo?(ulatekh@yahoo.com | |)
--- Comment #2 from František Dvořák valtri@civ.zcu.cz --- Steve, are you still planning to package that? -- František
https://bugzilla.redhat.com/show_bug.cgi?id=970418
František Dvořák valtri@civ.zcu.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Blocks| |201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Last Closed| |2014-01-11 18:29:44
--- Comment #3 from František Dvořák valtri@civ.zcu.cz --- Closing this request as inactive.
I'll take the package and submit a new review. Feel free to review the new request or add comments.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=970418
František Dvořák valtri@civ.zcu.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|NOTABUG |DUPLICATE
--- Comment #4 from František Dvořák valtri@civ.zcu.cz ---
*** This bug has been marked as a duplicate of bug 1051836 ***
https://bugzilla.redhat.com/show_bug.cgi?id=970418
Alexander Kurtakov akurtako@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=970418
František Dvořák valtri@civ.zcu.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ulatekh@yahoo.com | |) |
package-review@lists.fedoraproject.org