https://bugzilla.redhat.com/show_bug.cgi?id=1591910
--- Comment #7 from Antonio Trande <anto.trande(a)gmail.com> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- libblas* libraries are not hardened:
$ checksec --file libblas.so.3
RELRO STACK CANARY NX PIE RPATH
RUNPATH FORTIFY Fortified Fortifiable FILE
Partial RELRO No canary found NX enabled DSO No RPATH No
RUNPATH No 0 0 libblas.so.3
- These packages provide same blas* libraries:
$ repoquery --whatprovides libblas.so.*
Last metadata expiration check: 2:17:11 ago on sab 22 set 2018 12:57:31 CEST.
blas-0:3.8.0-8.fc28.i686
blas-0:3.8.0-8.fc28.x86_64
blas-0:3.8.0-9.fc28.i686
blas-0:3.8.0-9.fc28.x86_64
Must be filtered, i guess.
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "BSD (2 clause)", "Unknown or
generated". 330
files have unknown license. Detailed output of licensecheck in
/home/sagitter/1591910-blis/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in blis-
serial64 , blis-openmp , blis-openmp64 , blis-threads , blis-threads64
, blis-debuginfo , blis-debugsource
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[?]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
Note: Arch-ed rpms have a total of 1720320 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: blis-0.4.1-1.fc30.x86_64.rpm
blis-devel-0.4.1-1.fc30.x86_64.rpm
blis-serial64-0.4.1-1.fc30.x86_64.rpm
blis-openmp-0.4.1-1.fc30.x86_64.rpm
blis-openmp64-0.4.1-1.fc30.x86_64.rpm
blis-threads-0.4.1-1.fc30.x86_64.rpm
blis-threads64-0.4.1-1.fc30.x86_64.rpm
blis-debuginfo-0.4.1-1.fc30.x86_64.rpm
blis-debugsource-0.4.1-1.fc30.x86_64.rpm
blis-0.4.1-1.fc30.src.rpm
blis.x86_64: W: shared-lib-calls-exit /usr/lib64/libblis.so.1.0.0
exit(a)GLIBC_2.2.5
blis.x86_64: W: devel-file-in-non-devel-package /usr/lib64/blisblas/libblas.so
blis-serial64.x86_64: W: shared-lib-calls-exit /usr/lib64/libblis64.so.1.0.0
exit(a)GLIBC_2.2.5
blis-serial64.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/blisblas64/libblas64.so
blis-openmp.x86_64: W: shared-lib-calls-exit /usr/lib64/libbliso.so.1.0.0
exit(a)GLIBC_2.2.5
blis-openmp.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/blisblaso/libblas.so
blis-openmp64.x86_64: W: shared-lib-calls-exit /usr/lib64/libbliso64.so.1.0.0
exit(a)GLIBC_2.2.5
blis-openmp64.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/blisblaso64/libblas64.so
blis-threads.x86_64: W: spelling-error Summary(en_US) pthreads -> threads, p
threads, thread
blis-threads.x86_64: W: spelling-error %description -l en_US pthreads ->
threads, p threads, thread
blis-threads.x86_64: W: spelling-error %description -l en_US parallelized ->
paralleled, palatalized, pluralized
blis-threads.x86_64: W: shared-lib-calls-exit /usr/lib64/libblisp.so.1.0.0
exit(a)GLIBC_2.2.5
blis-threads.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/blisblasp/libblas.so
blis-threads64.x86_64: W: spelling-error Summary(en_US) pthreads -> threads, p
threads, thread
blis-threads64.x86_64: W: spelling-error %description -l en_US pthreads ->
threads, p threads, thread
blis-threads64.x86_64: W: spelling-error %description -l en_US parallelized ->
paralleled, palatalized, pluralized
blis-threads64.x86_64: W: shared-lib-calls-exit /usr/lib64/libblisp64.so.1.0.0
exit(a)GLIBC_2.2.5
blis-threads64.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/blisblasp64/libblas64.so
blis.src:145: W: configure-without-libdir-spec
blis.src:149: W: configure-without-libdir-spec
blis.src:169: W: configure-without-libdir-spec
blis.src:173: W: configure-without-libdir-spec
blis.src:177: W: configure-without-libdir-spec
blis.src:196: W: configure-without-libdir-spec
10 packages and 0 specfiles checked; 0 errors, 24 warnings.
Rpmlint (debuginfo)
-------------------
Checking: blis-openmp-debuginfo-0.4.1-1.fc30.x86_64.rpm
blis-serial64-debuginfo-0.4.1-1.fc30.x86_64.rpm
blis-debuginfo-0.4.1-1.fc30.x86_64.rpm
blis-threads64-debuginfo-0.4.1-1.fc30.x86_64.rpm
blis-openmp64-debuginfo-0.4.1-1.fc30.x86_64.rpm
blis-threads-debuginfo-0.4.1-1.fc30.x86_64.rpm
6 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
blis-threads64.x86_64: W: spelling-error Summary(en_US) pthreads -> threads, p
threads, thread
blis-threads64.x86_64: W: spelling-error %description -l en_US pthreads ->
threads, p threads, thread
blis-threads64.x86_64: W: spelling-error %description -l en_US parallelized ->
paralleled, palatalized, pluralized
blis-threads64.x86_64: W: invalid-url URL:
https://github.com/flame/blis
<urlopen error [Errno -2] Name or service not known>
blis-threads64.x86_64: W: shared-lib-calls-exit /usr/lib64/libblisp64.so.1.0.0
exit(a)GLIBC_2.2.5
blis-threads64.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/blisblasp64/libblas64.so
blis-openmp-debuginfo.x86_64: W: invalid-url URL:
https://github.com/flame/blis
<urlopen error [Errno -2] Name or service not known>
blis-devel.x86_64: W: invalid-url URL:
https://github.com/flame/blis <urlopen
error [Errno -2] Name or service not known>
blis-threads.x86_64: W: spelling-error Summary(en_US) pthreads -> threads, p
threads, thread
blis-threads.x86_64: W: spelling-error %description -l en_US pthreads ->
threads, p threads, thread
blis-threads.x86_64: W: spelling-error %description -l en_US parallelized ->
paralleled, palatalized, pluralized
blis-threads.x86_64: W: invalid-url URL:
https://github.com/flame/blis <urlopen
error [Errno -2] Name or service not known>
blis-threads.x86_64: W: shared-lib-calls-exit /usr/lib64/libblisp.so.1.0.0
exit(a)GLIBC_2.2.5
blis-threads.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/blisblasp/libblas.so
blis-serial64-debuginfo.x86_64: W: invalid-url URL:
https://github.com/flame/blis <urlopen error [Errno -2] Name or service not
known>
blis-debugsource.x86_64: W: invalid-url URL:
https://github.com/flame/blis
<urlopen error [Errno -2] Name or service not known>
blis-openmp.x86_64: W: invalid-url URL:
https://github.com/flame/blis <urlopen
error [Errno -2] Name or service not known>
blis-openmp.x86_64: W: shared-lib-calls-exit /usr/lib64/libbliso.so.1.0.0
exit(a)GLIBC_2.2.5
blis-openmp.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/blisblaso/libblas.so
blis.x86_64: W: invalid-url URL:
https://github.com/flame/blis <urlopen error
[Errno -2] Name or service not known>
blis.x86_64: W: shared-lib-calls-exit /usr/lib64/libblis.so.1.0.0
exit(a)GLIBC_2.2.5
blis.x86_64: W: devel-file-in-non-devel-package /usr/lib64/blisblas/libblas.so
blis-threads-debuginfo.x86_64: W: invalid-url URL:
https://github.com/flame/blis <urlopen error [Errno -2] Name or service not
known>
blis-openmp64.x86_64: W: invalid-url URL:
https://github.com/flame/blis
<urlopen error [Errno -2] Name or service not known>
blis-openmp64.x86_64: W: shared-lib-calls-exit /usr/lib64/libbliso64.so.1.0.0
exit(a)GLIBC_2.2.5
blis-openmp64.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/blisblaso64/libblas64.so
blis-debuginfo.x86_64: W: invalid-url URL:
https://github.com/flame/blis
<urlopen error [Errno -2] Name or service not known>
blis-openmp64-debuginfo.x86_64: W: invalid-url URL:
https://github.com/flame/blis <urlopen error [Errno -2] Name or service not
known>
blis-serial64.x86_64: W: invalid-url URL:
https://github.com/flame/blis
<urlopen error [Errno -2] Name or service not known>
blis-serial64.x86_64: W: shared-lib-calls-exit /usr/lib64/libblis64.so.1.0.0
exit(a)GLIBC_2.2.5
blis-serial64.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/blisblas64/libblas64.so
blis-threads64-debuginfo.x86_64: W: invalid-url URL:
https://github.com/flame/blis <urlopen error [Errno -2] Name or service not
known>
14 packages and 0 specfiles checked; 0 errors, 32 warnings.
Requires
--------
blis-threads64 (rpmlib, GLIBC filtered):
ld-linux-x86-64.so.2()(64bit)
libblas64.so.3()(64bit)
libblisp64.so.1()(64bit)
libc.so.6()(64bit)
libm.so.6()(64bit)
libpthread.so.0()(64bit)
librt.so.1()(64bit)
rtld(GNU_HASH)
blis-devel (rpmlib, GLIBC filtered):
blis(x86-64)
blis-openmp(x86-64)
blis-openmp64(x86-64)
blis-serial64(x86-64)
blis-threads(x86-64)
blis-threads64(x86-64)
libblis.so.1()(64bit)
libblis64.so.1()(64bit)
libbliso.so.1()(64bit)
libbliso64.so.1()(64bit)
libblisp.so.1()(64bit)
libblisp64.so.1()(64bit)
blis-threads (rpmlib, GLIBC filtered):
ld-linux-x86-64.so.2()(64bit)
libblas.so.3()(64bit)
libblisp.so.1()(64bit)
libc.so.6()(64bit)
libm.so.6()(64bit)
libpthread.so.0()(64bit)
librt.so.1()(64bit)
rtld(GNU_HASH)
blis-debugsource (rpmlib, GLIBC filtered):
blis-openmp (rpmlib, GLIBC filtered):
ld-linux-x86-64.so.2()(64bit)
libblas.so.3()(64bit)
libbliso.so.1()(64bit)
libc.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.3.1)(64bit)
libgomp.so.1()(64bit)
libgomp.so.1(GOMP_4.0)(64bit)
libgomp.so.1(OMP_1.0)(64bit)
libm.so.6()(64bit)
libpthread.so.0()(64bit)
librt.so.1()(64bit)
rtld(GNU_HASH)
blis (rpmlib, GLIBC filtered):
config(blis)
ld-linux-x86-64.so.2()(64bit)
libblas.so.3()(64bit)
libblis.so.1()(64bit)
libc.so.6()(64bit)
libm.so.6()(64bit)
libpthread.so.0()(64bit)
librt.so.1()(64bit)
rtld(GNU_HASH)
blis-openmp64 (rpmlib, GLIBC filtered):
ld-linux-x86-64.so.2()(64bit)
libblas64.so.3()(64bit)
libbliso64.so.1()(64bit)
libc.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.3.1)(64bit)
libgomp.so.1()(64bit)
libgomp.so.1(GOMP_4.0)(64bit)
libgomp.so.1(OMP_1.0)(64bit)
libm.so.6()(64bit)
libpthread.so.0()(64bit)
librt.so.1()(64bit)
rtld(GNU_HASH)
blis-debuginfo (rpmlib, GLIBC filtered):
blis-serial64 (rpmlib, GLIBC filtered):
config(blis-serial64)
ld-linux-x86-64.so.2()(64bit)
libblas64.so.3()(64bit)
libblis64.so.1()(64bit)
libc.so.6()(64bit)
libm.so.6()(64bit)
libpthread.so.0()(64bit)
librt.so.1()(64bit)
rtld(GNU_HASH)
Provides
--------
blis-threads64:
blis-threads64
blis-threads64(x86-64)
libblas64.so.3()(64bit)
libblisp64.so.1()(64bit)
blis-devel:
blis-devel
blis-devel(x86-64)
blis-threads:
blis-threads
blis-threads(x86-64)
libblas.so.3()(64bit)
libblisp.so.1()(64bit)
blis-debugsource:
blis-debugsource
blis-debugsource(x86-64)
blis-openmp:
blis-openmp
blis-openmp(x86-64)
libblas.so.3()(64bit)
libbliso.so.1()(64bit)
blis:
blis
blis(x86-64)
config(blis)
libblas.so.3()(64bit)
libblis.so.1()(64bit)
blis-openmp64:
blis-openmp64
blis-openmp64(x86-64)
libblas64.so.3()(64bit)
libbliso64.so.1()(64bit)
blis-debuginfo:
blis-debuginfo
blis-debuginfo(x86-64)
debuginfo(build-id)
blis-serial64:
blis-serial64
blis-serial64(x86-64)
config(blis-serial64)
libblas64.so.3()(64bit)
libblis64.so.1()(64bit)
Unversioned so-files
--------------------
blis: /usr/lib64/blisblas/libblas.so
blis-serial64: /usr/lib64/blisblas64/libblas64.so
blis-openmp: /usr/lib64/blisblaso/libblas.so
blis-openmp64: /usr/lib64/blisblaso64/libblas64.so
blis-threads: /usr/lib64/blisblasp/libblas.so
blis-threads64: /usr/lib64/blisblasp64/libblas64.so
Source checksums
----------------
https://github.com/flame/blis/archive/0.4.1/blis-0.4.1.tar.gz :
CHECKSUM(SHA256) this package :
a0c00e6e4ae215e8d965226c2446c2e53f121b31c3b8ff5ca983b0a51ed2fd25
CHECKSUM(SHA256) upstream package :
a0c00e6e4ae215e8d965226c2446c2e53f121b31c3b8ff5ca983b0a51ed2fd25
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1591910
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component