Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

Fabian Affolter fabian@bernewireless.net changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@bernewireless.net

--- Comment #2 from Fabian Affolter fabian@bernewireless.net 2008-10-24 03:31:44 EDT --- Just a few comments on your spec file.

Release: 1

- add %{?dist} -> Release: 1%{?dist}

Source: rear-%{version}.tar.gz

- The source should come from upstream. Source0: http://downloads.sourceforge.net/%%7Bname%7D/%%7Bname%7D-%%7Bversion%7D.tar.... https://fedoraproject.org/wiki/Packaging/SourceURL

License: GPL

- is GPLv3+ https://fedoraproject.org/wiki/Packaging/LicensingGuidelines

Packager: Schlomo Schapiro sschapiro@probusiness.de, Gratien D'haese gratien.dhaese@it3.be

- Packager tag is not used in Fedora

Provides: rear

- This package doesn't provide any virtual packages. I think it's save to remove

https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Other...

Vendor: probusiness Berlin AG and IT3 Consultants

- Vendor tag is not used in Fedora

%files section

- Please use macros it will be easier to maintain the package in the future https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macro...

Details about the changelog https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

Please check https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo or https://fedoraproject.org/wiki/Packaging/Guidelines for further details.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

Fabian Affolter fabian@bernewireless.net changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(gratien.dhaese@it | |3.be)

--- Comment #4 from Fabian Affolter fabian@bernewireless.net 2008-10-24 03:44:30 EDT --- Another appendix

In your spec file is 'Version: 1.7.7' but the current stable version is 1.6 (http://sourceforge.net/project/showfiles.php?group_id=171835&package_id=...) and the development version is 1.7.6 (http://sourceforge.net/project/showfiles.php?group_id=171835&package_id=...).

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

Gratien D'haese gratien.dhaese@it3.be changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(gratien.dhaese@it | |3.be) |

--- Comment #6 from Gratien D'haese gratien.dhaese@it3.be 2008-10-24 07:12:17 EDT --- Thank you all for the very useful comments. I'm digging into the docs (sorry I hadn't seen these before) and trying to get it straight. Will use rpmlint to investigate the spec before I uploaded it again.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

--- Comment #8 from Fabian Affolter fabian@bernewireless.net 2008-10-25 10:08:53 EDT --- Once again.

Source0: http://downloads.sourgeforge.net/%%7Bname%7D-%%7Bversion%7D.tar.gz

- It's 'sourceforge', just a type...

Release: 1%{?dist}

- After you made any changes, please bump the release.

%changelog -> rpmlint issue * Thu Oct 24 2008 Gratien D'haese - rewrote rear.spec for FedoraCore Packaging request * Tue Aug 28 2006 Schlomo Schapiro - Initial RPM Release

- https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs Example: * Wed Jun 14 2003 Joe Packager <joe at gmail.com> - 1.0-2 - Added README file (#42). ^ ^ | | This is the version --- | This is the release ------

BTW, it's only Fedora, we don't use Core anymore.

I'm able to build your package but rpmlint complain about a lot of stuff...

[rpm@laptop024 SRPMS]$ rpmlint -i rear-1.7.7-1.fc9.src.rpm rear.src: W: non-standard-group System/Archiving The value of the Group tag in the package is not valid. Valid groups are: "Amusements/Games", "Amusements/Graphics", "Applications/Archiving", "Applications/Communications", "Applications/Databases", "Applications/Editors", "Applications/Emulators", "Applications/Engineering", "Applications/File", "Applications/Internet", "Applications/Multimedia", "Applications/Productivity", "Applications/Publishing", "Applications/System", "Applications/Text", "Development/Debug", "Development/Debuggers", "Development/Languages", "Development/Libraries", "Development/System", "Development/Tools", "Documentation", "System Environment/Base", "System Environment/Daemons", "System Environment/Kernel", "System Environment/Libraries", "System Environment/Shells", "User Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support".

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[rpm@laptop024 noarch]$ rpmlint -i rear-1.7.7-1.fc9.noarch.rpm rear.noarch: W: non-conffile-in-etc /etc/rear/Linux-ia64.conf A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file.

rear.noarch: E: script-without-shebang /usr/share/rear/lib/cfg2html-linux This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere.

rear.noarch: W: non-conffile-in-etc /etc/rear/GNU/Linux.conf A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file.

rear.noarch: W: non-conffile-in-etc /etc/rear/templates/EFI_readme.txt A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file.

rear.noarch: E: zero-length /usr/share/doc/rear-1.7.7/DEVELOPMENT rear.noarch: W: non-conffile-in-etc /etc/rear/templates/RESULT_usage_USB.txt A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file.

rear.noarch: W: dangling-relative-symlink /usr/share/rear/skel/default/bin/sh bash The relative symbolic link points nowhere.

rear.noarch: W: non-conffile-in-etc /etc/rear/Linux-i386.conf A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file.

rear.noarch: E: zero-length /usr/share/rear/pack/hpasmcliOutput.txt rear.noarch: E: script-without-shebang /usr/share/rear/verify/TSM/default/40_verify_tsm.sh This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere.

rear.noarch: W: hidden-file-or-dir /usr/share/rear/skel/default/.bash_history The file or directory is hidden. You should see if this is normal, and delete it from the package if not.

rear.noarch: W: non-conffile-in-etc /etc/rear/templates/USB_syslinux.cfg A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file.

rear.noarch: W: non-conffile-in-etc /etc/rear/Debian/ia64.conf A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file.

rear.noarch: W: non-conffile-in-etc /etc/rear/templates/RESULT_usage_ISO.txt A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file.

rear.noarch: E: zero-length /etc/rear/hpasmcliOutput.txt rear.noarch: W: non-conffile-in-etc /etc/rear/hpasmcliOutput.txt A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file.

rear.noarch: W: non-conffile-in-etc /etc/rear/Ubuntu/7.10.conf A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file.

rear.noarch: E: zero-length /usr/share/rear/doc/DEVELOPMENT rear.noarch: W: dangling-relative-symlink /usr/share/rear/skel/default/init bin/init The relative symbolic link points nowhere.

rear.noarch: W: non-conffile-in-etc /etc/rear/templates/RESULT_usage_PXE.txt A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file.

rear.noarch: W: dangling-relative-symlink /usr/share/doc/rear-1.7.7/README ./usr/share/rear/README The relative symbolic link points nowhere.

rear.noarch: E: zero-length /usr/share/rear/skel/default/var/log/lastlog rear.noarch: W: non-conffile-in-etc /etc/rear/Linux-x86_64.conf A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file.

rear.noarch: W: dangling-relative-symlink /usr/share/doc/rear-1.7.7/contrib ./usr/share/rear/contrib The relative symbolic link points nowhere.

rear.noarch: W: dangling-relative-symlink /usr/share/doc/rear-1.7.7/CHANGES ./usr/share/rear/CHANGES The relative symbolic link points nowhere.

rear.noarch: E: zero-length /usr/share/rear/dr/hpasmcliOutput.txt rear.noarch: W: non-conffile-in-etc /etc/rear/default.conf A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file.

rear.noarch: E: script-without-shebang /usr/share/rear/dr/GNU/Linux/95_cfg2html.sh This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere.

rear.noarch: W: non-conffile-in-etc /etc/rear/validated/SUSE_LINUX/10/i386.txt A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file.

rear.noarch: E: zero-length /usr/share/rear/skel/default/var/lib/nfs/state rear.noarch: E: script-without-shebang /usr/share/rear/lib/mkrescue-functions.sh This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere.

rear.noarch: W: non-conffile-in-etc /etc/rear/templates/RESULT_mailbody.txt A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file.

rear.noarch: E: zero-length /usr/share/rear/skel/default/etc/mtab rear.noarch: W: non-standard-group System/Archiving The value of the Group tag in the package is not valid. Valid groups are: "Amusements/Games", "Amusements/Graphics", "Applications/Archiving", "Applications/Communications", "Applications/Databases", "Applications/Editors", "Applications/Emulators", "Applications/Engineering", "Applications/File", "Applications/Internet", "Applications/Multimedia", "Applications/Productivity", "Applications/Publishing", "Applications/System", "Applications/Text", "Development/Debug", "Development/Debuggers", "Development/Languages", "Development/Libraries", "Development/System", "Development/Tools", "Documentation", "System Environment/Base", "System Environment/Daemons", "System Environment/Kernel", "System Environment/Libraries", "System Environment/Shells", "User Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support".

rear.noarch: W: incoherent-version-in-changelog D'haese 1.7.7-1.fc9 The last entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package.

1 packages and 0 specfiles checked; 12 errors, 23 warnings.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

--- Comment #9 from Gratien D'haese gratien.dhaese@it3.be 2008-10-27 07:37:27 EDT --- Hi all, Busy with correcting the rear.spec and some other comments you mentioned above.

I've seeing now: [makerpm@localhost SPECS]$ rpmlint -i /home/makerpm/rpmbuild/SRPMS/rear-1.7.8-1.fc9.src.rpm rear.src: W: strange-permission rear.spec 0600 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[makerpm@localhost SPECS]$ rpmlint -i /home/makerpm/rpmbuild/RPMS/noarch/rear-1.7.8-1.fc9.noarch.rpm rear.noarch: W: dangling-relative-symlink /usr/share/doc/rear-1.7.8/contrib ./usr/share/rear/contrib The relative symbolic link points nowhere.

rear.noarch: W: dangling-relative-symlink /usr/share/rear/skel/default/bin/sh bash The relative symbolic link points nowhere.

rear.noarch: W: hidden-file-or-dir /usr/share/rear/skel/default/.bash_history The file or directory is hidden. You should see if this is normal, and delete it from the package if not.

rear.noarch: W: dangling-relative-symlink /usr/share/doc/rear-1.7.8/README ./usr/share/rear/README The relative symbolic link points nowhere.

rear.noarch: W: dangling-relative-symlink /usr/share/doc/rear-1.7.8/CHANGES ./usr/share/rear/CHANGES The relative symbolic link points nowhere.

rear.noarch: W: dangling-relative-symlink /usr/share/rear/skel/default/init bin/init The relative symbolic link points nowhere.

rear.noarch: E: zero-length /usr/share/rear/skel/default/var/log/lastlog rear.noarch: E: zero-length /usr/share/rear/skel/default/var/lib/nfs/state rear.noarch: E: zero-length /usr/share/rear/skel/default/etc/mtab 1 packages and 0 specfiles checked; 3 errors, 6 warnings. [makerpm@localhost SPECS]$ rpmlint -i /home/makerpm/rpmbuild/SRPMS/rear-1.7. Error: no installed packages by name /home/makerpm/rpmbuild/SRPMS/rear-1.7. 0 packages and 0 specfiles checked; 0 errors, 0 warnings.

==> Rear makes usage of relative symbolic links. Is there a way to suppress these warning? Or is it safe to ignore? ==> the zero-length file are necessary when we build a boot image. We can safely ignore these errors. Is there a way to tell in rear.spec file to say we can ignore "zero length" files?

Would like to avoid submitting a new version which still produces errors during a rpmlint investigation.

thanks, Gratien

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

--- Comment #11 from Fabian Affolter fabian@bernewireless.net 2008-11-10 16:39:04 EDT --- I really think that the remove of the SuSE releated stuff from the spec file would make it more readable.

- sorry, the right URL is Source0: http://downloads.sourceforge.net/%%7Bname%7D/%%7Bname%7D-%%7Bversion%7D.tar....

- Your Buildroot don't match the Guidelines https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

- %defattr(-,root,root) is often %defattr(-,root,root,-) to leave the default directory permissions in place

- Changelog: After every entry a blank line would be nice. It's definitely easier to read

- License: Spec file: GPLv3+ rear GPLv2+

- Clean your Buildroot before you start doing stuff there rm -rf %{buildroot} or rm -rf $RPM_BUILD_ROOT

- cp -a usr etc $RPM_BUILD_ROOT/ Please preserve the timestamps https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

- Warning during rpm build process warning: File listed twice: /etc/rear/Debian/ia64.conf warning: File listed twice: /etc/rear/GNU/Linux.conf ... ... only add %config(noreplace) %{_sysconfdir}/rear/ (delete all other lines with %config(noreplace) %{_sysconfdir}/rear/*.*) to add that directory and its contents recursively (beware not tested and not sure about the permissions)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

Fabian Affolter fabian@bernewireless.net changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |fabian@bernewireless.net Flag| |fedora-review?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

Schlomo Schapiro redhat@schlomo.schapiro.org changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |redhat@schlomo.schapiro.org

--- Comment #14 from Schlomo Schapiro redhat@schlomo.schapiro.org 2008-12-14 10:08:36 EDT --- Hi,

I am - together with Gratien - the main developer of Relax and Recover.

I am currently trying to find a sponsor, is there anything else missing so far?

A few notes about the issues mentioned above from a ReaR design point of view:

1) ReaR brings along the empty filesystem of a mini linux distribution (no binaries) which is the reason for the empty files and symlinks pointing nowhere. As part of the ReaR process to create the rescue media this empty filesystem is filled in with components from the current linux system to create a functioning mini linux rescue system.

Is there a way to get along with the empty files and dead symlinks?

2) ReaR does not have a -devel package and - by design - always contains the entire distribution. That is why you will also find .deb and gentoo files as part of every ReaR installation so that any user can package his/her (modified) version of ReaR without installing any additional tools. Since ReaR is written entirely in Bash there is no platform or distribution dependency beyond what ReaR is already doing internally.

Of course we could leave these under /usr/share/rear and not copy them to %doc.

Kind regards, Schlomo

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

--- Comment #16 from Gratien D'haese gratien.dhaese@it3.be 2008-12-30 09:44:17 EDT --- Hello all,

Spec URL: http://home.scarlet.be/gdha/rear.spec SRPM URL: http://home.scarlet.be/gdha/rear-1.7.11-1.fc9.src.rpm

We're finally getting there!

# rpmlint -v -i /home/gdha/RPM/RPMS/noarch/rear-1.7.11-1.fc9.noarch.rpm rear.noarch: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings.

# mock -r default rebuild /home/gdha/RPM/SRPMS/rear-1.7.11-1.fc9.src.rpm INFO: mock.py version 0.9.13 starting... State Changed: init plugins State Changed: start INFO: Start(/home/gdha/RPM/SRPMS/rear-1.7.11-1.fc9.src.rpm) Config(fedora-9-i386) State Changed: lock buildroot State Changed: clean State Changed: init State Changed: lock buildroot INFO: enabled root cache INFO: root cache aged out! cache will be rebuilt INFO: enabled yum cache State Changed: cleaning yum metadata INFO: enabled ccache State Changed: running yum State Changed: creating cache State Changed: setup State Changed: build INFO: Done(/home/gdha/RPM/SRPMS/rear-1.7.11-1.fc9.src.rpm) Config(default) 10 minutes 21 seconds INFO: Results and/or logs in: /var/lib/mock//fedora-9-i386/result

I think the time has arrived to find a sponsor for this project.

Best wishes and a fruitful open source 2009 !! Gratien D'haese

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

--- Comment #18 from manuel wolfshant wolfy@nobugconsulting.ro 2008-12-30 15:37:59 EDT --- Uhm, I see that both /bin/sh and /bin/bash are needed:

[wolfy@wolfy tmp]$ rpm -qp --requires rear-1.7.11-1.fc11.noarch.rpm /bin/bash /bin/sh binutils config(rear) = 1.7.11-1.fc11 iputils mingetty portmap rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1

It's a bit unusual, since /bin/bash is a superset of /bin/sh. Is it really intended to bring in botth or you have just not been constant in using either one or the other in the scripts that you have packaged ?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

--- Comment #19 from Gratien D'haese gratien.dhaese@it3.be 2009-01-09 07:45:33 EDT --- Hello all,

Spec URL: http://home.scarlet.be/gdha/rear.spec SRPM URL: http://home.scarlet.be/gdha/rear-1.7.12-1.fc9.src.rpm RPM URL: http://home.scarlet.be/gdha/rear-1.7.12-1.fc9.noarch.rpm

The validation script I wrote to test the RPMs produced the following output:

============================================================================== ============================================================================== Make a fresh RPM of Relax and Recover (rear) URL: http://rear.sourceforge.net ============================================================================== ==============================================================================

Relax & Recover Version 1.7.12 / 2009-01-09 Creating archive '/tmp/rear-1.7.12.tar.gz OK Creating RPM packages OK

Wrote: /home/gdha/RPM/RPMS/noarch/rear-1.7.12-1.fc9.noarch.rpm Wrote: /home/gdha/RPM/SRPMS/rear-1.7.12-1.fc9.src.rpm Finished in 6 seconds.

============================================================================== Unpack /home/gdha/RPM/SRPMS/rear-1.7.12-1.fc9.src.rpm ==============================================================================

rear ##################################################

============================================================================== rpmlint -v -i /home/gdha/RPM/RPMS/noarch/rear-1.7.12-1.fc9.noarch.rpm ==============================================================================

rear.noarch: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings.

============================================================================== rpmlint -v -i /home/gdha/RPM/SRPMS/rear-1.7.12-1.fc9.src.rpm ==============================================================================

rear.src: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings.

============================================================================== rpmlint -v -i /home/gdha/RPM/SPECS/rear.spec ==============================================================================

0 packages and 1 specfiles checked; 0 errors, 0 warnings.

============================================================================== rpm -qp --requires /home/gdha/RPM/RPMS/noarch/rear-1.7.12-1.fc9.noarch.rpm ==============================================================================

/bin/bash binutils config(rear) = 1.7.12-1.fc9 iputils mingetty portmap rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1

============================================================================== rpm -qp --info /home/gdha/RPM/RPMS/noarch/rear-1.7.12-1.fc9.noarch.rpm ==============================================================================

Name : rear Relocations: (not relocatable) Version : 1.7.12 Vendor: (none) Release : 1.fc9 Build Date: Fri 09 Jan 2009 01:02:34 PM CET Install Date: (not installed) Build Host: localhost.localdomain Group : Applications/Archiving Source RPM: rear-1.7.12-1.fc9.src.rpm Size : 466172 License: GPLv2+ Signature : (none) URL : http://rear.sourceforge.net Summary : Relax and Recover (ReaR) is a Linux Disaster Recovery framework Description : Relax and Recover (abbreviated rear) is a highly modular disaster recovery framework for GNU/Linux based systems, but can be easily extended to other UNIX alike systems. The disaster recovery information (and maybe the backups) can be stored via the network, local on hard disks or USB devices, DVD/CD-R, tape, etc. The result is also a bootable image that is capable of booting via PXE, DVD/CD and tape (OBDR).

This is work in progress, so some features are not yet implemented.

============================================================================== rpm -qpd /home/gdha/RPM/RPMS/noarch/rear-1.7.12-1.fc9.noarch.rpm (docfiles) ==============================================================================

/usr/share/doc/rear-1.7.12/CHANGES /usr/share/doc/rear-1.7.12/README /usr/share/doc/rear-1.7.12/readme.txt /usr/share/doc/rear-1.7.12/validated/Fedora/9/i386.txt

============================================================================== rpm -qpc /home/gdha/RPM/RPMS/noarch/rear-1.7.12-1.fc9.noarch.rpm (configfiles) ==============================================================================

/etc/rear/Debian/ia64.conf /etc/rear/GNU/Linux.conf /etc/rear/Linux-i386.conf /etc/rear/Linux-ia64.conf /etc/rear/Linux-x86_64.conf /etc/rear/Ubuntu/7.10.conf /etc/rear/default.conf /etc/rear/local.conf /etc/rear/site.conf /etc/rear/templates/EFI_readme.txt /etc/rear/templates/ISO_isolinux.cfg /etc/rear/templates/PXE_pxelinux.cfg /etc/rear/templates/RESULT_mailbody.txt /etc/rear/templates/RESULT_usage_ISO.txt /etc/rear/templates/RESULT_usage_PXE.txt /etc/rear/templates/RESULT_usage_USB.txt /etc/rear/templates/USB_syslinux.cfg

============================================================================== Build RPM with /tmp/rear-1.7.12.tar.gz ============================================================================== rpmbuild -ta /tmp/rear-1.7.12.tar.gz

Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.50745 Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.50745 Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.50745 Processing files: rear-1.7.12-1.fc9 Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.74122 Provides: config(rear) = 1.7.12-1.fc9 Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Requires: /bin/bash binutils config(rear) = 1.7.12-1.fc9 iputils mingetty portmap Checking for unpackaged file(s): /usr/lib/rpm/check-files /var/tmp/rear-1.7.12-1.fc9-root Wrote: /home/gdha/RPM/SRPMS/rear-1.7.12-1.fc9.src.rpm Wrote: /home/gdha/RPM/RPMS/noarch/rear-1.7.12-1.fc9.noarch.rpm Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.40214

And the mock output of the following command # mock -r default rebuild /home/gdha/RPM/SRPMS/rear-1.7.12-1.fc9.src.rpm is # cat /var/lib/mock//fedora-9-i386/result/build.log ENTER do(['bash', '--login', '-c', 'rpmbuild -bs --target i386 --nodeps builddir/build/SPECS/rear.spec'], False, '/var/lib/mock/fedora-9-i386/root/', None, 0, True, 0, 0, 487, None, logger=<mock.trace_decorator.getLog object at 0x994810c>) Executing command: ['bash', '--login', '-c', 'rpmbuild -bs --target i386 --nodeps builddir/build/SPECS/rear.spec'] Building target platforms: i386 Building for target i386 Wrote: /builddir/build/SRPMS/rear-1.7.12-1.fc9.src.rpm Child returncode was: 0 LEAVE do -->

ENTER do(['bash', '--login', '-c', 'rpmbuild -bb --target i386 --nodeps builddir/build/SPECS/rear.spec'], False, '/var/lib/mock/fedora-9-i386/root/', None, 0, True, 0, 0, 487, None, logger=<mock.trace_decorator.getLog object at 0x994810c>) Executing command: ['bash', '--login', '-c', 'rpmbuild -bb --target i386 --nodeps builddir/build/SPECS/rear.spec'] Building target platforms: i386 Building for target i386 Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.59520 + umask 022 + cd /builddir/build/BUILD + LANG=C + export LANG + unset DISPLAY + cd /builddir/build/BUILD + rm -rf rear-1.7.12 + /usr/bin/gzip -dc /builddir/build/SOURCES/rear-1.7.12.tar.gz + tar -xf - + STATUS=0 + '[' 0 -ne 0 ']' + cd rear-1.7.12 ++ /usr/bin/id -u + '[' 0 = 0 ']' + /bin/chown -Rhf root . ++ /usr/bin/id -u + '[' 0 = 0 ']' + /bin/chgrp -Rhf root . + /bin/chmod -Rf a+rX,u+w,g-w,o-w . + exit 0 Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.83696 + umask 022 + cd /builddir/build/BUILD + cd rear-1.7.12 + LANG=C + export LANG + unset DISPLAY + exit 0 Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.83696 + umask 022 + cd /builddir/build/BUILD + cd rear-1.7.12 + LANG=C + export LANG + unset DISPLAY + rm -rf /var/tmp/rear-1.7.12-1.fc9-root + mkdir /var/tmp/rear-1.7.12-1.fc9-root + cp -ap usr etc /var/tmp/rear-1.7.12-1.fc9-root/ + /usr/lib/rpm/find-debuginfo.sh /builddir/build/BUILD/rear-1.7.12 + /usr/lib/rpm/check-buildroot + /usr/lib/rpm/redhat/brp-compress + /usr/lib/rpm/redhat/brp-strip-static-archive /usr/bin/strip + /usr/lib/rpm/redhat/brp-strip-comment-note /usr/bin/strip /usr/bin/objdump + /usr/lib/rpm/brp-python-bytecompile + /usr/lib/rpm/redhat/brp-python-hardlink + /usr/lib/rpm/redhat/brp-java-repack-jars Processing files: rear-1.7.12-1.fc9 Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.83299 + umask 022 + cd /builddir/build/BUILD + cd rear-1.7.12 + DOCDIR=/var/tmp/rear-1.7.12-1.fc9-root/usr/share/doc/rear-1.7.12 + export DOCDIR + rm -rf /var/tmp/rear-1.7.12-1.fc9-root/usr/share/doc/rear-1.7.12 + /bin/mkdir -p /var/tmp/rear-1.7.12-1.fc9-root/usr/share/doc/rear-1.7.12 + cp -pr CHANGES README doc/readme.txt doc/validated /var/tmp/rear-1.7.12-1.fc9-root/usr/share/doc/rear-1.7.12 + exit 0 Provides: config(rear) = 1.7.12-1.fc9 Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Requires: /bin/bash binutils config(rear) = 1.7.12-1.fc9 iputils mingetty portmap Checking for unpackaged file(s): /usr/lib/rpm/check-files /var/tmp/rear-1.7.12-1.fc9-root Wrote: /builddir/build/RPMS/rear-1.7.12-1.fc9.noarch.rpm Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.74870 + umask 022 + cd /builddir/build/BUILD + cd rear-1.7.12 + rm -rf /var/tmp/rear-1.7.12-1.fc9-root + exit 0 Child returncode was: 0 LEAVE do -->

Can I now start looking for a sponsor? Or are there some more steps that need to be improved or clarified?

To all a *big* thank you for your patience with me! best regards, Gratien D'haese

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

--- Comment #21 from Gratien D'haese gratien.dhaese@it3.be 2009-02-09 08:14:21 EDT --- Created an attachment (id=331310) --> (https://bugzilla.redhat.com/attachment.cgi?id=331310) Validation output of rear-1.7.15 package

wrote a script to automate the validation process of a rear package. In this way we're using a consistent way of testing any updates on the package.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

Gratien D'haese gratien.dhaese@it3.be changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

Robert Scheck redhat-bugzilla@linuxnetz.de changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |redhat-bugzilla@linuxnetz.d | |e

--- Comment #23 from Robert Scheck redhat-bugzilla@linuxnetz.de 2009-02-12 15:25:57 EDT --- I don't know rear, but when looking to the package, I've got a few points:

- /usr/share/rear/CHANGES, /usr/share/rear/COPYING, /usr/share/rear/README, you're shipping twice. Kill the files in /usr/share/rear, because one time using %doc is enough. - Why is /etc/rear/templates/EFI_readme.txt marked as configuration file? Is it a configuration file? Either it's a readme or it is a configuration file; but if it's readme, it should go into %doc from my point of view. - What's /etc/rear/templates/RESULT_*? Looks like readmes as well, yes/no? - /usr/share/doc/rear-1.7.15/rear.8 is shipped already in %{_mandir}, so please not also in %doc, twice is too much. - /usr/share/rear/doc contains stuff, which is already covered by %doc and/or %{_mandir}, so please do not ship the directory at the RPM package. - Is /usr/share/rear meant to be readonly? /usr/share/rear/skel looks to me as it would be used read-writeable as well. - I'm not sure, whether /var/rear is correct, what will this directory contain when it is in regular use? - You maybe want to use "BuildArch" rather "BuildArchitectures", but that is just cosmetic. - Do you really need binutils as during runtime? Just wondering...

I don't expect you to change all my stuff mentioned above, various has maybe to get discussed first. Can somebody summarize how /usr/share/rear is used and which meaning it has? No changing content during rear usage?

Maybe more will come up, that's what I discovered with the first run...

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

Gratien D'haese gratien.dhaese@it3.be changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(gratien.dhaese@it | |3.be) |

--- Comment #25 from Gratien D'haese gratien.dhaese@it3.be 2009-02-13 10:58:46 EDT --- Hi all, thank you (Robert) for taking a closer look into rear - much appreciated - the goal is indeed to make the software cleaner (and better).

As Schlomo (in #24) already mentioned the doc files are kept double for the simple reason that it is very easy to make a new 'in-house' rpm for example (with the command 'rear mkrpm'). However, if we must exclude them, we can of course. In that case the customers who want to build their own in-house rpms should work with a tar-ball of rear instead. Less convenient I think, but not impossible. We could also provide SVN/CVS to accomplish this. What does fedora recommend?

In the rpmls output all directories have mode 755. I think Robert question was to check if the /usr/share/rear directory was meant to be in read-only mode. The short answer is yes. During a normal run (mkrescue/mkbackup workflow) rear will not write nor modify anything under /usr/share/rear. We have /var/rear which will be used to create the recovery information under.

Do not hesitate to ask if you need more clarification. We're happy to answer and to comply as much as possible to fedora's rules.

best regards, Gratien

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

Andreas Thienemann andreas@bawue.net changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas@bawue.net

--- Comment #27 from Andreas Thienemann andreas@bawue.net 2009-02-13 17:38:09 EDT --- Hello Gratien,

Robert was kind enough to ask me whether I'd be willing to sponsor this.

A cursory glance at the spec looks good, but please add some linebreaks and \ to the long lines in the %install part of the .spec file. This makes things much easier to read.

The review looks okay so far, seems the .spec has come a long way. :)

As soon as Robert indicates he's finished I'll do a final test of the software and recheck the review. After that, I'd be happy to sponsor you.

That okay with you?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

Gratien D'haese gratien.dhaese@it3.be changed:

What |Removed |Added ---------------------------------------------------------------------------- Attachment #331310|0 |1 is obsolete| |

--- Comment #29 from Gratien D'haese gratien.dhaese@it3.be 2009-03-02 08:32:21 EDT --- Created an attachment (id=333734) --> (https://bugzilla.redhat.com/attachment.cgi?id=333734) Validation output of rear-1.7.16 package

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@ioa.s.u-tokyo.ac.jp

--- Comment #31 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-03-12 12:56:28 EDT --- Some remarks and questions

* Shipping "rear.8" as %doc is really confusing for this package - because the installed rear.8.gz man file (modified by sed command) _differs_ (i.e. is saying something different) sfrom the original rear.8 installed as %doc. Please remove "rear.8" from %doc

* The installed man files are actually gzipped by rpmbuild itself. Please leave stripping man files to rpmbuild and don't strip by yourself.

? It seems that this package installs somefiles which are related to the distributions different from Fedora (like /usr/share/rear/build/"Debian" or so). Would you explain why these files are needed?

? Would you check if your rpm work on 64 bits architecture?

For example, this package contains /usr/share/rear/skel/default/lib64 but does not have /usr/share/rear/skel/default/usr/lib64 . Is this as expected?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Flag| |fedora-review?

--- Comment #33 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-03-19 12:39:14 EDT --- (In reply to comment #32)

• we have tested rear on 64-bit platforms (AMD, IA64) and the lib64 stuff you

find under the skel directory are necessary (empty) directories where rear (in rescue mode) will copy files into (in the build area created for that purpose). All other necessary items (files, libraries) will be copied automatically by the rear mkrescue process. We have tested on fedora10 too.

- What I meant by the previous comment is that it looks strange that there is /usr/share/rear/skel/default/lib64 directory but /usr/share/rear/skel/default/usr/lib64 does not exist in this package, for example.

Assigning to myself.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

--- Comment #35 from Schlomo Schapiro redhat@schlomo.schapiro.org 2009-03-28 15:19:14 EDT --- Everybody who takes a closer look at the ReaR rescue system should keep in mind that we do not build a FHS compliant system but rather copy all binaries to /bin, all libraries to /lib (and /lib64 if appropriate) and some stuff to /usr/share (like termcap etc.).

We only keep lib and lib64 apart but do not support lib32 and bin32 or bin64 directories.

Therefore the directories under /usr (like bin,lib etc.) are only symlinks because some programs expect their binaries there.

Adding some more symlinks is not a problem, we have a script for that.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

--- Comment #37 from Gratien D'haese gratien.dhaese@it3.be 2009-03-30 14:00:50 EDT --- I've been involved with the following bug reports:

* Full reviews made for: 187318 Fedora Package Review NEW medium Review Request: mondo 473835 Fedora Package Review NEW medium Review Request: autoarchive - Simple backup tool 480851 Fedora Package Review NEW medium Review Request: ccrypt - Secure encryption and decryption of files and streams

* Involved with comments for: 463035 Fedora Package Review NEW medium Review Request: pyroman - Very fast firewall configuration tool 473184 Fedora Package Review NEW medium Review Request: clamz - Amazon Downloader 474802 Fedora Package Review NEW medium Review Request: vacation - Automatic mail answering program 491430 Fedora Package Review NEW medium Review Request: sslogger - A keystroke logging utility for privileged user escalation

If you need more info, do not hesitate to ask. Thanks. Gratien

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

--- Comment #39 from Gratien D'haese gratien.dhaese@it3.be 2009-03-30 15:07:47 EDT --- Great - thanks. I'll fix my mail account with fedora to become the same as FAS. Keep you informed when that is done. I'll read the docs first and if I'm stuck somewhere I'll let you know.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

--- Comment #41 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-03-31 11:33:25 EDT --- Okay, now I am sponsoring you. Please follow "Join" wiki again.

(In reply to comment #40)

Isn't it better to change this so we're compliant with FHS 2.2?

Actually we should use %_localstatedir/lib .

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

--- Comment #43 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-04-04 12:47:53 EDT --- Well, would you write CVS request?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

--- Comment #45 from Gratien D'haese gratien.dhaese@gmail.com 2009-04-08 05:42:06 EDT --- Sorry, used the wrong title (if some script searches this then it wouldn't catch it, right?)

New Package CVS Request ======================= Package Name: rear Short Description: Relax and Recover (ReaR) is a Linux Disaster Recovery framework Owners: gdha Branches: F-10 F-11 EL-5 InitialCC: gdha

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

Gratien D'haese gratien.dhaese@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

--- Comment #47 from Gratien D'haese gratien.dhaese@gmail.com 2009-04-08 07:03:07 EDT --- Oh dear - missed that one indeed - fedora-cvs has been set to ? now

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

--- Comment #49 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-04-12 12:34:56 EDT --- For F-10, please visit bodhi and submit request to push the rebuild package into repositories:

https://admin.fedoraproject.org/updates/

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

Jussi Lehtola jussi.lehtola@iki.fi changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@iki.fi Blocks|177841(FE-NEEDSPONSOR) |

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468189

--- Comment #52 from Jon Ciesla limb@jcomserv.net 2011-11-22 11:02:16 EST --- Git done (by process-git-requests).