[Bug 840109] New: Review Request: php-lessphp - A compiler for LESS written in PHP - package-review

List overview All Threads
Download

newer

[Bug 840109] New: Review Request: php-lessphp - A compiler for LESS written in PHP

older

[Bug 879749] New: Review Request:...

[Bug 842199] New: Review Request:...

Red Hat Bugzilla

13 Jul 2012 13 Jul '12

7:38 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=840109

Bug ID: 840109 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: php-lessphp - A compiler for LESS written in PHP Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: shawn.iwinski@gmail.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora

Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-lessphp.spec

SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-lessphp-0.3.5-1.fc17.src...

Description: lessphp is a compiler that generates CSS from a superset language which adds a collection of convenient features often seen in other languages. All CSS is compatible with LESS, so you can start using new features with your existing CSS.

It is designed to be compatible with less.js (http://lesscss.org/), and suitable as a drop in replacement for PHP projects.

Fedora Account System Username: siwinski

-- You are receiving this mail because: You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

29 Oct 29 Oct

7:18 a.m.

New subject: [Bug 840109] Review Request: php-lessphp - A compiler for LESS written in PHP

https://bugzilla.redhat.com/show_bug.cgi?id=840109

--- Comment #1 from Remi Collet fedora@famillecollet.com --- Could you update to latest version 0.3.8 before I do a formal review ?

Some notes

- you don't have to compress the generated man page (will be done by rpmbuild, and compression tool could change, one day)

- tests are currently installed in /usr/share/php, which is in the default include_path. There is no Guidelines about this, but I think it's a bad practice.

Please consider moving to /usr/share/tests/php-lessphp (you need to own /usr/share/tests or requires pear which own this dir)

- sed (to add shebang) is a bit hard to read.

Isn't simpler to use :

sed -e '1i#!/bin/bash\n' -i %{libname}/tests/bootstrap.sh

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

9 Nov 9 Nov

1:50 a.m.

New subject: [Bug 840109] Review Request: php-lessphp - A compiler for LESS written in PHP

https://bugzilla.redhat.com/show_bug.cgi?id=840109

--- Comment #2 from Shawn Iwinski shawn.iwinski@gmail.com --- (In reply to comment #1)

...

Could you update to latest version 0.3.8 before I do a formal review ?

Updated

...

Some notes

you don't have to compress the generated man page (will be done by

rpmbuild, and compression tool could change, one day)

Removed. I did not know about this. Thanks!

...

tests are currently installed in /usr/share/php, which is in the default

include_path. There is no Guidelines about this, but I think it's a bad practice.

Please consider moving to /usr/share/tests/php-lessphp (you need to own /usr/share/tests or requires pear which own this dir)

I have tried several ways to do this but I cannot come up with a "clean" solution (i.e. not hacking up the source and/or spec file). I will work with upstream to hopefully come up with a way to do this in a future release.

...

sed (to add shebang) is a bit hard to read.

Isn't simpler to use :

sed -e '1i#!/bin/bash\n' -i %{libname}/tests/bootstrap.sh

Fixed upstream via pull request :)

Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-lessphp.spec

SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-lessphp-0.3.8-1.fc17.src...

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

18 Nov 18 Nov

2:08 a.m.

New subject: [Bug 840109] Review Request: php-lessphp - A compiler for LESS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840109

--- Comment #3 from Shawn Iwinski shawn.iwinski@gmail.com --- Simplified the spec and moved tests.

Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-lessphp.spec

SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-lessphp-0.3.8-2.fc17.src...

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

6:48 a.m.

New subject: [Bug 840109] Review Request: php-lessphp - A compiler for LESS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840109

--- Comment #4 from Remi Collet fedora@famillecollet.com --- Build fails.

+ help2man --version-option=-v --no-info plessc help2man: can't get `--help' info from plessc Try `--no-discard-stderr' if option outputs to stderr

Probably because the package is not installed (plessc command not found)

Setting the path seems ok. help2man --version-option='-v' --no-info ./plessc

[!]: Package must own all directories that it creates. [!]: Package requires other packages for directories it uses.

As said in comment #1 you need to own /usr/share/tests or requires php-pear which own this dir

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

4:40 p.m.

New subject: [Bug 840109] Review Request: php-lessphp - A compiler for LESS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840109

--- Comment #5 from Shawn Iwinski shawn.iwinski@gmail.com --- - Fixed man page creation - Added tests directory ownership

Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-lessphp.spec

SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-lessphp-0.3.8-3.fc17.src...

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

7:07 p.m.

New subject: [Bug 840109] Review Request: php-lessphp - A compiler for LESS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840109

Remi Collet fedora@famillecollet.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |fedora@famillecollet.com

--- Comment #6 from Remi Collet fedora@famillecollet.com --- Created attachment 647273 --> https://bugzilla.redhat.com/attachment.cgi?id=647273&action=edit php-lessphp-review.txt

Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-17-x86_64 Command line :/usr/bin/fedora-review -r -n /dev/shm/extras/SRPMS/php-lessphp-0.3.8-3.fc17.src.rpm

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

7:08 p.m.

New subject: [Bug 840109] Review Request: php-lessphp - A compiler for LESS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840109

Remi Collet fedora@famillecollet.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+

--- Comment #7 from Remi Collet fedora@famillecollet.com --- === APPROVED ===

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

19 Nov 19 Nov

12:54 a.m.

New subject: [Bug 840109] Review Request: php-lessphp - A compiler for LESS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840109

Shawn Iwinski shawn.iwinski@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #8 from Shawn Iwinski shawn.iwinski@gmail.com --- Thanks for the review and all of the help and patience with this package!

New Package SCM Request ======================= Package Name: php-lessphp Short Description: A compiler for LESS written in PHP Owners: siwinski Branches: f17 f18 el6 InitialCC:

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

11:08 a.m.

New subject: [Bug 840109] Review Request: php-lessphp - A compiler for LESS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840109

--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

2:56 p.m.

New subject: [Bug 840109] Review Request: php-lessphp - A compiler for LESS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840109

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

2:56 p.m.

New subject: [Bug 840109] Review Request: php-lessphp - A compiler for LESS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840109

--- Comment #10 from Fedora Update System updates@fedoraproject.org --- php-lessphp-0.3.8-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-lessphp-0.3.8-3.fc18

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

2:56 p.m.

New subject: [Bug 840109] Review Request: php-lessphp - A compiler for LESS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840109

--- Comment #11 from Fedora Update System updates@fedoraproject.org --- php-lessphp-0.3.8-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-lessphp-0.3.8-3.fc17

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

2:56 p.m.

New subject: [Bug 840109] Review Request: php-lessphp - A compiler for LESS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840109

--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-lessphp-0.3.8-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-lessphp-0.3.8-3.el6

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

6:29 p.m.

New subject: [Bug 840109] Review Request: php-lessphp - A compiler for LESS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840109

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

6:29 p.m.

New subject: [Bug 840109] Review Request: php-lessphp - A compiler for LESS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840109

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- php-lessphp-0.3.8-3.el6 has been pushed to the Fedora EPEL 6 testing repository.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

23 Nov 23 Nov

7:45 a.m.

New subject: [Bug 840109] Review Request: php-lessphp - A compiler for LESS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840109

Fedora Update System updates@fedoraproject.org changed:

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

7:45 a.m.

New subject: [Bug 840109] Review Request: php-lessphp - A compiler for LESS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840109

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-lessphp-0.3.8-3.fc18 has been pushed to the Fedora 18 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

28 Nov 28 Nov

11:29 a.m.

New subject: [Bug 840109] Review Request: php-lessphp - A compiler for LESS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840109

--- Comment #15 from Fedora Update System updates@fedoraproject.org --- php-lessphp-0.3.8-3.fc17 has been pushed to the Fedora 17 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

4 Dec 4 Dec

7:58 p.m.

New subject: [Bug 840109] Review Request: php-lessphp - A compiler for LESS written in PHP

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840109

--- Comment #16 from Fedora Update System updates@fedoraproject.org --- php-lessphp-0.3.8-3.el6 has been pushed to the Fedora EPEL 6 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug.

4225

Age (days ago)

4369

Last active (days ago)

package-review@lists.fedoraproject.org

19 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla