Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: vanessa_socket - Simplify TCP/IP socket operations
https://bugzilla.redhat.com/show_bug.cgi?id=518318
Summary: Review Request: vanessa_socket - Simplify TCP/IP socket operations Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: pahan@hubbitus.info QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://hubbitus.net.ru/rpm/Fedora11/vanessa_socket/vanessa_socket.spec SRPM URL: http://hubbitus.net.ru/rpm/Fedora11/vanessa_socket/vanessa_socket-0.0.7-2.fc... Description: Library to simplify TCP/IP socket operations. Includes code to open a socket to a server as a client, to listen on socket for clients as a server and to pipe information between sockets.
P.S. In spec used 5 space tab width.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518318
Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |518315
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518318
Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |518317
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518318
--- Comment #1 from Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info 2009-08-22 17:40:30 EDT --- Small fix: http://hubbitus.net.ru/rpm/Fedora11/vanessa_socket/vanessa_socket-0.0.7-3.fc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518318
--- Comment #2 from Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info 2009-08-24 15:20:11 EDT --- http://hubbitus.net.ru/rpm/Fedora11/vanessa_socket/vanessa_socket-0.0.7-4.fc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518318
Joshua Roys roysjosh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |roysjosh@gmail.com
--- Comment #3 from Joshua Roys roysjosh@gmail.com 2009-12-14 12:49:09 EDT --- Hello,
Version 0.0.7 seems to be a bit out of date; 0.0.10 is out. Also, the Source0 line is not accessible (no ftp anymore).
Why tabsize of 5? It just seems non-standard :) Don't suppose I could convince you to use 4 or 8 or to just use spaces? Do we really need that ugly looking thing above the %configure?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518318
--- Comment #4 from Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info 2009-12-20 17:53:36 EDT --- (In reply to comment #3)
Hello,
Version 0.0.7 seems to be a bit out of date; 0.0.10 is out. Also, the Source0 line is not accessible (no ftp anymore).
You are rigth. Updated.
http://hubbitus.net.ru/rpm/Fedora11/vanessa_socket/vanessa_socket-0.0.10-5.f... http://hubbitus.net.ru/rpm/Fedora11/vanessa_socket/vanessa_socket.spec
Why tabsize of 5? It just seems non-standard :) Don't suppose I could convince you to use 4 or 8 or to just use spaces? Do we really need that ugly looking thing above the %configure?
https://fedoraproject.org/wiki/PavelAlexeev/tabsize
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518318
--- Comment #5 from Joshua Roys roysjosh@gmail.com 2010-01-04 10:52:28 EDT --- (In reply to comment #4)
Why tabsize of 5? It just seems non-standard :) Don't suppose I could convince you to use 4 or 8 or to just use spaces?
That's fine - it is your choice at this point. I was just curious.
Do we really need that ugly looking thing above the %configure?
This was a separate question. Why do we need to run all the autotools by hand? Does it still work if we remove them? Do we need to mess with CFLAGS?
You updated the BuildRequires but not the Requires?
You have some single %s in the changelog, 0.0.7-3, line 2, at the end.
Thanks.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518318
--- Comment #6 from Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info 2010-01-05 05:37:31 EDT --- (In reply to comment #5)
At least we are talking about the subject.
This was a separate question. Why do we need to run all the autotools by hand? Does it still work if we remove them? Do we need to mess with CFLAGS?
Thanks, I remove all this stuff.
You updated the BuildRequires but not the Requires?
Thanks, fixed.
You have some single %s in the changelog, 0.0.7-3, line 2, at the end.
Sorry, I don't understand about what "%s" you are speak. I search and in spec "%s" is not found at all.
http://hubbitus.net.ru/rpm/Fedora11/vanessa_socket/vanessa_socket-0.0.10-6.f...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518318
Michael Schwendt mschwendt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |NotReady
--- Comment #9 from Michael Schwendt mschwendt@gmail.com 2010-01-15 07:24:05 EST ---
Requires: vanessa_logger >= 0.0.8
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires
%package devel ... Requires: vanessa_logger-devel >= 0.0.5
Questionable version here. Above it's 0.0.8, in the BuildRequires it's 0.0.8, and here it's 0.0.5.
Group: Development/Libraries
Run-time libraries still belong into group "System Environment/Libraries".
vanessa_socket_daemon.c
This file is in need of a licence clarification by its author. It's likely he just forgot to replace the GPLv2+ header, but as long as that one is present, the following guideline applies:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Mixed_Source_Li...
mkdir -p %{buildroot}/{etc,%{prefix}/{lib,bin,doc}}
This doesn't look right. If creating %prefix/lib is really needed, the build will fail on 64-bit where %prefix/lib64 would not be created. And %prefix/doc isn't used by the %files section.
%doc README
The file is duplicated in two packages. In the base library package the file contents refers to "vanessa_socket_pipe", which is not included in that package. Nothing explains where to find the missing vanessa_socket_pipe. And in the separate vanessa_socket-pipe package, the same README file refers to the library. => Splitting off the vanessa_socket_pipe program is highly questionable. Especially, since the base library package contains another program in /usr/bin already, so nothing is won by splitting off one tool.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518318
--- Comment #10 from Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info 2010-01-24 17:20:34 EST --- (In reply to comment #7)
Here are some more comments that should be useful:
- libvanessa_socket/vanessa_socket_daemon.c is GPLv2+, not LGPLv2+, so I'm
fairly certain the license field needs to change.
You are right.
- You actually do need to run autotools because the stock configure script adds
an RPATH: vanessa_socket.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/vanessa_gethostbyname ['/usr/lib64'] vanessa_socket-pipe.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/vanessa_socket_pipe ['/usr/lib64']
Hm, it is strange, because is not appeared in i586 architecture! Thank you. Joshua Roys, also thanks, I follow this guidelines to cut off it.
- The only other complaint rpmlint has relates to a lack of %doc files in the
devel subpackage; I'm not sure how important that is here. vanessa_socket-devel.x86_64: W: no-documentation
It is not important in -devel sub-package.
(In reply to comment #9)
Requires: vanessa_logger >= 0.0.8
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires
%package devel ... Requires: vanessa_logger-devel >= 0.0.5
Questionable version here. Above it's 0.0.8, in the BuildRequires it's 0.0.8, and here it's 0.0.5.
Fixed, thanks.
Group: Development/Libraries
Run-time libraries still belong into group "System Environment/Libraries".
Ok, changed. Please, can you provide link where I can read about it more?
vanessa_socket_daemon.c
This file is in need of a licence clarification by its author. It's likely he just forgot to replace the GPLv2+ header, but as long as that one is present, the following guideline applies:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Mixed_Source_Li...
I ask Simon Horman, wait answer.
mkdir -p %{buildroot}/{etc,%{prefix}/{lib,bin,doc}}
This doesn't look right. If creating %prefix/lib is really needed, the build will fail on 64-bit where %prefix/lib64 would not be created. And %prefix/doc isn't used by the %files section.
It was built on x86_64 successfully.
But you are right, it is ambiguous line at all.
%doc README
The file is duplicated in two packages. In the base library package the file contents refers to "vanessa_socket_pipe", which is not included in that package. Nothing explains where to find the missing vanessa_socket_pipe. And in the separate vanessa_socket-pipe package, the same README file refers to the library. => Splitting off the vanessa_socket_pipe program is highly questionable. Especially, since the base library package contains another program in /usr/bin already, so nothing is won by splitting off one tool.
This splitting and README duplication comes from history based author spec. READMY contains generic information about author, licensing and both subpackages. I think there no error include it in both.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1941649 http://hubbitus.net.ru/rpm/Fedora11/vanessa_socket/vanessa_socket-0.0.10-7.f...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518318
Frank DiPrete fdiprete@comcast.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fdiprete@comcast.net
--- Comment #11 from Frank DiPrete fdiprete@comcast.net 2010-01-25 08:55:58 EST ---
mkdir -p %{buildroot}/{etc,%{prefix}/{lib,bin,doc}}
libdir=%{?buildroot:%{buildroot}}%{_libdir} bindir=%{?buildroot:%{buildroot}}%{_bindir} _defaultdocdir %{_usr}/share/doc
from rpmbuild --showrc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518318
--- Comment #12 from Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info 2010-01-25 11:31:42 EST --- Frank DiPrete, I don't understand what you want say. Explicit directory creation deleted and have not use in spec now.
I got answer from upstream developer. Simon Horman wrote what it is really mistake and license should be LGPLv2+! I revert back it.
http://hubbitus.net.ru/rpm/Fedora11/vanessa_socket/vanessa_socket-0.0.10-8.f...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518318
--- Comment #13 from Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info 2010-01-25 11:31:58 EST --- http://hg.vergenet.net/vanessa/vanessa_socket/rev/1e82bd57c239
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518318
Orion Poplawski orion@cora.nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |orion@cora.nwra.com Flag| |needinfo?(pahan@hubbitus.in | |fo)
--- Comment #14 from Orion Poplawski orion@cora.nwra.com 2012-02-27 13:29:34 EST --- None of the spec/src.rpm links above work anymore. Pavel - Are you still around?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518318
Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(pahan@hubbitus.in | |fo) |
--- Comment #15 from Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info 2012-03-01 14:29:11 EST --- Sorry, domain changed.
Yes, I ready continue. Package updated to last version.
http://hubbitus.info/rpm/Fedora16/vanessa_socket/vanessa_socket-0.0.12-1.fc1... http://hubbitus.info/rpm/Fedora16/vanessa_socket/vanessa_socket.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518318
Orion Poplawski orion@cora.nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |orion@cora.nwra.com Status Whiteboard|NotReady | Flag| |fedora-review?
--- Comment #16 from Orion Poplawski orion@cora.nwra.com 2012-03-14 14:27:19 EDT --- rpmlint:
vanessa_socket.i686: W: unused-direct-shlib-dependency /usr/lib/libvanessa_socket.so.2.1.0 /lib/libdl.so.2
Looks like libvanessa_socket.so.2.1.0 does not need to be linked against -ldl.
vanessa_socket.i686: E: incorrect-fsf-address /usr/share/doc/vanessa_socket-0.0.12/README vanessa_socket-pipe.i686: E: incorrect-fsf-address /usr/share/doc/vanessa_socket-pipe-0.0.12/COPYING
FSF now just uses their url:
You should have received a copy of the GNU General Public License along with this program. If not, see http://www.gnu.org/licenses/.
Please notify upstream.
More to come....
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518318
--- Comment #17 from Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info 2012-03-17 09:01:51 EDT --- Thanks. Both questions mailed to upstream author.
package-review@lists.fedoraproject.org