[Bug 426885] New: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5 - package-review

List overview All Threads
Download

newer

[Bug 426885] New: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

older

[Bug 428237] New: Review Request:...

[Bug 209522] New: Review Request:...

Red Hat Bugzilla

27 Dec 2007 27 Dec '07

3:19 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=426885

Summary: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5 Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: andreas.bierfert@lowlatency.de QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com

Spec URL: http://fedora.lowlatency.de/review/odccm.spec SRPM URL: http://fedora.lowlatency.de/review/odccm-0.10.0-1.fc9.src.rpm Description: Odccm is a legacy-free dccm-implementation for Windows Mobile 5 (and newer) devices.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Show replies by date

Red Hat Bugzilla

28 Dec 28 Dec

2:43 a.m.

New subject: [Bug 426885] Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

https://bugzilla.redhat.com/show_bug.cgi?id=426885

panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@gmail.com

------- Additional Comments From panemade@gmail.com 2007-12-28 05:43 EST ------- rpmlint on RPM reported as => odccm.i386: E: setuid-binary /usr/sbin/odccm root 04755 ==> The file is setuid, this may be dangerous, especially if this file is setuid root.

odccm.i386: E: non-standard-executable-perm /usr/sbin/odccm 04755 ==> A standard executable should have permission set to 0755. If you get this message, it means that you have a wrong executable permissions in some files included in your package.

odccm.i386: W: conffile-without-noreplace-flag /etc/dbus-1/system.d/odccm.conf ==> A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file:

%config(noreplace) /etc/your_config_file_here

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

3:10 a.m.

New subject: [Bug 426885] Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

https://bugzilla.redhat.com/show_bug.cgi?id=426885

------- Additional Comments From andreas.bierfert@lowlatency.de 2007-12-28 06:10 EST ------- Well while I don't like either one they are all 'ok' from the package side. Odccm needs to be setuid for now. Imho also the dbus config should not be noreplace because it sets the dbus behavior and may change and should be replaced then.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

5 Jan 5 Jan

4:06 a.m.

New subject: [Bug 426885] Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

https://bugzilla.redhat.com/show_bug.cgi?id=426885

------- Additional Comments From andreas.bierfert@lowlatency.de 2008-01-05 07:06 EST ------- http://fedora.lowlatency.de/review/odccm-0.11-0.1.3141svn.fc9.src.rpm http://fedora.lowlatency.de/review/odccm.spec

This one should resolve the setuid issue. I have been talking to upstream and odccm is now started via init.d.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

6 Jan 6 Jan

4:20 a.m.

New subject: [Bug 426885] Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

https://bugzilla.redhat.com/show_bug.cgi?id=426885

------- Additional Comments From gauret@free.fr 2008-01-06 07:20 EST ------- rpmlint says : - missing-mandatory-lsb-keyword Provides in /etc/rc.d/init.d/odccm - zero-length /usr/share/doc/odccm-0.11/NEWS (not really a problem IMHO)

Odccm listens by default on all interfaces, and is started by default in the init script. Please make it listen on localhost if possible, and if it's not don't start it by default (security risk)

Thanks, it's looking good !

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

7 Jan 7 Jan

12:05 a.m.

New subject: [Bug 426885] Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

https://bugzilla.redhat.com/show_bug.cgi?id=426885

------- Additional Comments From andreas.bierfert@lowlatency.de 2008-01-07 03:05 EST ------- http://fedora.lowlatency.de/review/odccm-0.11-0.2.3141svn.fc9.src.rpm

This should do the trick.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

3:07 p.m.

New subject: [Bug 426885] Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

https://bugzilla.redhat.com/show_bug.cgi?id=426885

------- Additional Comments From andreas.bierfert@lowlatency.de 2008-01-07 18:07 EST ------- Small fix to start the service later in the init cycle. Also the right fix for non default starting.

http://fedora.lowlatency.de/review/odccm-0.11-0.3.3141svn.fc9.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

7:28 p.m.

New subject: [Bug 426885] Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

https://bugzilla.redhat.com/show_bug.cgi?id=426885

------- Additional Comments From panemade@gmail.com 2008-01-07 22:28 EST ------- with updated SRPM I got rpmlint to say

odccm.i386: W: conffile-without-noreplace-flag /etc/dbus-1/system.d/odccm.conf A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file:

%config(noreplace) /etc/your_config_file_here

odccm.i386: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/odccm The package contains an init script but doesn't contain a %post with a call to chkconfig.

odccm.i386: W: service-default-enabled /etc/rc.d/init.d/odccm The service is enabled by default after "chkconfig --add"; for security reasons, most services should not be. Use "-" as the default runlevel in the init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword to fix this if appropriate for this service.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

11:54 p.m.

New subject: [Bug 426885] Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

https://bugzilla.redhat.com/show_bug.cgi?id=426885

------- Additional Comments From andreas.bierfert@lowlatency.de 2008-01-08 02:54 EST ------- Sorry my bad. Here is a version which finally fixes all the init stuff.

Regarding the dbus file: As with other packages the dbus config files should not be marked noreplace... so this warning from rpmlint can be ignored.

http://fedora.lowlatency.de/review/odccm-0.11-0.4.3141svn.fc9.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

8 Jan 8 Jan

12:10 a.m.

New subject: [Bug 426885] Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

https://bugzilla.redhat.com/show_bug.cgi?id=426885

panemade@gmail.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

9 Jan 9 Jan

7:26 a.m.

New subject: [Bug 426885] Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

https://bugzilla.redhat.com/show_bug.cgi?id=426885

------- Additional Comments From andreas.bierfert@lowlatency.de 2008-01-09 10:26 EST ------- http://fedora.lowlatency.de/review/odccm-0.11-1.fc9.x86_64.rpm

Final version + I removed synce-gnome. I will submit it as a separate package.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

7:43 p.m.

New subject: [Bug 426885] Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

https://bugzilla.redhat.com/show_bug.cgi?id=426885

------- Additional Comments From panemade@gmail.com 2008-01-09 22:43 EST ------- SRPM please?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

11:46 p.m.

New subject: [Bug 426885] Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

https://bugzilla.redhat.com/show_bug.cgi?id=426885

------- Additional Comments From andreas.bierfert@lowlatency.de 2008-01-10 02:46 EST ------- uh sorry c&p error http://fedora.lowlatency.de/review/odccm-0.11-1.fc9.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10 Jan 10 Jan

12:16 a.m.

New subject: [Bug 426885] Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

https://bugzilla.redhat.com/show_bug.cgi?id=426885

andreas.bierfert@lowlatency.de changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

12:43 a.m.

New subject: [Bug 426885] Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

https://bugzilla.redhat.com/show_bug.cgi?id=426885

------- Additional Comments From panemade@gmail.com 2008-01-10 03:43 EST ------- Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM. But NOT for RPM. odccm.i386: W: conffile-without-noreplace-flag /etc/dbus-1/system.d/odccm.conf =>Ok for this package + source files match upstream. ed830920a91573215d2497c09bd5a310 odccm-0.11.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + chkconfig scriptlets are used. + Package odccm-0.11-1.fc9 => Provides: config(odccm) = 0.11-1.fc9 Requires: /bin/bash config(odccm) = 0.11-1.fc9 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libdbus-1.so.3 libdbus-glib-1.so.2 libglib-2.0.so.0 libgnet-2.0.so.0 libgobject-2.0.so.0 libgthread-2.0.so.0 libhal.so.1 libpthread.so.0 libpthread.so.0(GLIBC_2.0) librt.so.1 libsynce.so.0 + Not a GUI app.

APPROVED.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

12:45 a.m.

New subject: [Bug 426885] Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

https://bugzilla.redhat.com/show_bug.cgi?id=426885

panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

1:13 a.m.

New subject: [Bug 426885] Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

https://bugzilla.redhat.com/show_bug.cgi?id=426885

andreas.bierfert@lowlatency.de changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

------- Additional Comments From andreas.bierfert@lowlatency.de 2008-01-10 04:13 EST ------- New Package CVS Request ======================= Package Name: odccm Short Description: Connection daemon for Pocket PC devices Owners: awjb Branches: F-8 Cvsextras Commits: yes

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

8:40 a.m.

New subject: [Bug 426885] Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

https://bugzilla.redhat.com/show_bug.cgi?id=426885

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2008-01-10 11:40 EST ------- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

2:16 p.m.

New subject: [Bug 426885] Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

https://bugzilla.redhat.com/show_bug.cgi?id=426885

andreas.bierfert@lowlatency.de changed:

------- Additional Comments From andreas.bierfert@lowlatency.de 2008-01-10 17:16 EST ------- Thanks for the review.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

6014

Age (days ago)

6028

Last active (days ago)

package-review@lists.fedoraproject.org

18 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla