Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491875 Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jussi.lehtola(a)iki.fi AssignedTo|nobody(a)fedoraproject.org |jussi.lehtola(a)iki.fi Flag| |fedora-review? --- Comment #2 from Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; 2009-03-24 17:48:46 EDT --- Taking on review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491875 --- Comment #4 from Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; 2009-03-24 18:01:28 EDT --- And yes: you should use %{?dist} in the Release line. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491875 --- Comment #6 from Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; 2009-03-25 03:15:48 EDT --- (In reply to comment #5) Right you are: only the value of the last argument is used. Thanks. John: Please remove the -O flag, since %{optflags} already contain the necessary optimizations. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491875 --- Comment #8 from Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; 2009-03-25 14:39:23 EDT --- Review: rpmlint output: unzoo.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 25) unzoo.src: W: no-version-in-last-changelog unzoo.x86_64: W: no-version-in-last-changelog unzoo.x86_64: W: unstripped-binary-or-object /usr/bin/unzoo 2 packages and 0 specfiles checked; 0 errors, 4 warnings. MUST: - Add versions to changelog. - Get rpmbuild to strib binary and build debuginfo package. I have no idea why it isn't doing that at the moment... MUST: The spec file for the package is legible and macros are used consistently. OK MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. OK MUST: Packages containing shared library files must call ldconfig. OK MUST: A package must own all directories that it creates or require the package that owns the directory. OK MUST: Files only listed once in %files listings. OK MUST: Permissions on files must be set properly. OK MUST: Clean section exists. OK MUST: Large documentation files must go in a -doc subpackage. OK MUST: Items in %doc do not affect runtime of application. OK MUST: Header files must be in a -devel package. OK MUST: Static libraries must be in a -static package. OK MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. OK MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. OK MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. OK MUST: Packages does not contain any .la libtool archives. OK MUST: Desktop files are installed properly. OK MUST: No file conflicts with other packages and no general names. OK MUST: Buildroot cleaned before install. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. ~OK SHOULD: The package builds in mock. OK -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491875 Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(jussi.lehtola@iki | |.fi) | --- Comment #10 from Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; 2009-03-26 13:19:15 EDT --- rpmlint output is now clean, however the debuginfo package is not complete: the source code is missing from it. Copy the source file to the build directory, then the source code is included in debuginfo. Your setup and build phases should like the following: %setup -Tc -n %{name}-%{version} cp -a %{SOURCE0} . cat unzoo.c | sed -e '/SYNTAX/,/\*\//!d' | cut -c5- > unzoo.txt %build gcc %{optflags} -o unzoo -DSYS_IS_UNIX unzoo.c PS. Don't put the dist tag in the changelog, since you can use the same spec to build on any Fedora/RHEL release. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491875 Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review?, |fedora-review+ |needinfo?(jussi.lehtola@iki | |.fi) | --- Comment #12 from Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; 2009-03-27 03:13:53 EDT --- No need to tag NEEDINFO every time you update the spec :) OK, now the package looks better. btw, you can see the file list simply by using rpm -qpl, no need for rpm2cpio... The package adheres to the guidelines and is thus APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491875 Dennis Gilmore <dennis(a)ausil.us&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+ --- Comment #14 from Dennis Gilmore <dennis(a)ausil.us&gt; 2009-04-01 12:36:30 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491875 John W. Linville <linville(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491875 --- Comment #17 from Fedora Update System <updates(a)fedoraproject.org&gt; 2009-04-02 13:13:05 EDT --- unzoo-4.4-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.