Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502926 Peter Lemenkov <lemenkov(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lemenkov(a)gmail.com --- Comment #1 from Peter Lemenkov <lemenkov(a)gmail.com&gt; 2009-05-28 08:59:28 EDT --- I'm sure that proper versioning scheme is Version: 0.9.1 Release: 0.1.pre_rev730%{?dist} -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502926 Adam Williamson <awilliam(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |awilliam(a)redhat.com --- Comment #3 from Adam Williamson <awilliam(a)redhat.com&gt; 2009-06-01 19:00:25 EDT --- oh...crap. i didn't realize someone else had done this :(. here's my take: https://bugzilla.redhat.com/show_bug.cgi?id=503616 i did say on the list i'd do this one...sigh. peter: I think we try to avoid unnecessary capitalization, right? that's why I used sk1. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502926 Peter Lemenkov <lemenkov(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody(a)fedoraproject.org |lemenkov(a)gmail.com Flag| |fedora-review? --- Comment #5 from Peter Lemenkov <lemenkov(a)gmail.com&gt; 2009-06-22 07:24:29 EDT --- I'll review it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502926 Alexey Torkhov <atorkhov(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |atorkhov(a)gmail.com --- Comment #7 from Alexey Torkhov <atorkhov(a)gmail.com&gt; 2009-06-24 06:55:32 EDT --- (In reply to comment #3) According to name guidelines, package should be called after how upstream call the project, and they call it "sK1". https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Case_Sensitivity -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502926 --- Comment #9 from Peter Lemenkov <lemenkov(a)gmail.com&gt; 2009-06-29 07:40:35 EDT --- Notes: * Wrong category for desktop-file-install. It should be "Graphics" instead of "Development". Easy to fix. * Since it provides skencil and sketch, I suggest you to add "Obsoletes" for sketch as well. However, I'm not sure about it, since I cannot remember, did sketch was included in Fedora or not. Anyway, here is my REVIEW: - rpmlint is not silent: [petro@Workplace Desktop]$ rpmlint sK1-0.9.1-0.1.pre_rev730.fc12.i586.rpm sK1.i586: E: non-executable-script /usr/lib/python2.6/site-packages/sk1/__init__.py 0644 1 packages and 0 specfiles checked; 1 errors, 0 warnings. [petro@Workplace Desktop]$ This file contains shebang, and therefore rpmlint thinks of its as a script. Easyfix. + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines . + The License field in the package spec file matches the actual license. + The files, containing the text of the license(s) for the package, are included in %doc. + The spec file is written in American English. + The spec file for the package is legible (as usual for python apps and libraries). +/- The sources used to build the package matches the upstream source, as provided in the spec URL. Unfortunately, your URL is wrong. Please fix it [petro@Sulaco SOURCES]$ sha256sum sk1-0.9.1pre_rev730.tar.gz* 56d4b58d30b52e97dccb81ce157e41c2b6b5f0c0c383b0f4c55bacb317443c84 sk1-0.9.1pre_rev730.tar.gz 56d4b58d30b52e97dccb81ce157e41c2b6b5f0c0c383b0f4c55bacb317443c84 sk1-0.9.1pre_rev730.tar.gz.1 [petro@Sulaco SOURCES]$ + The package successfully compiles and builds into binary rpms on at least one primary architecture. See koji link above. + All build dependencies are listed in BuildRequires. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. + No extra large documentation files. + Everything, the package includes as %doc, does not affect the runtime of the application. + The package includes a %{name}.desktop file, and that file is properly installed with desktop-file-install in the %install section. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. Please fix mentioned issues. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502926 Peter Lemenkov <lemenkov(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #11 from Peter Lemenkov <lemenkov(a)gmail.com&gt; 2009-06-30 15:11:10 EDT --- Ok, all issues were fixed. This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502926 Louis Lagendijk <louis(a)lagendijk.xs4all.nl&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |louis(a)lagendijk.xs4all.nl --- Comment #13 from Louis Lagendijk <louis(a)lagendijk.xs4all.nl&gt; 2009-06-30 16:17:28 EDT --- Please check if the description is ok. I believe that using registered trade names is not allowed...... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502926 Jason Tibbitts <tibbs(a)math.uh.edu&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+ --- Comment #15 from Jason Tibbitts <tibbs(a)math.uh.edu&gt; 2009-06-30 22:43:34 EDT --- CVS done. Note that I created the package as you requested, "sK1" with a capital K, but I'm not really sure that's what you intended. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502926 --- Comment #17 from Fedora Update System <updates(a)fedoraproject.org&gt; 2009-06-30 23:20:31 EDT --- sK1-0.9.1-0.1.pre_rev730.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/sK1-0.9.1-0.1.pre_rev730.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502926 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |0.9.1-0.1.pre_rev730.fc10 Resolution| |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502926 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0.9.1-0.1.pre_rev730.fc10 |0.9.1-0.1.pre_rev730.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.