https://bugzilla.redhat.com/show_bug.cgi?id=2013614 Ibiam <ibiamchihurumnaya(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |sugar-view-slides - <short |sugar-view-slides - The |summary here> |View Slides activity is | |meant to allow the user to | |read, view the contents of | |a Zip file Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2013614

https://bugzilla.redhat.com/show_bug.cgi?id=2013614 Robby Callicotte <rcallicotte(a)protonmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcallicotte(a)protonmail.com --- Comment #1 from Robby Callicotte <rcallicotte(a)protonmail.com&gt; --- Hello, I am not a packager yet, so this is an unofficial review. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/sugar-view-slides See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Final provides and requires are sane (see attachments). [!]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: sugar-view-slides-15-1.fc36.noarch.rpm sugar-view-slides-15-1.fc36.src.rpm sugar-view-slides.noarch: E: invalid-lc-messages-dir /usr/share/locale/aym/LC_MESSAGES/org.laptop.ViewSlidesActivity.mo 2 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- http://download.sugarlabs.org/sources/honey/ViewSlides/ViewSlides-15.tar.bz2 : CHECKSUM(SHA256) this package : 8654c861a058ae1c81dd23e5022a09007dcda0bb95fb0072d84bd2e2b0b67732 CHECKSUM(SHA256) upstream package : 8654c861a058ae1c81dd23e5022a09007dcda0bb95fb0072d84bd2e2b0b67732 Requires -------- sugar-view-slides (rpmlib, GLIBC filtered): /usr/bin/python3 python3-pygame sugar Provides -------- sugar-view-slides: sugar-view-slides Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -n sugar-view-slides Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Haskell, fonts, Python, SugarActivity, Java, PHP, Perl, Ocaml, C/C++, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH --Robby -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2013614

https://bugzilla.redhat.com/show_bug.cgi?id=2013614 Ben Beasley <code(a)musicinmybrain.net&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code(a)musicinmybrain.net --- Comment #3 from Ben Beasley <code(a)musicinmybrain.net&gt; --- Fixed spec URL: https://src.fedoraproject.org/rpms/sugar-view-slides/raw/rawhide/f/sugar-... -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2013614

https://bugzilla.redhat.com/show_bug.cgi?id=2013614 --- Comment #5 from Ibiam <ibiamchihurumnaya(a)gmail.com&gt; --- (In reply to Miro Hrončok from comment #4) I used %build and %install to maintain the convention used for the sugar packages, thanks for letting me know about %py3_build and %py3_install. I'll look at switching them. The desktop files create icons for running activities outside of sugar on other desktop environments and running an activity from it's icon was made to be just from the sugar desktop, that's why they're removed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2013614

https://bugzilla.redhat.com/show_bug.cgi?id=2013614 Ibiam Chihurumnaya <ibiam(a)sugarlabs.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody(a)fedoraproject.org |ibiam(a)sugarlabs.org -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2013614

https://bugzilla.redhat.com/show_bug.cgi?id=2013614 Ibiam Chihurumnaya <ibiam(a)sugarlabs.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ibiam(a)sugarlabs.o |needinfo?(mhroncok(a)redhat.c |rg) |om) CC| |mhroncok(a)redhat.com --- Comment #8 from Ibiam Chihurumnaya <ibiam(a)sugarlabs.org&gt; --- @mhroncok(a)redhat.com Is there anything that's needed from me here? I've been waiting for this to be reviewed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2013614 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

https://bugzilla.redhat.com/show_bug.cgi?id=2013614 Ibiam Chihurumnaya <ibiam(a)sugarlabs.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |COMPLETED Last Closed| |2023-10-17 11:57:35 --- Comment #10 from Ibiam Chihurumnaya <ibiam(a)sugarlabs.org&gt; --- Closing this as the package is no longer orphaned and has been updated. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2013614 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...