Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cobbler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192311 jpmahowald(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink(a)leemhuis.info |jpmahowald(a)gmail.com OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From jpmahowald(a)gmail.com 2006-05-20 21:01 EST ------- rpmlint: E: cobbler description-line-too-long Cobbler is a command line tool for simplified configuration of boot/provisioning servers. It is also accessible as a Python library. Cobbler supports PXE, Xen, and re-provisioning an existing Linux system via auto-kickstart. The last two modes require 'koan' to be run on the remote system. Wrap at 80 characters. E: cobbler no-changelogname-tag You need a %changelog E: cobbler non-executable-script /usr/lib/python2.4/site-packages/cobbler/cobbler.py 0644 Begins with #!/usr/bin/python, ignorable. * Package is marked as relocatable, please check. (wiki: Packaging/Guidelines#RelocatablePackages) * Spec file: tag Vendor is forbidden (wiki: Packaging/Guidelines#tags) * No downloadable source. Please give the full URL in the Source tag. * The BuildRoot must be cleaned at the beginning of %install -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cobbler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192311 ------- Additional Comments From mdehaan(a)redhat.com 2006-06-28 17:50 EST ------- All items are now fixed except for the part about the 'dist tag', which I did not understand, and the relocatable part, which AFAIK, I have not marked the package relocatable. Pointers on these two items would be greatly appreciated. I've updated the src rpms, noarch rpms, and spec files accordingly. === Wrap at 80 characters. * Fixed E: cobbler no-changelogname-tag You need a %changelog * Fixed E: cobbler non-executable-script /usr/lib/python2.4/site-packages/cobbler/cobbler.py 0644 Begins with #!/usr/bin/python, ignorable. * Fixed anyway Package is marked as relocatable, please check. (wiki: Packaging/Guidelines#RelocatablePackages) * I don't see "relocatable" in the spec file. So I'm not sure how the package is marked as such. Spec file: tag Vendor is forbidden (wiki: Packaging/Guidelines#tags) * Fixed No downloadable source. Please give the full URL in the Source tag. * Fixed. The source is also in the bugzilla entry at the top of this page. The BuildRoot must be cleaned at the beginning of %install * Fixed. Also You need to use dist tag instead of coding release * Can you elaborate on what needs to be done here? Source tag is not a URL * Fixed Add Changelog * Fixed === -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cobbler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192311 mdehaan(a)redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |192313 nThis| | -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cobbler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192311 ------- Additional Comments From mdehaan(a)redhat.com 2006-07-05 12:17 EST ------- please increment the release every time you make some changes. -- The installed product didn't technically change. Regardless, this can be done. Don't bother with defining your own macros for name, version, and release, rpm does that. -- If I remove the version macro, 'version' will be seperately hard coded into 3 parts of the file. Having the version macro at the top of the file is most convient for editing and is very much D.R.Y. If i need to call it something other than 'version', this can be done, though I need to understand the technical reason for this. Typically the URL points at an informational page. Does one exist? -- Not *yet*. Full documentation is provided in the man pages and can be saved to file if required. Seems INSTALLED_FILES doesn't list directories, so don't use that. -- Directories will be added. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cobbler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192311 ------- Additional Comments From mdehaan(a)redhat.com 2006-07-10 18:44 EST ------- Updated. - added doc URL - added directories - removed redundant macros - bumped release New RPM: http://et.redhat.com/~mdehaan/software/cobbler/cobbler-0.1.0-2.src.rpm New spec file: http://et.redhat.com/~mdehaan/software/cobbler/cobbler.spec Documentation URL as listed in spec: http://et.redhat.com/page/Cobbler_%26_Koan_Provisioning_Tools (largely a manpage copy for now) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cobbler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192311 ------- Additional Comments From mdehaan(a)redhat.com 2006-07-11 18:34 EST ------- Thanks. Fixed (per my email to David) at 17:38 EST. Same URLs are still valid. The setup.py file was not updated after doing some work to make the code build/run on RHEL, which involved swapping out yaml modules. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cobbler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192311 ------- Additional Comments From mdehaan(a)redhat.com 2006-07-20 16:53 EST ------- I see no one has attempted to run the code yet :) Several of our development systems are tainted from having a yaml module installed on them that RHN uses, therefore I didn't detect that the load paths from the yaml module were not correct. These are corrected versions of cobber with relative imports: http://et.redhat.com/~mdehaan/software/cobbler/cobbler-0.1.1-4.src.rpm http://et.redhat.com/~mdehaan/software/cobbler/cobbler.spec For convience of anyone wanting to try this out, I also have uploaded noarch's. http://et.redhat.com/~mdehaan/software/cobbler/cobbler-0.1.1-4.noarch.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cobbler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192311 tibbs(a)math.uh.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs(a)math.uh.edu ------- Additional Comments From tibbs(a)math.uh.edu 2006-08-14 11:01 EST ------- The stalled review policy indicates that we give John one more week to respond and then he can be unassigned from the package. However, just a quick once over from me: Source0: does not contain a URL to the upstream tarball. I'd consider this a blocker unless somehow there is no upstream other than this package. rpmlint on SRPM says: W: cobbler strange-permission cobbler.spec 01664 Really odd for the sticky bit to be set on a spec file. W: cobbler setup-not-quiet Not a big deal; pass -q to the %setup macro if you want to quiet this. rpmlint on the built RPM says: E: cobbler non-executable-script /usr/lib/python2.4/site-packages/cobbler/gui.py 0644 rpmlint fires this off anytime it sees a shebang line in a file that's not executable. For Python source this is often bogus; it depends on whether the code is actually runnable (i.e. contains something other than class definitions). This seems to be the case here, so the rpmlint complaint can be ignored. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cobbler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192311 ------- Additional Comments From mdehaan(a)redhat.com 2006-08-16 17:09 EST ------- """ Source0: does not contain a URL to the upstream tarball. I'd consider this a blocker unless somehow there is no upstream other than this package. """ I am the upstream; the SRPM is canonical. This app is not expected to work outside of RHEL4+/FC5+ without modification. Seeing it includes kickstart features (which are already very distro specific) that shouldn't be a problem. -------------- "Really odd for the sticky bit to be set on a spec file." Fixed. -------------- """ W: cobbler setup-not-quiet Not a big deal; pass -q to the %setup macro if you want to quiet this. """ Fixed. ---------------------------- """ cobbler non-executable-script /usr/lib/python2.4/site-packages/cobbler/gui.py 0644 """ Fixed. That file should not have been in the release. -------------------- rpmlint on both RPM's yields no output at this point and unit tests pass. New versions: http://et.redhat.com/~mdehaan/software/cobbler/cobbler-0.1.1-5.src.rpm http://et.redhat.com/~mdehaan/software/cobbler/cobbler-0.1.1-5.noarch.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cobbler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192311 ------- Additional Comments From mdehaan(a)redhat.com 2006-08-25 10:16 EST ------- Ping. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cobbler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192311 ------- Additional Comments From mdehaan(a)redhat.com 2006-09-11 09:53 EST ------- John (et al), Thanks! Would you mind sponsoring me on this? I'm currently lacking sponsorship and can't submit otherwise. The CLA is in the mail. Michael -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cobbler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192311 ------- Additional Comments From mdehaan(a)redhat.com 2006-09-20 14:39 EST ------- Newness: Source code of released builds is now available in Mercurial: http://hg.et.redhat.com/hg/emd/applications/cobbler New home for files: http://et.redhat.com/~mdehaan/software/repo/ Accessible via yum: http://et.redhat.com/~mdehaan/software/mdehaan.repo All of this info is updated on the Wiki page: http://et.redhat.com/page/Cobbler_%26_Koan_Provisioning_Tools -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cobbler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192311 ------- Additional Comments From katzj(a)redhat.com 2006-09-27 15:51 EST ------- Sponsored you, should eb good to go for building -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cobbler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192311 tibbs(a)math.uh.edu changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|177841 | nThis| | -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=192311 Scott J Henson <shenson(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.